Prometheus2 charm

Code review comment for ~martin-hilton/charm-prometheus2:001-fix-storage-arguments

  1. Git
  2. lp:~martin-hilton/charm-prometheus2
  3. 001-fix-storage-arguments
  4. Merge into master
Revision history for this message
Thomas Cuthbert (tcuthbert) wrote :

LGTM +1
I noticed that the storage path argument is different, did a bit of investigation and worked out that the command in 1.8 is actually different to `--storage.tsdb.path` so I am a little perplexed how this worked in the first place...

review: Approve

« Back to merge proposal