Code review comment for lp:~martin-borho/ubuntu-weather-app/reboot-nav-and-snap-scrolling

- newly added ListView for horizontal scrolling cannot be used with "snapMode: ListView.SnapOneItem", because the "currentIndex" property is getting ignored when doing so (Bug!?) I have implemented a non-snap-mode solution the, until problem with snapMode gets sorted out.

This sounds strange I'll investigate to see if i can figure out what is going on.

- app won't start on device, claiming "LocationPane is no type". But works on desktop!

The component is probably missing in the cmake and not being included in the .click? or an import is failing somewhere.

- jumping through the bottom edge to a location does't work reliable all the time. Some things are broken somehow (Qt/SDK?). Log output:

Most of those warnings you can safely ignore, but it should be able to work all of the time, i'll double check if there isn't something causing it to break.

1 inline comment:
- I wonder if we can change this to mainPageStack.push("ui/HomePage.qml") instead of using the component?
- I have some massive OCD over formatting, could you ensure that all of the properties have a space between the : and the value?