Merge lp:~mars/launchpad/yui-3final-upgrade into lp:launchpad/db-devel

[Māris Fogels]

[Māris Fogels (mars)]

Hi,

This branch upgrades Launchpad's JavaScript from YUI 3 PR2 to YUI 3.0.0 final.

The branch has a few windmill errors, so it should not be merged quite yet. However, the diff is large, so it is probably in everyone's best interest to review it before it grows more.

There are some changes to the underlying build system that need to be reverted before submission, such as the changes to setup.py, buildout.cfg, etc.

[Francis J. Lacoste (flacoste)]

On November 13, 2009, Māris Fogels wrote:
> Māris Fogels has proposed merging lp:~mars/launchpad/yui-3final-upgrade
> into lp:launchpad.
>
> Requested reviews:
> Canonical Launchpad Engineering (launchpad)
>
>
> Hi,
>
> This branch upgrades Launchpad's JavaScript from YUI 3 PR2 to YUI 3.0.0
> final.
>
> The branch has a few windmill errors, so it should not be merged quite yet.
> However, the diff is large, so it is probably in everyone's best interest
> to review it before it grows more.
>
> There are some changes to the underlying build system that need to be
> reverted before submission, such as the changes to setup.py, buildout.cfg,
> etc.
>

  status approved
  review approve code

Thanks a lot for this branch! It contains a lot of nice clean-ups and even a
bug fix!

Here are the few comments I have and we already discussed those live. So feel
free to land on db-devel once these are handled. We should do QA on staging
Monday and Tuesday, and if most of the things seem to work, let's land it on
devel Wednesday.

Cheers

--
Francis J. Lacoste
<email address hidden>

review: Approve (code)

=== modified file 'Makefile'
--- Makefile	2009-11-17 13:14:18 +0000
+++ Makefile	2009-11-18 13:45:26 +0000
@@ -17,6 +17,7 @@
 
 LPCONFIG=development
 
+JSFLAGS=
 LP_BUILT_JS_ROOT=lib/canonical/launchpad/icing/build
 LAZR_BUILT_JS_ROOT=lazr-js/build
 
@@ -124,12 +125,17 @@
 build: $(BZR_VERSION_INFO) compile apidoc jsbuild
 
 jsbuild_lazr:
-	${SHHH} bin/jsbuild -b lazr-js/build
+	# We absolutely do not want to include the lazr.testing module and its
+	# jsTestDriver test harness modifications in the lazr.js and launchpad.js
+	# roll-up files.  They fiddle with built-in functions!  See Bug 482340.
+	${SHHH} bin/jsbuild $(JSFLAGS) -b $(LAZR_BUILT_JS_ROOT) -x testing/
 
 jsbuild: jsbuild_lazr
 	${SHHH} bin/jsbuild \
-		-n launchpad -s lib/canonical/launchpad/javascript \
-		-b lib/canonical/launchpad/icing/build \
+		$(JSFLAGS) \
+		-n launchpad \
+		-s lib/canonical/launchpad/javascript \
+		-b $(LP_BUILT_JS_ROOT) \
 		lib/canonical/launchpad/icing/MochiKit.js \
 		$(shell $(HERE)/utilities/yui-deps.py) \
 		lib/canonical/launchpad/icing/lazr/build/lazr.js
 
=== added symlink 'lib/canonical/launchpad/icing/lazr'
=== target is u'../../../../lazr-js'
=== removed symlink 'lib/canonical/launchpad/icing/lazr'
=== target was u'../../../../lazr-js'
=== added symlink 'lib/canonical/launchpad/icing/yui'
=== target is u'../../../../lazr-js/build/yui'
=== removed symlink 'lib/canonical/launchpad/icing/yui'
=== target was u'../../../../lazr-js/build/yui'
=== modified file 'lib/canonical/launchpad/javascript/bugs/bug_tags_entry.js'
--- lib/canonical/launchpad/javascript/bugs/bug_tags_entry.js	2009-07-17 18:46:25 +0000
+++ lib/canonical/launchpad/javascript/bugs/bug_tags_entry.js	2009-11-18 13:45:26 +0000
@@ -42,12 +42,11 @@
  */
 var populate_tags_input = function() {
     var tags = [];
-    var anchors = tag_list_span.queryAll(A);
-    if (anchors != null) {
-      tag_list_span.queryAll(A).each(function(a) {
-          tags.push(a.get(INNER_HTML));
-      });
-    }
+
+    tag_list_span.all(A).each(function(anchor) {
+        tags.push(anchor.get(INNER_HTML));
+    });
+
     tag_input.set(VALUE, tags.join(' ') + ' ');
 };
 
@@ -68,7 +67,7 @@
             function(elem) { return elem != ''; });
     var bug = new LP.client.Entry(
         lp_client, LP.client.cache[BUG], LP.client.cache[BUG].self_link);
-    bug.removeAtt('http_etag');
+    bug.removeAttr('http_etag');
     bug.set('tags', tags);
     tags_edit_spinner.setStyle(DISPLAY, INLINE);
     ok_button.setStyle(DISPLAY, NONE);
@@ -104,10 +103,10 @@
             tags_edit_spinner.setStyle(DISPLAY, NONE);
             Y.lazr.anim.green_flash({ node: tag_list_span }).run();
             if (Y.Lang.trim(tags_html) == '') {
-                Y.get('#bug-tags').removeClass(TAGS_SHOW);
-                Y.get('#bug-tags').addClass(TAGS_HIDE);
-                Y.get('#add-bug-tags').removeClass(TAGS_HIDE);
-                Y.get('#add-bug-tags').addClass(TAGS_SHOW);
+                Y.one('#bug-tags').removeClass(TAGS_SHOW);
+                Y.one('#bug-tags').addClass(TAGS_HIDE);
+                Y.one('#add-bug-tags').removeClass(TAGS_HIDE);
+                Y.one('#add-bug-tags').addClass(TAGS_SHOW);
             }
         },
         failure: function(id, request) {
@@ -132,10 +131,10 @@
     autocomplete.hide()
     Y.lazr.anim.red_flash({ node: tag_list_span }).run();
     if (Y.Lang.trim(tag_list_span.get('innerHTML')) == '') {
-        Y.get('#bug-tags').removeClass(TAGS_SHOW);
-        Y.get('#bug-tags').addClass(TAGS_HIDE);
-        Y.get('#add-bug-tags').removeClass(TAGS_HIDE);
-        Y.get('#add-bug-tags').addClass(TAGS_SHOW);
+        Y.one('#bug-tags').removeClass(TAGS_SHOW);
+        Y.one('#bug-tags').addClass(TAGS_HIDE);
+        Y.one('#add-bug-tags').removeClass(TAGS_HIDE);
+        Y.one('#add-bug-tags').addClass(TAGS_SHOW);
     }
 };
 
@@ -164,15 +163,15 @@
     if (LP.client.links['me'] === undefined) { return; }
 
     available_tags = Y.Array(available_official_tags);
-    bug_tags_div = Y.get('#bug-tags');
-    edit_tags_trigger = bug_tags_div.query('#edit-tags-trigger');
-    add_tags_trigger = Y.get('#add-tags-trigger');
-    tag_list_span = bug_tags_div.query('#tag-list');
-    tag_input = bug_tags_div.query('#tag-input');
-    ok_button = bug_tags_div.query('#edit-tags-ok');
-    cancel_button = bug_tags_div.query('#edit-tags-cancel');
-    tags_edit_spinner = bug_tags_div.query('#tags-edit-spinner');
-    tags_form = bug_tags_div.query('#tags-form');
+    bug_tags_div = Y.one('#bug-tags');
+    edit_tags_trigger = bug_tags_div.one('#edit-tags-trigger');
+    add_tags_trigger = Y.one('#add-tags-trigger');
+    tag_list_span = bug_tags_div.one('#tag-list');
+    tag_input = bug_tags_div.one('#tag-input');
+    ok_button = bug_tags_div.one('#edit-tags-ok');
+    cancel_button = bug_tags_div.one('#edit-tags-cancel');
+    tags_edit_spinner = bug_tags_div.one('#tags-edit-spinner');
+    tags_form = bug_tags_div.one('#tags-form');
 
     edit_tags_trigger.on('click', function(e) {
         e.halt();
@@ -181,10 +180,10 @@
 
     add_tags_trigger.on('click', function(e) {
         e.halt();
-        Y.get('#bug-tags').removeClass(TAGS_HIDE);
-        Y.get('#bug-tags').addClass(TAGS_SHOW);
-        Y.get('#add-bug-tags').removeClass(TAGS_SHOW);
-        Y.get('#add-bug-tags').addClass(TAGS_HIDE);
+        Y.one('#bug-tags').removeClass(TAGS_HIDE);
+        Y.one('#bug-tags').addClass(TAGS_SHOW);
+        Y.one('#add-bug-tags').removeClass(TAGS_SHOW);
+        Y.one('#add-bug-tags').addClass(TAGS_HIDE);
         edit();
     });
 
 
=== modified file 'lib/canonical/launchpad/javascript/bugs/bugtask-index.js'
--- lib/canonical/launchpad/javascript/bugs/bugtask-index.js	2009-11-14 21:14:40 +0000
+++ lib/canonical/launchpad/javascript/bugs/bugtask-index.js	2009-11-18 13:45:26 +0000
@@ -85,21 +85,21 @@
 Y.bugs.portlet.subscribe('bugs:nameloaded', function(subscription) {
     var error_handler = new LP.client.ErrorHandler();
     error_handler.clearProgressUI = function() {
-        var temp_link = Y.get('#temp-username');
+        var temp_link = Y.one('#temp-username');
         if (temp_link) {
             var temp_parent = temp_link.get('parentNode');
             temp_parent.removeChild(temp_link);
         }
     };
     error_handler.showError = function(error_msg) {
-        Y.lp.display_error(Y.get('.menu-link-addsubscriber'), error_msg);
+        Y.lp.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
     };
 
     var config = {
         on: {
             success: function() {
-                var temp_link = Y.get('#temp-username');
-                var temp_spinner = Y.get('#temp-name-spinner');
+                var temp_link = Y.one('#temp-username');
+                var temp_spinner = Y.one('#temp-name-spinner');
                 temp_link.removeChild(temp_spinner);
                 var anim = Y.lazr.anim.green_flash({ node: temp_link });
                 anim.on('end', function() {
@@ -136,17 +136,14 @@
 
         setup_client_and_bug();
 
-        // First look for 'Mark as duplicate' links.
-        var update_dupe_links = Y.all('.menu-link-mark-dupe');
-
-        // If there are none, check for any 'change duplicate bug' links.
-        if (!update_dupe_links){
-            update_dupe_links = Y.all('#change_duplicate_bug');
-        }
-
-        if (update_dupe_links) {
+        // Look for the 'Mark as duplicate' links or the
+        // 'change duplicate bug' link.
+        var update_dupe_link = Y.one(
+            '.menu-link-mark-dupe, #change_duplicate_bug');
+
+        if (update_dupe_link) {
             // First things first, pre-load the mark-dupe form.
-            update_dupe_url = update_dupe_links.item(0).getAttribute('href');
+            update_dupe_url = update_dupe_link.get('href');
             var mark_dupe_form_url = update_dupe_url + '/++form++';
 
             duplicate_form_overlay = new Y.lazr.FormOverlay({
@@ -165,7 +162,7 @@
 
             // Add an on-click handler to any links found that displays
             // the form overlay.
-            update_dupe_links.on('click', function(e){
+            update_dupe_link.on('click', function(e) {
                 // Only go ahead if we have received the form content by the
                 // time the user clicks:
                 if (duplicate_form_overlay){
@@ -174,17 +171,17 @@
                 }
             });
             // Add a class denoting them as js-action links.
-            update_dupe_links.addClass('js-action');
+            update_dupe_link.addClass('js-action');
         }
 
-        privacy_link = Y.get('#privacy-link');
+        privacy_link = Y.one('#privacy-link');
 
         if (privacy_link) {
             var privacy_link_url = privacy_link.getAttribute('href') + '/++form++';
-            var privacy_div = Y.get('#privacy-text');
+            var privacy_div = Y.one('#privacy-text');
             var privacy_html = privacy_link.get('innerHTML') + ' ';
             privacy_div.set('innerHTML', privacy_html);
-            var privacy_text = Y.get('#privacy-text');
+            var privacy_text = Y.one('#privacy-text');
             privacy_link = Y.Node.create(
                 '<a id="privacy-link" class="sprite edit" title="[edit]">' +
                 '<span class="invisible-link">edit</span></a>');
@@ -210,7 +207,7 @@
                     e.preventDefault();
                     privacy_form_overlay.show();
                     // XXX Abel Deuring 2009-04-23, bug 365462
-                    // Y.get('#field.private') returns null.
+                    // Y.one('#field.private') returns null.
                     // Seems that YUI does not like IDs containing a '.'
                     document.getElementById('field.private').focus();
                 }
@@ -230,7 +227,7 @@
  * @param e {Object} The event object.
  */
 function clear_picker(e) {
-    var input = Y.get('.yui-picker-search-box input');
+    var input = Y.one('.yui-picker-search-box input');
     input.set('value', '');
     this.set('error', '');
     this.set('results', [{}]);
@@ -258,7 +255,7 @@
     picker.on('save', clear_picker, picker);
     picker.on('cancel', clear_picker, picker);
 
-    var subscription_link_someone_else = Y.get('.menu-link-addsubscriber');
+    var subscription_link_someone_else = Y.one('.menu-link-addsubscriber');
     subscription_link_someone_else.on('click', function(e) {
         e.halt();
         picker.show();
@@ -278,8 +275,8 @@
 
     setup_client_and_bug();
     var subscription = new Y.lp.Subscription({
-        link: Y.get('.menu-link-subscription'),
-        spinner: Y.get('#sub-unsub-spinner'),
+        link: Y.one('.menu-link-subscription'),
+        spinner: Y.one('#sub-unsub-spinner'),
         subscriber: new Y.lp.Subscriber({
             uri: LP.client.links.me,
             subscriber_ids: subscriber_ids
@@ -333,13 +330,11 @@
             subscriber_ids: subscriber_ids
         })
     });
-    var unsubscribe_icons = Y.all('.unsub-icon');
-    if (unsubscribe_icons) {
-        unsubscribe_icons.on('click', function(e) {
-            e.halt();
-            unsubscribe_user_via_icon(e.target, subscription);
-        });
-    }
+
+    Y.on('click', function(e) {
+        e.halt();
+        unsubscribe_user_via_icon(e.target, subscription);
+    }, '.unsub-icon');
 }
 
 /*
@@ -371,13 +366,13 @@
     // subscribing can be done inline.  Named operations
     // don't return new objects, making the cached bug's
     // etag invalid as well.
-    lp_bug_entry.removeAtt('http_etag');
+    lp_bug_entry.removeAttr('http_etag');
 
     // Hide the formoverlay:
     duplicate_form_overlay.hide();
 
     // Add the spinner...
-    var dupe_span = Y.get('#mark-duplicate-text');
+    var dupe_span = Y.one('#mark-duplicate-text');
     dupe_span.addClass('update-in-progress-message');
 
     // Set the new duplicate link on the bug entry.
@@ -403,22 +398,22 @@
                         'Duplicate of <a>bug #</a> ',
                         '<a class="menu-link-mark-dupe js-action sprite edit">',
                         '<span class="invisible-link">edit</span></a>'].join(""));
-                    dupe_span.queryAll('a').item(0)
+                    dupe_span.all('a').item(0)
                         .set('href', '/bugs/' + new_dup_id)
                         .appendChild(document.createTextNode(new_dup_id));
-                    dupe_span.queryAll('a').item(1)
+                    dupe_span.all('a').item(1)
                         .set('href', update_dupe_url);
                     show_comment_on_duplicate_warning();
                 } else {
                     dupe_span.set('innerHTML', [
                         '<a class="menu-link-mark-dupe js-action ',
                         'sprite bug-dupe">Mark as duplicate</a>'].join(""));
-                    dupe_span.query('a').set('href', update_dupe_url);
+                    dupe_span.one('a').set('href', update_dupe_url);
                     hide_comment_on_duplicate_warning();
                 }
                 Y.lazr.anim.green_flash({node: dupe_span}).run();
                 // ensure the new link is hooked up correctly:
-                dupe_span.query('a.menu-link-mark-dupe').on(
+                dupe_span.one('a.menu-link-mark-dupe').on(
                     'click', function(e){
                         e.preventDefault();
                         duplicate_form_overlay.show();
@@ -454,9 +449,9 @@
  * @method show_comment_on_duplicate_warning
  */
 var show_comment_on_duplicate_warning = function() {
-    var duplicate_warning = Y.get('#warning-comment-on-duplicate');
+    var duplicate_warning = Y.one('#warning-comment-on-duplicate');
     if (duplicate_warning === null) {
-        var container = Y.get('#add-comment-form');
+        var container = Y.one('#add-comment-form');
         var first_node = container.get('firstChild');
         duplicate_warning = Y.Node.create(
             ['<div class="warning message" id="warning-comment-on-duplicate">',
@@ -474,7 +469,7 @@
  * @method hide_comment_on_duplicate_warning
  */
 var hide_comment_on_duplicate_warning = function() {
-    var duplicate_warning = Y.get('#warning-comment-on-duplicate');
+    var duplicate_warning = Y.one('#warning-comment-on-duplicate');
     if (duplicate_warning !== null) {
         duplicate_warning.ancestor().removeChild(duplicate_warning);
     }
@@ -492,12 +487,12 @@
     // subscribing can be done inline.  Named operations
     // don't return new objects, making the cached bug's
     // etag invalid as well.
-    lp_bug_entry.removeAtt('http_etag');
+    lp_bug_entry.removeAttr('http_etag');
 
     privacy_form_overlay.hide();
 
-    var privacy_text = Y.get('#privacy-text');
-    var privacy_div = Y.get('#privacy');
+    var privacy_text = Y.one('#privacy-text');
+    var privacy_div = Y.one('#privacy');
     privacy_link.setStyle('display', 'none');
     privacy_spinner.setStyle('display', 'inline');
 
@@ -550,7 +545,7 @@
                 privacy_text.appendChild(privacy_link);
                 privacy_text.appendChild(privacy_spinner);
 
-                var security_message = Y.get('#security-message');
+                var security_message = Y.one('#security-message');
                 if (security_related) {
                     if (security_message === null) {
                         var security_message_html = [
@@ -591,7 +586,7 @@
         link_branch_link.toggleClass('update-in-progress-message');
     };
     error_handler.showError = function(error_msg) {
-        display_error(Y.get('.menu-link-addsubscriber'), error_msg);
+        display_error(Y.one('.menu-link-addsubscriber'), error_msg);
     };
 
     function get_branch_and_link_to_bug(data) {
@@ -609,7 +604,7 @@
     }
 
     // Set up the picker itself.
-    link_branch_link = Y.get('.menu-link-addbranch');
+    link_branch_link = Y.one('.menu-link-addbranch');
     if (Y.Lang.isValue(link_branch_link)) {
         var config = {
             header: 'Link a related branch',
@@ -642,7 +637,7 @@
         link_branch_link.toggleClass('update-in-progress-message');
     };
     error_handler.showError = function(error_msg) {
-        display_error(Y.get('.menu-link-addsubscriber'), error_msg);
+        display_error(Y.one('.menu-link-addsubscriber'), error_msg);
     };
 
     // Call linkBranch() on the bug.
@@ -683,21 +678,21 @@
 function add_branch_to_linked_branches(branch_html) {
     var anim;
     var bug_branch_node = Y.Node.create(branch_html);
-    var bug_branch_list = Y.get('#bug-branches');
+    var bug_branch_list = Y.one('#bug-branches');
     if (!Y.Lang.isValue(bug_branch_list)) {
         bug_branch_list = Y.Node.create(
             '<div id="bug-branches">' +
             '  <h2>Related branches</h2>' +
             '</div>');
 
-        var bug_branch_container = Y.get('#bug-branches-container');
+        var bug_branch_container = Y.one('#bug-branches-container');
         bug_branch_container.appendChild(bug_branch_list);
         anim = Y.lazr.anim.green_flash({node: bug_branch_list});
     } else {
         anim = Y.lazr.anim.green_flash({node: bug_branch_node});
     }
 
-    var existing_bug_branch_node = bug_branch_list.query(
+    var existing_bug_branch_node = bug_branch_list.one(
         '#' + bug_branch_node.getAttribute('id'));
     if (!Y.Lang.isValue(existing_bug_branch_node)) {
         // Only add the bug branch to the page if it isn't there
@@ -723,7 +718,7 @@
     // This should be parent_div.firstChild, but because of #text
     // and cross-browser issues, using the YUI query syntax is
     // safer here.
-    var user_uri = parent_div.query('a').getAttribute('href');
+    var user_uri = parent_div.one('a').getAttribute('href');
 
     // Strip the domain off. We just want a path.
     var host_start = user_uri.indexOf('//');
@@ -769,7 +764,7 @@
     var html = Y.Node.create('<div><a></a></div>');
     html.addClass(terms.css_name);
 
-    html.query('a')
+    html.one('a')
         .set('href', '/~' + terms.name)
         .set('name', terms.full_name)
         .set('title', 'Subscribed ' + terms.subscribed_by);
@@ -781,7 +776,7 @@
         span = '<span class="sprite person"></span>';
     }
 
-    html.query('a')
+    html.one('a')
         .appendChild(Y.Node.create(span))
         .appendChild(document.createTextNode(terms.display_name));
 
@@ -793,7 +788,7 @@
         icon_html
             .set('id', 'unsubscribe-' + terms.css_name)
             .set('title', 'Unsubscribe ' + terms.full_name);
-        icon_html.query('img')
+        icon_html.one('img')
             .set('id', 'unsubscribe-icon-' + terms.css_name);
         html.appendChild(icon_html);
     }
@@ -834,15 +829,14 @@
 
     // Use the list of subscribers pulled from the DOM to have sortable
     // lists of unsubscribable vs. not unsubscribale person links.
-    var subscribers = Y.get('#subscribers-links');
-    var all_subscribers = subscribers.queryAll('div');
-    if (Y.Lang.isValue(all_subscribers)) {
+    var all_subscribers = Y.all('#subscribers-links div');
+    if (all_subscribers.size() > 0) {
         all_subscribers.each(function(sub_link) {
             if (sub_link.getAttribute('id') != 'temp-username') {
                 // User's displayname is found via the link's "name" attribute.
-                var sub_link_name = sub_link.query('a').getAttribute('name');
+                var sub_link_name = sub_link.one('a').getAttribute('name');
                 nodes_by_name[sub_link_name] = sub_link;
-                if (sub_link.query('img.unsub-icon')) {
+                if (sub_link.one('img.unsub-icon')) {
                     unsubscribables.push(sub_link_name);
                 } else {
                     not_unsubscribables.push(sub_link_name);
@@ -915,7 +909,7 @@
 function add_user_name_link(subscription) {
     var person = subscription.get('person');
     var link_node = build_user_link_html(subscription);
-    var subscribers = Y.get('#subscribers-links');
+    var subscribers = Y.one('#subscribers-links');
     if (subscription.is_current_user_subscribing()) {
         // If this is the current user, then top post the name and be done.
         subscribers.insertBefore(link_node, subscribers.get('firstChild'));
@@ -925,7 +919,7 @@
             subscribers.insertBefore(link_node, next);
         } else {
             // Handle the case of the displayed "None".
-            var none_subscribers = Y.get('#none-subscribers');
+            var none_subscribers = Y.one('#none-subscribers');
             if (none_subscribers) {
                 var none_parent = none_subscribers.get('parentNode');
                 none_parent.removeChild(none_subscribers);
@@ -936,7 +930,7 @@
 
     // Set the click handler if adding a remove icon.
     if (subscription.can_be_unsubscribed_by_user()) {
-        var remove_icon = Y.get('#unsubscribe-icon-' + person.get('css_name'));
+        var remove_icon = Y.one('#unsubscribe-icon-' + person.get('css_name'));
         remove_icon.on('click', function(e) {
             e.halt();
             unsubscribe_user_via_icon(e.target, subscription);
@@ -974,18 +968,18 @@
         '  <span>Other Display Name</span>',
         '  <img id="temp-name-spinner" src="/@@/spinner" alt="" ',
         '       style="position:absolute;right:8px" /></div>'].join(''));
-    link_node.query('img').set('src', img_src);
+    link_node.one('img').set('src', img_src);
     link_node.replaceChild(
         document.createTextNode(display_name),
-        link_node.query('span'));
+        link_node.one('span'));
 
-    var subscribers = Y.get('#subscribers-links');
+    var subscribers = Y.one('#subscribers-links');
     var next = get_next_subscriber_node(subscription);
     if (next) {
         subscribers.insertBefore(link_node, next);
     } else {
         // Handle the case of the displayed "None".
-        var none_subscribers = Y.get('#none-subscribers');
+        var none_subscribers = Y.one('#none-subscribers');
         if (none_subscribers) {
             var none_parent = none_subscribers.get('parentNode');
             none_parent.removeChild(none_subscribers);
@@ -1005,19 +999,19 @@
  * @method set_none_for_empty_subscribers
  */
 function set_none_for_empty_subscribers() {
-    var subscriber_list = Y.get('#subscribers-links');
+    var subscriber_list = Y.one('#subscribers-links');
     // Assume if subscriber_list has no child divs
     // then the list of subscribers is empty.
-    if (!Y.Lang.isValue(subscriber_list.query('div')) &&
-        !Y.Lang.isValue(Y.get('#none-subscribers'))) {
+    if (!Y.Lang.isValue(subscriber_list.one('div')) &&
+        !Y.Lang.isValue(Y.one('#none-subscribers'))) {
         var none_div = Y.Node.create('<div id="none-subscribers">None</div>');
         subscriber_list.appendChild(none_div);
     }
 
     // Clear the empty duplicate subscribers list if it exists.
-    var dup_list = Y.get('#subscribers-from-duplicates');
+    var dup_list = Y.one('#subscribers-from-duplicates');
     if (Y.Lang.isValue(dup_list) &&
-        !Y.Lang.isValue(dup_list.query('div'))) {
+        !Y.Lang.isValue(dup_list.one('div'))) {
         var parent = dup_list.get('parentNode');
         parent.removeChild(dup_list);
     }
@@ -1088,7 +1082,7 @@
     error_handler.clearProgressUI = function () {
         icon.set('src', '/@@/remove');
         // Grab the icon again to reset to click handler.
-        var unsubscribe_icon = Y.get(
+        var unsubscribe_icon = Y.one(
             '#unsubscribe-icon-' + person.get('css_name'));
         unsubscribe_icon.on('click', function(e) {
             e.halt();
@@ -1097,7 +1091,7 @@
 
     };
     error_handler.showError = function (error_msg) {
-        var flash_node = Y.get('.' + person.get('css_name'));
+        var flash_node = Y.one('.' + person.get('css_name'));
         Y.lp.display_error(flash_node, error_msg);
 
     };
@@ -1111,7 +1105,7 @@
                 anim.on('end', function(e) {
                     remove_user_name_link(icon_parent_div);
                     set_none_for_empty_subscribers();
-                    var person_link = Y.get('.' + person.get('css_name'));
+                    var person_link = Y.one('.' + person.get('css_name'));
                     if (Y.Lang.isNull(person_link) &&
                         subscription.is_current_user_subscribing()) {
                             // Current user has been completely unsubscribed.
@@ -1190,7 +1184,7 @@
                 }
 
                 // Handle the case where the subscriber's list displays "None".
-                var empty_subscribers = Y.get("#none-subscribers");
+                var empty_subscribers = Y.one("#none-subscribers");
                 if (empty_subscribers) {
                     var parent = empty_subscribers.get('parentNode');
                     parent.removeChild(empty_subscribers);
@@ -1198,7 +1192,7 @@
 
                 add_user_name_link(subscription);
 
-                var flash_node = Y.get('.' + subscriber.get('css_name'));
+                var flash_node = Y.one('.' + subscriber.get('css_name'));
                 var anim = Y.lazr.anim.green_flash({ node: flash_node });
                 anim.run();
             },
@@ -1258,7 +1252,7 @@
                     subscription.set('has_dupes', false);
                 }
 
-                var flash_node = Y.get('.' + subscriber.get('css_name'));
+                var flash_node = Y.one('.' + subscriber.get('css_name'));
                 var anim = Y.lazr.anim.green_flash({ node: flash_node });
                 anim.on('end', function(e) {
                     remove_user_name_link(flash_node);
@@ -1291,12 +1285,18 @@
         return;
     }
 
-    var tr = Y.get('#' + conf.row_id);
-    var bugtarget_content = Y.get('#bugtarget-picker-' + conf.row_id);
-    var status_content = tr.query('.status-content');
-    var importance_content = tr.query('.importance-content');
-    var assignee_content = Y.get('#assignee-picker-' + conf.row_id);
-    var milestone_content = tr.query('.milestone-content');
+    var tr = Y.one('#' + conf.row_id);
+    var bugtarget_content = Y.one('#bugtarget-picker-' + conf.row_id);
+    var status_content = tr.one('.status-content');
+    var importance_content = tr.one('.importance-content');
+    var assignee_content = Y.one('#assignee-picker-' + conf.row_id);
+    var milestone_content = tr.one('.milestone-content');
+
+    if (status_content === null) {
+        // Not all table rows have status widgets.  If this is one of those
+        // rows, then bail.
+        return;
+    }
 
     if (Y.Lang.isValue(LP.client.cache.bug) &&
         Y.Lang.isValue(LP.client.cache.bug.duplicate_of_link)) {
@@ -1316,7 +1316,7 @@
                         Y.DOM.create(
                             '<a href="+editstatus" ' +
                             '   class="sprite edit yui-activator-act" />'),
-                        bugtarget_content.query('.yui-activator-act'));
+                        bugtarget_content.one('.yui-activator-act'));
                 } else {
                     var bugtarget_picker = Y.lp.picker.addPickerPatcher(
                         'Product',
@@ -1354,7 +1354,7 @@
                 });
                 // Set the inline form control's value, so that submitting
                 // it won't override the value we just set.
-                Y.get(document.getElementById(conf.prefix + '.status')).set(
+                Y.one(document.getElementById(conf.prefix + '.status')).set(
                     'value', status_choice_edit.get('value'));
             });
             status_choice_edit.plug({
@@ -1386,7 +1386,7 @@
                 });
                 // Set the inline form control's value, so that submitting
                 // it won't override the value we just set.
-                Y.get(document.getElementById(conf.prefix + '.importance')).set(
+                Y.one(document.getElementById(conf.prefix + '.importance')).set(
                     'value', importance_choice_edit.get('value'));
             });
             importance_choice_edit.plug({
@@ -1422,18 +1422,18 @@
                 // to have a more established way of getting the web URL of
                 // an API object. Once such a solution is available we should
                 // fix this.
-                milestone_content.query('.value').setAttribute(
+                milestone_content.one('.value').setAttribute(
                     'href', new_value.replace('/api/beta', ''));
             }
             // Set the inline form control's value, so that submitting
             // it won't override the value we just set.
-            var inline_combo = Y.get(
+            var inline_combo = Y.one(
                 document.getElementById(conf.prefix + '.milestone'));
             if (Y.Lang.isValue(inline_combo)) {
             inline_combo.set('value', null);
                 Y.Array.each(milestone_choice_edit.get('items'), function(item) {
                     if (item.value == milestone_choice_edit.get('value')) {
-                        inline_combo.queryAll('option').each(function(opt) {
+                        inline_combo.all('option').each(function(opt) {
                             if (opt.get('innerHTML') == item.name) {
                                 opt.set('selected', true);
                             }
@@ -1444,11 +1444,11 @@
             // Force redrawing the UI
             milestone_choice_edit._uiClearWaiting();
         });
-        milestone_content.query('.nulltext').on(
+        milestone_content.one('.nulltext').on(
             'mousedown',
             milestone_choice_edit._onMouseDown,
             milestone_choice_edit);
-        milestone_choice_edit.render();        
+        milestone_choice_edit.render();
     }
     if (Y.Lang.isValue(assignee_content)) {
         var assignee_picker = Y.lp.picker.addPickerPatcher(
@@ -1480,7 +1480,7 @@
     if (Y.UA.ie) {
         return;
     }
-    var me_too_content = Y.get('#affectsmetoo');
+    var me_too_content = Y.one('#affectsmetoo');
     var me_too_edit = new MeTooChoiceSource({
         contentBox: me_too_content, value: user_is_affected,
         elementToFlash: me_too_content,
@@ -1541,7 +1541,7 @@
      * affected by the current bug. Should be automatically calculated
      * by HTML_PARSER.
      *
-     * Setter function returns Y.get(parameter) so that you can pass
+     * Setter function returns Y.one(parameter) so that you can pass
      * either a Node (as expected) or a selector.
      *
      * @attribute value_location
@@ -1550,7 +1550,7 @@
     flame_icon: {
         value: null,
         set: function(v) {
-            return Y.get(v);
+            return Y.one(v);
         }
     }
 };
@@ -1589,8 +1589,8 @@
         // Force the ChoiceSource to be rendered inline.
         this.get('boundingBox').setStyle('display', 'inline');
         // Hide the static content and show the dynamic content.
-        this.get('contentBox').query('.static').addClass('unseen');
-        this.get('contentBox').query('.dynamic').removeClass('unseen');
+        this.get('contentBox').one('.static').addClass('unseen');
+        this.get('contentBox').one('.dynamic').removeClass('unseen');
     },
 
     _saveData: function() {
@@ -1634,7 +1634,7 @@
 function check_can_be_unsubscribed(subscription) {
     var error_handler = new LP.client.ErrorHandler();
     error_handler.showError = function (error_msg) {
-        Y.lp.display_error(Y.get('.menu-link-addsubscriber'), error_msg);
+        Y.lp.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
     };
 
     var config = {
@@ -1703,7 +1703,7 @@
 
     var error_handler = new LP.client.ErrorHandler();
     error_handler.showError = function(error_msg) {
-        Y.lp.display_error(Y.get('.menu-link-addsubscriber'), error_msg);
+        Y.lp.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
     };
 
     if (subscription.is_already_subscribed()) {
@@ -1722,9 +1722,9 @@
  * @method setup_add_attachment
  */
 function setup_add_attachment() {
-    var attachment_link = Y.get('.menu-link-addcomment');
+    var attachment_link = Y.one('.menu-link-addcomment');
     attachment_link.on('click', function(e) {
-        var comment_input = Y.get('[id="field.comment"]');
+        var comment_input = Y.one('[id="field.comment"]');
         if (comment_input.get('value') !== '') {
             var current_url = attachment_link.getAttribute('href');
             var attachment_url = current_url + '?field.comment=' +
@@ -1779,10 +1779,10 @@
         return null;
     }
 
-    Y.get('#subscribers-portlet-spinner').setStyle('display', 'block');
+    Y.one('#subscribers-portlet-spinner').setStyle('display', 'block');
 
     function hide_spinner() {
-        Y.get('#subscribers-portlet-spinner').setStyle('display', 'none');
+        Y.one('#subscribers-portlet-spinner').setStyle('display', 'none');
             // Fire a custom event to notify that the initial click
             // handler on subscription_link set above should be
             // cleared.
@@ -1794,7 +1794,7 @@
 
     function on_success(transactionid, response, args) {
         hide_spinner();
-        var portlet = Y.get('#portlet-subscribers');
+        var portlet = Y.one('#portlet-subscribers');
         portlet.set('innerHTML',
                     portlet.get('innerHTML') + response.responseText);
 
@@ -1805,7 +1805,7 @@
 
     var config = {on: {success: on_success,
                        failure: hide_spinner}};
-    var url = Y.get(
+    var url = Y.one(
         '#subscribers-content-link').getAttribute('href').replace('bugs.', '');
     Y.io(url, config);
 };
 
=== modified file 'lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js'
--- lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js	2009-07-22 16:42:10 +0000
+++ lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js	2009-11-18 13:45:26 +0000
@@ -46,7 +46,7 @@
  */
 function get_details_div(expander) {
     var details_div = expander.get(
-        'parentNode').get('parentNode').query('.duplicate-details');
+        'parentNode').get('parentNode').one('.duplicate-details');
 
     // Check that the details_div actually exists and raise an error if
     // we can't find it.
@@ -77,24 +77,24 @@
  */
 function show_bug_reporting_form(e) {
     // Collapse all the duplicate-details divs.
-    Y.each(bug_already_reported_expanders, function(expander) {
+    bug_already_reported_expanders.each(function(expander) {
         collapse_bug_details(expander);
     });
 
     // Show the bug reporting form.
     bug_reporting_form.setStyle(DISPLAY, BLOCK);
-    Y.get(Y.DOM.byId('field.actions.submit_bug')).focus();
+    Y.one(Y.DOM.byId('field.actions.submit_bug')).focus();
     window.location.href = '#form-start';
 
     // Focus the relevant elements of the form based on
     // whether the package drop-down is displayed.
-    var bugtarget_package_btn = Y.get(
+    var bugtarget_package_btn = Y.one(
         Y.DOM.byId('field.bugtarget.option.package'));
     if (bugtarget_package_btn !== null &&
         bugtarget_package_btn !== undefined) {
-        Y.get(Y.DOM.byId('field.bugtarget.package')).focus();
+        Y.one(Y.DOM.byId('field.bugtarget.package')).focus();
     } else {
-        Y.get(Y.DOM.byId('field.comment')).focus();
+        Y.one(Y.DOM.byId('field.comment')).focus();
     }
 }
 
@@ -106,9 +106,9 @@
  */
 function create_subscribe_overlay(form) {
     // Grab the bug id and title from the "Yes, this is my bug" form.
-    var bug_id = form.query(
+    var bug_id = form.one(
         'input.bug-already-reported-as').get('value');
-    var bug_title = Y.get('#bug-' + bug_id + '-title').get('innerHTML');
+    var bug_title = Y.one('#bug-' + bug_id + '-title').get('innerHTML');
 
     if (bug_title.length > 35) {
         // Truncate the bug title if it's more than 30 characters long.
@@ -161,25 +161,16 @@
 
     // Add an on-click handler to the radio buttons to ensure that their
     // labels' styles are set correctly when they're selected.
-    var radio_buttons = form.queryAll('input.subscribe-option');
-    if (radio_buttons !== null && radio_buttons !== undefined) {
+    var radio_buttons = form.all('input.subscribe-option');
+    radio_buttons.on('click', function(e) {
+        // Loop over the radio buttons and set their parent
+        // div's font-weight depending on whether they're
+        // checked or not.
         Y.each(radio_buttons, function(radio_button) {
-            radio_button.on('click', function(e) {
-                // Loop over the radio buttons and set their parent
-                // div's font-weight depending on whether they're
-                // checked or not.
-                Y.each(radio_buttons, function(radio_button) {
-                    if (radio_button.get('checked')) {
-                        radio_button.get(
-                            'parentNode').setStyle('fontWeight', 'bold');
-                    } else {
-                        radio_button.get(
-                            'parentNode').setStyle('fontWeight', 'normal');
-                    }
-                });
-            });
+            var weight = radio_button.get('checked') ? 'bold' : 'normal';
+            radio_button.get('parentNode').setStyle('fontWeight', weight);
         });
-    }
+    });
 
     return subscribe_form_overlay;
 }
@@ -189,17 +180,16 @@
     Y.on('domready', function() {
         bug_already_reported_expanders = Y.all(
             'img.bug-already-reported-expander');
-        bug_reporting_form = Y.get('#bug_reporting_form');
+        bug_reporting_form = Y.one('#bug_reporting_form');
 
-        if (bug_already_reported_expanders !== null &&
-            bug_already_reported_expanders !== undefined) {
+        if (bug_already_reported_expanders.size() !== 0) {
 
             // Set up the onclick handlers for the expanders.
-            Y.each(Y.all('.similar-bug'), function(row) {
-                var bug_details_div = row.query('div.duplicate-details');
-                var image = row.query('img.bug-already-reported-expander');
-                var bug_title_link = row.query('.duplicate-bug-link');
-                var view_bug_link = row.query('.view-bug-link');
+            Y.all('.similar-bug').each(function(row) {
+                var bug_details_div = row.one('div.duplicate-details');
+                var image = row.one('img.bug-already-reported-expander');
+                var bug_title_link = row.one('.duplicate-bug-link');
+                var view_bug_link = row.one('.view-bug-link');
 
                 // Grab the initial height of the element and create a
                 // config for the slide_out animation. This allows us to
@@ -276,13 +266,13 @@
 
             // Collapse all the details divs, since we don't want them
             // expanded first up.
-            Y.each(Y.all('div.duplicate-details'), function(div) {
+            Y.all('div.duplicate-details').each(function(div) {
                 collapse_bug_details(div);
             });
 
         }
 
-        bug_not_reported_button = Y.get('#bug-not-already-reported');
+        bug_not_reported_button = Y.one('#bug-not-already-reported');
         if (bug_not_reported_button !== null &&
             bug_not_reported_button !== undefined) {
             // The bug_not_reported_button won't show up if there aren't any
@@ -291,8 +281,7 @@
         }
 
         // Attach the form overlay to the "Yes, this is my bug" forms.
-        var this_is_my_bug_forms = Y.all('form.this-is-my-bug-form');
-        Y.each(this_is_my_bug_forms, function(form) {
+        Y.all('form.this-is-my-bug-form').each(function(form) {
             var subscribe_form_overlay = create_subscribe_overlay(form);
 
             form.on('submit', function(e) {
 
=== modified file 'lib/canonical/launchpad/javascript/bugs/offical_bug_tags.js'
--- lib/canonical/launchpad/javascript/bugs/offical_bug_tags.js	2009-06-30 21:06:27 +0000
+++ lib/canonical/launchpad/javascript/bugs/offical_bug_tags.js	2009-11-18 13:45:26 +0000
@@ -129,8 +129,8 @@
             other_cbs_checked = other_cbs_checked || cb.get('checked');
         });
     }
-    Y.get('#remove-official-tags').set('disabled', !official_cbs_checked);
-    Y.get('#add-official-tags').set('disabled', !other_cbs_checked);
+    Y.one('#remove-official-tags').set('disabled', !official_cbs_checked);
+    Y.one('#add-official-tags').set('disabled', !other_cbs_checked);
 };
 
 /**
@@ -158,9 +158,9 @@
         item);
     var li_node = Y.Node.create(li_html);
     li_node._tag = item;
-    li_node.query('input').on('click', function(e) {
+    li_node.one('input').on('click', function(e) {
       enable_arrows();
-      var cb_node = li_node.query('input');
+      var cb_node = li_node.one('input');
       if (cb_node.get('checked')) {
         li_node.addClass('selected');
       } else {
@@ -179,8 +179,8 @@
  * @method render_tag_lists
  */
 var render_tag_lists = function() {
-    var official_tags_ul = Y.get('#official-tags-list');
-    var other_tags_ul = Y.get('#other-tags-list');
+    var official_tags_ul = Y.one('#official-tags-list');
+    var other_tags_ul = Y.one('#other-tags-list');
 
     official_tags_ul.set('innerHTML', '');
     other_tags_ul.set('innerHTML', '');
@@ -207,8 +207,8 @@
     Y.each(official_tags, function(item) {
         tags.push(item.tag);
     });
-    Y.get('#field-official_bug_tags').set('value', tags.join(' '));
-    Y.get('#save-form').submit();
+    Y.one('#field-official_bug_tags').set('value', tags.join(' '));
+    Y.one('#save-form').submit();
 };
 
 /**
@@ -219,8 +219,8 @@
  */
 var get_selected_tags = function(tags_ul) {
     var selected_tags = [];
-    tags_ul.queryAll('li').each(function(li) {
-        if (li.query('input').get('checked')) {
+    tags_ul.all('li').each(function(li) {
+        if (li.one('input').get('checked')) {
             selected_tags.push(li._tag);
         }
     });
@@ -276,7 +276,7 @@
  * @method on_new_tag_add
  */
 var on_new_tag_add = function() {
-    var new_tag = Y.Lang.trim(Y.get('#new-tag-text').get('value'));
+    var new_tag = Y.Lang.trim(Y.one('#new-tag-text').get('value'));
     var new_tag_already_official = false;
     Y.each(official_tags, function(item) {
         new_tag_already_official = (
@@ -305,9 +305,9 @@
             }
             official_tags.push({tag: new_tag, count: 0});
             sort_tags(official_tags);
-            Y.get('#new-tag-text').set('value', '');
-            Y.get('#new-tag-add').set('disabled', true);
-            Y.get('#save-button').set('disabled', false);
+            Y.one('#new-tag-text').set('value', '');
+            Y.one('#new-tag-add').set('disabled', true);
+            Y.one('#save-button').set('disabled', false);
         } else {
             display_error();
         }
@@ -330,7 +330,7 @@
  * @method display_error
  */
 var display_error = function() {
-    var new_tag = Y.get('#new-tag-text').get(
+    var new_tag = Y.one('#new-tag-text').get(
         'value').replace(new RegExp('<', 'g'), '&lt;');
     var overlay = new Y.lazr.PrettyOverlay({
       headerContent: '<span class="official-tag-error-message-header">' +
@@ -356,56 +356,56 @@
     official_tags = get_official_bug_tags(official_bug_tags);
     other_tags = get_other_bug_tags(used_bug_tags);
 
-    var layout_table = Y.get('#layout-table');
+    var layout_table = Y.one('#layout-table');
 
     // The entire dynamic UI is hidden initially, so that clients
     // with no JS don't display it.
     layout_table.setStyle('display', 'block');
 
-    var official_tags_ul = Y.get('#official-tags-list');
-    var other_tags_ul = Y.get('#other-tags-list');
+    var official_tags_ul = Y.one('#official-tags-list');
+    var other_tags_ul = Y.one('#other-tags-list');
 
     render_tag_lists();
 
     // Hook an event handler to the arrow button for moving
     // tags from the list of unofficial tags to the list of official tags.
-    Y.get('#add-official-tags').on('click', function(e) {
+    Y.one('#add-official-tags').on('click', function(e) {
         var updated_tags = get_updated_tags(
             other_tags_ul, other_tags, official_tags);
         other_tags = updated_tags.from_tags;
         official_tags = updated_tags.to_tags;
         render_tag_lists();
         enable_arrows();
-        Y.get('#save-button').set('disabled', false);
+        Y.one('#save-button').set('disabled', false);
     });
 
     // Hook an event handler to the arrow button for moving
     // tags from the list of official tags to the list of unofficial tags.
-    Y.get('#remove-official-tags').on('click', function(e) {
+    Y.one('#remove-official-tags').on('click', function(e) {
         var updated_tags = get_updated_tags(
             official_tags_ul, official_tags, other_tags);
         official_tags = updated_tags.from_tags;
         other_tags = updated_tags.to_tags;
         render_tag_lists();
         enable_arrows();
-        Y.get('#save-button').set('disabled', false);
+        Y.one('#save-button').set('disabled', false);
     });
 
-    Y.get('#new-tag-add').on('click', function(e) {
+    Y.one('#new-tag-add').on('click', function(e) {
         on_new_tag_add();
     });
 
     // Hook a keypress event handler to the new tag text box. If enter is
     // pressed, try adding a new tag.
-    Y.get('#new-tag-text').on('keypress', function(e) {
-        var new_value = Y.Lang.trim(Y.get('#new-tag-text').get('value'));
-        Y.get('#new-tag-add').set('disabled', new_value == '');
+    Y.one('#new-tag-text').on('keypress', function(e) {
+        var new_value = Y.Lang.trim(Y.one('#new-tag-text').get('value'));
+        Y.one('#new-tag-add').set('disabled', new_value == '');
         if (e.keyCode == 13) { // Enter == 13
             on_new_tag_add();
         }
     });
 
-    Y.get('#save-button').on('click', function(e) {
+    Y.one('#save-button').on('click', function(e) {
         e.halt();
         save_tags();
     });
 
=== modified file 'lib/canonical/launchpad/javascript/bugs/subscriber.js'
--- lib/canonical/launchpad/javascript/bugs/subscriber.js	2009-08-03 12:51:30 +0000
+++ lib/canonical/launchpad/javascript/bugs/subscriber.js	2009-11-18 13:45:26 +0000
@@ -75,17 +75,15 @@
      */
     'is_already_subscribed': function() {
         var display_name = this.get('person').get('full_display_name');
-        var subscribers = Y.get('#subscribers-links');
-        var all_subscribers = subscribers.queryAll('div');
         var already_subscribed = false;
-        if (Y.Lang.isValue(all_subscribers)) {
-            all_subscribers.each(function(link) {
-                var name = link.query('a').getAttribute('name');
-                if (name == display_name) {
-                    already_subscribed = true;
-                }
-            });
-        }
+
+        Y.all('#subscribers-links div').each(function(link) {
+            var name = link.one('a').getAttribute('name');
+            if (name == display_name) {
+                already_subscribed = true;
+            }
+        });
+
         return already_subscribed;
     },
 
@@ -310,12 +308,12 @@
         if (Y.Lang.isValue(this.get('user_node'))) {
             user_node = this.get('user_node');
         } else {
-            user_node = Y.get('.subscriber-' + this.get('name'));
+            user_node = Y.one('.subscriber-' + this.get('name'));
         }
 
         if (Y.Lang.isValue(user_node)) {
             this.set('user_node', user_node);
-            var anchor = this.get('user_node').query('a');
+            var anchor = this.get('user_node').one('a');
             var display_name = anchor.get('name');
             return display_name;
         } else {
 
=== modified file 'lib/canonical/launchpad/javascript/bugs/tests/test_me_too.js'
--- lib/canonical/launchpad/javascript/bugs/tests/test_me_too.js	2009-08-04 16:19:27 +0000
+++ lib/canonical/launchpad/javascript/bugs/tests/test_me_too.js	2009-11-18 13:45:26 +0000
@@ -16,7 +16,7 @@
  * CSS selectors and Node instances instead of raw nodes.
  */
 function simulate(widget, selector, evtype, options) {
-    var rawnode = Y.Node.getDOMNode(widget.query(selector));
+    var rawnode = Y.Node.getDOMNode(widget.one(selector));
     Y.Event.simulate(rawnode, evtype, options);
 }
 
@@ -68,8 +68,8 @@
             '    <img src="https://bugs.edge.launchpad.net/@@/flame-icon" alt=""/>',
             '  </span>',
             '</span>'].join(''));
-        Y.get("body").appendChild(inpage);
-        var me_too_content = Y.get('#affectsmetoo');
+        Y.one("body").appendChild(inpage);
+        var me_too_content = Y.one('#affectsmetoo');
         this.config = {
             contentBox: me_too_content, value: null,
             elementToFlash: me_too_content
@@ -82,7 +82,7 @@
         if (this.choice_edit._choice_list) {
             cleanup_widget(this.choice_edit._choice_list);
         }
-        var status = Y.get("document").query("#affectsmetoo");
+        var status = Y.one("document").one("#affectsmetoo");
         if (status) {
             status.get("parentNode").removeChild(status);
         }
@@ -101,7 +101,7 @@
      * The .static area should be hidden by adding the "unseen" class.
      */
     test_hide_static: function() {
-        var static_area = this.choice_edit.get('contentBox').query('.static');
+        var static_area = this.choice_edit.get('contentBox').one('.static');
         Assert.isTrue(
             static_area.hasClass('unseen'), "Static area is not hidden.");
     },
@@ -110,7 +110,7 @@
      * The .dynamic area should be shown by removing the "unseen" class.
      */
     test_hide_dynamic: function() {
-        var dynamic_area = this.choice_edit.get('contentBox').query('.dynamic');
+        var dynamic_area = this.choice_edit.get('contentBox').one('.dynamic');
         Assert.isFalse(
             dynamic_area.hasClass('unseen'), "Dynamic area is hidden.");
     },
 
=== modified file 'lib/canonical/launchpad/javascript/bugs/tests/test_subscriber.js'
--- lib/canonical/launchpad/javascript/bugs/tests/test_subscriber.js	2009-07-24 15:26:14 +0000
+++ lib/canonical/launchpad/javascript/bugs/tests/test_subscriber.js	2009-11-18 13:45:26 +0000
@@ -99,7 +99,7 @@
     name: 'Subscriber Name When Passed Node',
 
     setUp: function() {
-        var node = Y.get('.subscriber-tester');
+        var node = Y.one('.subscriber-tester');
         this.config = {
             uri: '/~tester',
             user_node: node
@@ -212,7 +212,7 @@
         Y.Assert.isFalse(
             this.subscription.is_node(),
             'Initially, no node should be supplied to the config.');
-        var link = Y.get('.menu-link-subscription');
+        var link = Y.one('.menu-link-subscription');
         this.subscription.set('link', link);
         Y.Assert.isTrue(
             this.subscription.is_node(),
 
=== modified file 'lib/canonical/launchpad/javascript/client/client.js'
--- lib/canonical/launchpad/javascript/client/client.js	2009-10-26 14:57:22 +0000
+++ lib/canonical/launchpad/javascript/client/client.js	2009-11-18 13:45:26 +0000
@@ -69,8 +69,8 @@
         result = format(o);
     } else {
         result = '(direct-attributes)\n  ' + introspect(o);
-        if (o.getAtts !== undefined) {
-            result += '\n(get()-attributes)\n  ' + introspect(o.getAtts());
+        if (o.getAttrs !== undefined) {
+            result += '\n(get()-attributes)\n  ' + introspect(o.getAttrs());
         }
     }
     if (name !== undefined) {
@@ -331,15 +331,19 @@
     this.dirty_attributes = [];
     var entry = this;
 
+    // Copy the representation keys into our own set of attributes, and add
+    // an attribute-change event listener for caching purposes.
     for (key in representation) {
         if (representation.hasOwnProperty(key)) {
-            this.addAtt(key, {value: representation[key]});
+            this.addAttr(key, {value: representation[key]});
             this.on(key + "Change", this.mark_as_dirty);
         }
     }
 };
 
 LP.client.Entry.prototype = new LP.client.Resource();
+
+// Augment with Attribute so that we can listen for attribute change events.
 Y.augment(LP.client.Entry, Y.Attribute);
 
 LP.client.Entry.prototype.mark_as_dirty = function(event) {
@@ -669,7 +673,8 @@
     }
 };
 
-Y.extend(PATCHPlugin, Y.Plugin, {
+
+Y.extend(PATCHPlugin, Y.Plugin.Base, {
 
     /**
      * Configuration parameters that will be passed through to the LP.client
@@ -702,7 +707,7 @@
 
         // Save a reference to the original _saveData()
         //method before wrapping it.
-        this.original_save = config.owner._saveData;
+        this.original_save = config.host._saveData;
 
         // We want to run our PATCH code instead of the original
         // 'save' method.  Using doBefore() means that
@@ -713,10 +718,10 @@
         var self = this;
         this.error_handler = new LP.client.ErrorHandler();
         this.error_handler.clearProgressUI = function () {
-            self._owner._uiClearWaiting();
+            config.host._uiClearWaiting();
         };
         this.error_handler.showError = function (error_msg) {
-            self._owner.showError(error_msg);
+            config.host.showError(error_msg);
         };
     },
 
@@ -732,7 +737,7 @@
      * @method doPATCH
      */
     doPATCH: function() {
-        var owner = this._owner,
+        var owner = this.get("host"),
             original_save = this.original_save;
 
         // Set the widget in 'waiting' state.
 
=== modified file 'lib/canonical/launchpad/javascript/code/branchlinks.js'
--- lib/canonical/launchpad/javascript/code/branchlinks.js	2009-08-13 13:16:04 +0000
+++ lib/canonical/launchpad/javascript/code/branchlinks.js	2009-11-18 13:45:26 +0000
@@ -44,7 +44,7 @@
     });
     link_bug_overlay.render();
     link_bug_overlay.loadFormContentAndRender('+linkbug/++form++');
-    var linkbug_handle = Y.get('#linkbug');
+    var linkbug_handle = Y.one('#linkbug');
     linkbug_handle.addClass('js-action');
     linkbug_handle.on('click', function(e) {
         e.preventDefault();
@@ -59,14 +59,11 @@
  * remove the links.
  */
 function connect_remove_links() {
-    var linked_bugs = Y.all('.delete-buglink');
-    if (Y.Lang.isValue(linked_bugs)) {
-        linked_bugs.on('click', function(e) {
-            e.preventDefault();
-            var bugnumber = get_bugnumber_from_id(e.currentTarget.get('id'));
-            unlink_bug_from_branch(bugnumber);
-        });
-    }
+    Y.on('click', function(e) {
+        e.preventDefault();
+        var bugnumber = get_bugnumber_from_id(e.currentTarget.get('id'));
+        unlink_bug_from_branch(bugnumber);
+    }, '.delete-buglink');
 }
 
 /*
@@ -78,7 +75,7 @@
     create_temporary_spinner();
 
     var bugnumber = data['field.bug'];
-    var existing = Y.get('#buglink-' + bugnumber);
+    var existing = Y.one('#buglink-' + bugnumber);
     if (Y.Lang.isValue(existing)) {
         // Bug is already linked, don't do unneccessary requests.
         Y.lazr.anim.green_flash({node: existing}).run();
@@ -124,10 +121,10 @@
         on: {
             success: function(id, response) {
                 destroy_temporary_spinner();
-                Y.get('#linkbug').set(
+                Y.one('#linkbug').set(
                     'innerHTML', 'Link to another bug report');
-                Y.get('#buglink-list').set('innerHTML', response.responseText);
-                var new_buglink = Y.get('#buglink-' + bug.get('id'));
+                Y.one('#buglink-list').set('innerHTML', response.responseText);
+                var new_buglink = Y.one('#buglink-' + bug.get('id'));
                 var anim = Y.lazr.anim.green_flash({node: new_buglink});
                 anim.on('end', connect_remove_links);
                 anim.run();
@@ -150,14 +147,14 @@
 function unlink_bug_from_branch(bugnumber) {
     link_bug_overlay.hide();
 
-    Y.get('#delete-buglink-' + bugnumber).get('children').set(
+    Y.one('#delete-buglink-' + bugnumber).get('children').set(
         'src', '/@@/spinner');
     get_bug_from_bugnumber(bugnumber, function(bug) {
 
         config = {
             on: {
                 success: function(updated_entry) {
-                    var element = Y.get('#buglink-' + bugnumber);
+                    var element = Y.one('#buglink-' + bugnumber);
                     var parent_element = element.get('parentNode');
                     anim = Y.lazr.anim.red_flash({node: element});
                     anim.on('end', function() {
@@ -165,8 +162,8 @@
 
                         // Check to see if that was the only bug linked.
                         var buglinks = Y.all(".bug-branch-summary");
-                        if (!buglinks) {
-                            Y.get('#linkbug').set('innerHTML',
+                        if (buglinks.size() == 0) {
+                            Y.one('#linkbug').set('innerHTML',
                                 'Link to a bug report');
                         }
                     });
@@ -174,7 +171,7 @@
                 },
                 failure: function(id, response) {
                     alert('An unexpected error has occurred.');
-                    Y.get('#delete-buglink-' + bugnumber).get('children').set(
+                    Y.one('#delete-buglink-' + bugnumber).get('children').set(
                         'src', '/@@/remove');
                     Y.log(response.responseText);
                 }
@@ -237,8 +234,8 @@
         '<div id="temp-spinner">',
         '<img src="/@@/spinner"/>Linking...',
         '</div>'].join(''));
-    var buglinks = Y.get('#buglinks');
-    var last = Y.get('#linkbug').get('parentNode');
+    var buglinks = Y.one('#buglinks');
+    var last = Y.one('#linkbug').get('parentNode');
     if (last) {
         buglinks.insertBefore(temp_spinner, last);
     }
@@ -249,7 +246,7 @@
  */
 function destroy_temporary_spinner() {
 
-    var temp_spinner = Y.get('#temp-spinner');
+    var temp_spinner = Y.one('#temp-spinner');
     var spinner_parent = temp_spinner.get('parentNode');
     spinner_parent.removeChild(temp_spinner);
 
 
=== modified file 'lib/canonical/launchpad/javascript/code/branchstatus.js'
--- lib/canonical/launchpad/javascript/code/branchstatus.js	2009-11-10 05:12:59 +0000
+++ lib/canonical/launchpad/javascript/code/branchstatus.js	2009-11-18 13:45:26 +0000
@@ -15,7 +15,7 @@
  */
 Y.branchstatus.connect_status = function(conf) {
 
-    var status_content = Y.get('#branch-details-status-value');
+    var status_content = Y.one('#branch-details-status-value');
 
     if
         (conf.user_can_edit_status) {
@@ -31,9 +31,9 @@
             var cb = status_choice_edit.get('contentBox');
             Y.Array.each(conf.status_widget_items, function(item) {
                 if (item.value == status_choice_edit.get('value')) {
-                    cb.query('span').addClass(item.css_class);
+                    cb.one('span').addClass(item.css_class);
                 } else {
-                    cb.query('span').removeClass(item.css_class);
+                    cb.one('span').removeClass(item.css_class);
                 }
             });
         });
 
=== modified file 'lib/canonical/launchpad/javascript/code/branchsubscription.js'
--- lib/canonical/launchpad/javascript/code/branchsubscription.js	2009-08-13 13:47:24 +0000
+++ lib/canonical/launchpad/javascript/code/branchsubscription.js	2009-11-18 13:45:26 +0000
@@ -38,15 +38,15 @@
     Y.io('+branch-portlet-subscriber-content', {
         on: {
             success: function(id, response) {
-                Y.get('#subscriber-list').set(
+                Y.one('#subscriber-list').set(
                     'innerHTML', response.responseText);
-                Y.get('#subscriber-list').setStyle('display', 'block');
+                Y.one('#subscriber-list').setStyle('display', 'block');
                 if (highlight) {
                     animate_subscription_update();
                 }
             },
             failure: function(id, response) {
-                Y.get('#subscriber-list').set(
+                Y.one('#subscriber-list').set(
                     'innerHTML', 'A problem has occurred.');
                 Y.log(reponse.responseText);
             },
@@ -77,7 +77,7 @@
     subscription_form_overlay.hide();
 
     me = LP.client.links.me;
-    var selfsubscriptioncontainer = Y.get('#selfsubscriptioncontainer');
+    var selfsubscriptioncontainer = Y.one('#selfsubscriptioncontainer');
     selfsubscriptioncontainer.set('innerHTML',
         '<img src="/@@/spinner">Subscribing...');
 
@@ -104,7 +104,7 @@
 
                 // XXX: rockstar: bug=336866 The etag returned by lp_save() is
                 // totally wrong.
-                lp_subscription_entry.removeAtt('http_etag');
+                lp_subscription_entry.removeAttr('http_etag');
 
                 selfsubscriptioncontainer.setStyle('display', 'none');
                 Y.code.branchsubscription.update_subscriber_list(true);
@@ -133,7 +133,7 @@
  */
 function set_up_self_subscription_formoverlay(element_id) {
 
-    var subscribe_yourself = Y.get('#selfsubscription');
+    var subscribe_yourself = Y.one('#selfsubscription');
 
     if (subscribe_yourself !== null) {
 
@@ -158,8 +158,8 @@
         /* XXX: rockstar - bug=389185 - The form is a bit wide for the current
          * form overlay, and there isn't an easy way to resize it, thus this hack.
          */
-        Y.get('#shadow').setStyle('width', '562px');
-        Y.get('div#yui-pretty-overlay-modal.content_box_container').setStyle(
+        Y.one('#shadow').setStyle('width', '562px');
+        Y.one('div#yui-pretty-overlay-modal.content_box_container').setStyle(
         'width', '500px');
         subscribe_yourself.addClass('js-action');
         subscribe_yourself.on('click', function(e) {
@@ -176,7 +176,7 @@
  * Hides the "Edit your subscription" link.
  */
 function hide_edit_your_subscription() {
-    var element = Y.get('#selfsubscription');
+    var element = Y.one('#selfsubscription');
     if (element !== null) {
         if (element.get('innerHTML') == 'Edit your subscription') {
             element.setStyle('display', 'none');
@@ -203,13 +203,13 @@
         '    style="position:absolute;right:8px" /></div>'].join('');
     var link_node = Y.Node.create(html);
 
-    var subscribers = Y.get('#subscriber-list');
-    var next = subscribers.query('div')[0];
+    var subscribers = Y.one('#subscriber-list');
+    var next = subscribers.one('div')[0];
     if (next) {
         subscribers.insertBefore(link_node, next);
     } else {
         // Handle the case of the displayed "None".
-        var none_subscribers = Y.get('#none-subscribers');
+        var none_subscribers = Y.one('#none-subscribers');
         if (none_subscribers) {
             var none_parent = none_subscribers.get('parentNode');
             none_parent.removeChild(none_subscribers);
@@ -261,7 +261,7 @@
 
 
 function animate_subscription_update() {
-    var element = Y.get('#subscriber-' + user_name);
+    var element = Y.one('#subscriber-' + user_name);
     var anim = Y.lazr.anim.green_flash({node: element});
     anim.run();
 }
 
=== modified file 'lib/canonical/launchpad/javascript/code/codereview.js'
--- lib/canonical/launchpad/javascript/code/codereview.js	2009-10-28 16:49:59 +0000
+++ lib/canonical/launchpad/javascript/code/codereview.js	2009-11-18 13:45:26 +0000
@@ -18,7 +18,7 @@
  */
 Y.codereview.connect_links = function() {
 
-    var link = Y.get('#request-review');
+    var link = Y.one('#request-review');
     if (link !== null) {
         link.addClass('js-action');
         link.on('click', show_request_review_form);
@@ -39,7 +39,7 @@
     reviewer_picker = Y.lp.picker.create(
         'ValidPersonOrTeam',
         function(result) {
-            var review_type = Y.get("[id=field.review_type]").get('value');
+            var review_type = Y.one("[id=field.review_type]").get('value');
             request_reviewer(result, review_type);
         },
         config);
@@ -67,7 +67,7 @@
         '<img src="/@@/spinner" />',
         'Requesting review...',
         '</td></tr>'].join(""));
-    var last_element = Y.get('#email-review');
+    var last_element = Y.one('#email-review');
     var reviewer_table = last_element.get('parentNode');
     reviewer_table.insertBefore(table_row, last_element);
 
@@ -110,11 +110,11 @@
     Y.io(VOTES_TABLE_PATH, {
         on: {
             success: function(id, response) {
-                var target = Y.get('#votes-target');
+                var target = Y.one('#votes-target');
                 target.set('innerHTML', response.responseText);
 
                 Y.codereview.connect_links();
-                var new_reviewer = Y.get('#review-' + username);
+                var new_reviewer = Y.one('#review-' + username);
                 var anim = Y.lazr.anim.green_flash({node: new_reviewer});
                 anim.run();
             },
@@ -147,11 +147,11 @@
         var ui = Y.Node.create('<li><label>' +
             '<input type="checkbox" checked="checked" id="show-no"/>' +
             '&nbsp;Show line numbers</label></li>');
-        var ul = Y.get('#review-diff div div ul.horizontal');
+        var ul = Y.one('#review-diff div div ul.horizontal');
         ul.appendChild(ui);
     },
     bindUI: function(){
-        Y.get('#show-no').on('click', update_nos);
+        Y.one('#show-no').on('click', update_nos);
     }
 });
 
 
=== modified file 'lib/canonical/launchpad/javascript/lp/calendar.js'
--- lib/canonical/launchpad/javascript/lp/calendar.js	2009-07-17 00:26:05 +0000
+++ lib/canonical/launchpad/javascript/lp/calendar.js	2009-11-18 13:45:26 +0000
@@ -125,7 +125,7 @@
 
             // Ensure that when the ok button is click, the calendar's
             // selectEvent is fired and the calendar closed.
-            var ok_button = time_selector_node.query('.lazr-btn');
+            var ok_button = time_selector_node.one('.lazr-btn');
             Y.on("click", function(e) {
                 calendar_widget.selectEvent.fire();
                 calendar_widget.hide();
@@ -153,9 +153,9 @@
 
         if (is_datetime_widget) {
             hours = pad_with_zero(
-                time_selector_node.query('.hours').get('value'));
+                time_selector_node.one('.hours').get('value'));
             minutes = pad_with_zero(
-                time_selector_node.query('.minutes').get('value'));
+                time_selector_node.one('.minutes').get('value'));
             value_string += " " + hours + ":" + minutes;
         }
 
 
=== modified file 'lib/canonical/launchpad/javascript/lp/comment.js'
--- lib/canonical/launchpad/javascript/lp/comment.js	2009-10-28 14:56:45 +0000
+++ lib/canonical/launchpad/javascript/lp/comment.js	2009-11-18 13:45:26 +0000
@@ -20,7 +20,7 @@
      */
     initializer: function() {
         this.submit_button = this.get_submit();
-        this.comment_input = Y.get('[id="field.comment"]');
+        this.comment_input = Y.one('[id="field.comment"]');
         this.lp_client = new LP.client.Launchpad();
         this.error_handler = new LP.client.ErrorHandler();
         this.error_handler.clearProgressUI = bind(this.clearProgressUI, this);
@@ -39,7 +39,7 @@
      * @method get_submit
      */
     get_submit: function(){
-        return Y.get('[id="field.actions.save"]');
+        return Y.one('[id="field.actions.save"]');
     },
     /**
      * Implementation of Widget.renderUI.
@@ -131,7 +131,7 @@
      * @param message_html The HTML of the comment to insert.
      */
     insert_comment_HTML: function(message_html) {
-        var fieldset = Y.get('#add-comment-form');
+        var fieldset = Y.one('#add-comment-form');
         var comment = Y.Node.create(message_html);
         fieldset.get('parentNode').insertBefore(comment, fieldset);
         this.reset_contents();
@@ -209,8 +209,8 @@
      * @method initializer
      */
     initializer: function() {
-        this.vote_input = Y.get('[id="field.vote"]');
-        this.review_type = Y.get('[id="field.review_type"]');
+        this.vote_input = Y.one('[id="field.vote"]');
+        this.review_type = Y.one('[id="field.review_type"]');
         this.in_reply_to = null;
     },
     /**
@@ -219,7 +219,7 @@
      * @method get_submit
      */
     get_submit: function(){
-        return Y.get('[id="field.actions.add"]');
+        return Y.one('[id="field.actions.add"]');
     },
     /**
      * Return the vote value selected, or null if none is selected.
@@ -313,7 +313,7 @@
             reply_link.length - '+reply'.length);
         var object_url = '/api/beta' + root_url;
         this.activateProgressUI('Loading...');
-        window.scrollTo(0, Y.get('label [for=field.vote]').getY());
+        window.scrollTo(0, Y.one('label [for=field.vote]').getY());
         this.lp_client.get(object_url, {
             on: {
                 success: bind(function(comment){
@@ -352,7 +352,7 @@
      * @param message_html The HTML of the comment to insert.
      */
     insert_comment_HTML: function(message_html){
-        var conversation = Y.get('[id=conversation]');
+        var conversation = Y.one('[id=conversation]');
         var comment = Y.Node.create(message_html);
         conversation.appendChild(comment);
         this.reset_contents();
@@ -360,7 +360,7 @@
     },
     renderUI: function() {
         CodeReviewComment.superclass.renderUI.apply(this);
-        Y.get('#inline-add-comment').setStyle('display', 'block');
+        Y.one('#inline-add-comment').setStyle('display', 'block');
     },
     /**
      * Implementation of Widget.bindUI: Bind events to methods.
 
=== modified file 'lib/canonical/launchpad/javascript/lp/lp.js'
--- lib/canonical/launchpad/javascript/lp/lp.js	2009-07-24 12:32:28 +0000
+++ lib/canonical/launchpad/javascript/lp/lp.js	2009-11-18 13:45:26 +0000
@@ -61,8 +61,8 @@
      */
     Y.lp.toggle_collapsible = function(collapsible) {
         // Find the collapse icon and wrapper div for this collapsible.
-        var icon = collapsible.query('.collapseIcon');
-        var wrapper_div = collapsible.query('.collapseWrapper');
+        var icon = collapsible.one('.collapseIcon');
+        var wrapper_div = collapsible.one('.collapseWrapper');
 
         // If either the wrapper or the icon is null, raise an error.
         if (wrapper_div === null) {
@@ -102,131 +102,129 @@
      */
     Y.lp.activate_collapsibles = function() {
         // Grab the collapsibles.
-        var collapsibles = Y.all('.collapsible');
-        if (collapsibles !== null) {
-            Y.each(collapsibles, function(collapsible) {
-                var legend = collapsible.query('legend');
-                if (legend === null ||
-                    legend.query('.collapseIcon') !== null) {
-                    // If there's no legend there's not much we can do,
-                    // so just exit this iteration. If there's a
-                    // collapseIcon in there we consider the collapsible
-                    // to already have been set up and therefore ignore
-                    // it this time around.
-                    return;
-                }
-
-                var icon = Y.Node.create(
-                    '<img src="/@@/treeExpanded" class="collapseIcon" />');
-
-                // We use javascript:void(0) here (though it will cause
-                // lint to complain) because it prevents clicking on the
-                // anchor from altering the page URL, which can subtly
-                // break things.
-                var anchor = Y.Node.create(
-                    '<a href="javascript:void(0);"></a>');
-                anchor.appendChild(icon);
-
-                // Move the contents of the legend into the span. We use
-                // the verbose version of <span /> to avoid silly
-                // breakages in Firefox.
-                var span = Y.Node.create('<span></span>');
-                var legend_children = legend.get('children');
-                var len;
-
-                if (Y.Lang.isValue(legend_children)) {
-                    // XXX 2009-07-06 gmb Account for oddness from
-                    // Node.get('children'); (see YUI ticket 2528028 for
-                    // details).
-                    len = legend_children.size ?
-                        legend_children.size() : legend_children.length;
-                } else {
-                    len = 0;
-                }
-
-                if (len > 0) {
-                    // If the legend has child elements, move them
-                    // across one by one.
-                    Y.each(legend_children, function(child_node) {
-                        if (child_node.get('tagName') == 'A') {
-                            // If this child is an anchor, add only its
-                            // contents to the span.
-                            new_node = Y.Node.create(
-                                child_node.get('innerHTML'));
-                            span.appendChild(new_node);
-                            legend.removeChild(child_node);
-                        } else {
-                            // Otherwise, add the node to the span as it
-                            // is.
-                            span.appendChild(child_node);
-                        }
-                    });
-                } else {
-                    // Otherwise just move the innerHTML across as a
-                    // block. Once the span is appended to the anchor,
-                    // this will essentially turn the contents of the
-                    // legend into a link.
-                    span.set('innerHTML', legend.get('innerHTML'));
-                    legend.set('innerHTML', '');
-                }
-
-                // Replace the contents of the legend with the anchor.
-                anchor.appendChild(span);
-                legend.appendChild(anchor);
-
-                // Put a wrapper around the fieldset contents for ease
-                // of hiding.
-                var wrapper_div = Y.Node.create(
-                    '<div class="collapseWrapper" />');
-
-                // Loop over the children of the collapsible and move them
-                // into the wrapper div. We remove the legend from the
-                // collapsible at this point to make sure it gets left
-                // outside the wrapper div; we'll add it again later.
-                collapsible.removeChild(legend);
-
-                // "Why do this as a while?" I hear you cry. Well, it's
-                // because using Y.each() leads to interesting results
-                // in FF3.5, Opera and Chrome, since by doing
-                // appendChild() with each child node (and thus removing
-                // them from the collapsible) means you're altering the
-                // collection as you're looping over it, which is a Bad
-                // Thing. This isn't as pretty but it actually works.
-                var first_child = collapsible.query(':first-child');
-                while (Y.Lang.isValue(first_child)) {
-                    wrapper_div.appendChild(first_child);
-                    first_child = collapsible.query(':first-child');
-                }
-
-                // Put the legend and the new wrapper div into the
-                // collapsible in the right order.
-                collapsible.appendChild(legend);
-                collapsible.appendChild(wrapper_div);
-
-                // If the collapsible is to be collapsed on pageload, do
-                // so.
-                if (collapsible.hasClass('collapsed')) {
-                    // Strip out the 'collapsed' class as it's no longer
-                    // needed.
-                    collapsible.removeClass('collapsed');
-
-                    // We use the slide_in effect to hide the
-                    // collapsible because it sets up all the properties
-                    // and classes for the element properly and saves us
-                    // from embarrasment later on.
-                    var slide_in = Y.lazr.effects.slide_in(wrapper_div);
-                    slide_in.run();
-
-                    icon.set('src', '/@@/treeCollapsed');
-                }
-
-                // Finally, add toggle_collapsible() as an onclick
-                // handler to the anchor.
-                anchor.on('click', function(e) {
-                    Y.lp.toggle_collapsible(collapsible);
+        Y.all('.collapsible').each(function(collapsible) {
+
+            var legend = collapsible.one('legend');
+            if (legend === null ||
+                legend.one('.collapseIcon') !== null) {
+                // If there's no legend there's not much we can do,
+                // so just exit this iteration. If there's a
+                // collapseIcon in there we consider the collapsible
+                // to already have been set up and therefore ignore
+                // it this time around.
+                return;
+            }
+
+            var icon = Y.Node.create(
+                '<img src="/@@/treeExpanded" class="collapseIcon" />');
+
+            // We use javascript:void(0) here (though it will cause
+            // lint to complain) because it prevents clicking on the
+            // anchor from altering the page URL, which can subtly
+            // break things.
+            var anchor = Y.Node.create(
+                '<a href="javascript:void(0);"></a>');
+            anchor.appendChild(icon);
+
+            // Move the contents of the legend into the span. We use
+            // the verbose version of <span /> to avoid silly
+            // breakages in Firefox.
+            var span = Y.Node.create('<span></span>');
+            var legend_children = legend.get('children');
+            var len;
+
+            if (Y.Lang.isValue(legend_children)) {
+                // XXX 2009-07-06 gmb Account for oddness from
+                // Node.get('children'); (see YUI ticket 2528028 for
+                // details).
+                len = legend_children.size ?
+                    legend_children.size() : legend_children.length;
+            } else {
+                len = 0;
+            }
+
+            if (len > 0) {
+                // If the legend has child elements, move them
+                // across one by one.
+                Y.each(legend_children, function(child_node) {
+                    if (child_node.get('tagName') == 'A') {
+                        // If this child is an anchor, add only its
+                        // contents to the span.
+                        new_node = Y.Node.create(
+                            child_node.get('innerHTML'));
+                        span.appendChild(new_node);
+                        legend.removeChild(child_node);
+                    } else {
+                        // Otherwise, add the node to the span as it
+                        // is.
+                        span.appendChild(child_node);
+                    }
                 });
+            } else {
+                // Otherwise just move the innerHTML across as a
+                // block. Once the span is appended to the anchor,
+                // this will essentially turn the contents of the
+                // legend into a link.
+                span.set('innerHTML', legend.get('innerHTML'));
+                legend.set('innerHTML', '');
+            }
+
+            // Replace the contents of the legend with the anchor.
+            anchor.appendChild(span);
+            legend.appendChild(anchor);
+
+            // Put a wrapper around the fieldset contents for ease
+            // of hiding.
+            var wrapper_div = Y.Node.create(
+                '<div class="collapseWrapper" />');
+
+            // Loop over the children of the collapsible and move them
+            // into the wrapper div. We remove the legend from the
+            // collapsible at this point to make sure it gets left
+            // outside the wrapper div; we'll add it again later.
+            collapsible.removeChild(legend);
+
+            // "Why do this as a while?" I hear you cry. Well, it's
+            // because using Y.each() leads to interesting results
+            // in FF3.5, Opera and Chrome, since by doing
+            // appendChild() with each child node (and thus removing
+            // them from the collapsible) means you're altering the
+            // collection as you're looping over it, which is a Bad
+            // Thing. This isn't as pretty but it actually works.
+            var first_child = collapsible.one(':first-child');
+            while (Y.Lang.isValue(first_child)) {
+                wrapper_div.appendChild(first_child);
+                first_child = collapsible.one(':first-child');
+            }
+
+            // Put the legend and the new wrapper div into the
+            // collapsible in the right order.
+            collapsible.appendChild(legend);
+            collapsible.appendChild(wrapper_div);
+
+            // If the collapsible is to be collapsed on pageload, do
+            // so.
+            if (collapsible.hasClass('collapsed')) {
+                // Strip out the 'collapsed' class as it's no longer
+                // needed.
+                collapsible.removeClass('collapsed');
+
+                // We use the slide_in effect to hide the
+                // collapsible because it sets up all the properties
+                // and classes for the element properly and saves us
+                // from embarrasment later on.
+                var slide_in = Y.lazr.effects.slide_in(wrapper_div);
+                slide_in.run();
+
+                icon.set('src', '/@@/treeCollapsed');
+            }
+
+            // Finally, add toggle_collapsible() as an onclick
+            // handler to the anchor.
+            anchor.on('click', function(e) {
+                Y.lp.toggle_collapsible(collapsible);
             });
-        }
+        });
     };
 
 }, '0.1', {requires:['cookie', 'lazr.effects']});
 
=== modified file 'lib/canonical/launchpad/javascript/lp/mapping.js'
--- lib/canonical/launchpad/javascript/lp/mapping.js	2009-10-16 09:25:45 +0000
+++ lib/canonical/launchpad/javascript/lp/mapping.js	2009-11-18 13:45:26 +0000
@@ -102,16 +102,16 @@
      */
     mapping.setLocation = function(lat, lng, geoname,
                                    tz_name, lat_name, lng_name) {
-        Y.get(Y.DOM.byId(lat_name)).set('value', lat);
-        Y.get(Y.DOM.byId(lng_name)).set('value', lng);
-        var spinner = Y.get('#tz_spinner');
+        Y.one(Y.DOM.byId(lat_name)).set('value', lat);
+        Y.one(Y.DOM.byId(lng_name)).set('value', lng);
+        var spinner = Y.one('#tz_spinner');
         spinner.set('src', '/@@/spinner');
 
         function succeeded() {
             if (request.readyState == 4) {
                 if (request.responseText) {
                     var tz = request.responseJSON.timezoneId;
-                    Y.get(Y.DOM.byId(tz_name)).set('value', tz);
+                    Y.one(Y.DOM.byId(tz_name)).set('value', tz);
                     spinner.set('src', '/@@/nospin');
                 }
             }
@@ -164,7 +164,7 @@
         var label = Y.Node.create('<label></label>');
         label.appendChild(checkbox);
         label.appendChild(label_text);
-        var action_div = Y.get(div_id);
+        var action_div = Y.one(div_id);
         action_div.appendChild(label);
         if (!show_small_maps) {
             mapping.toggleShowSmallMaps(checkbox);
 
=== modified file 'lib/canonical/launchpad/javascript/lp/picker.js'
--- lib/canonical/launchpad/javascript/lp/picker.js	2009-09-28 11:51:08 +0000
+++ lib/canonical/launchpad/javascript/lp/picker.js	2009-11-18 13:45:26 +0000
@@ -42,7 +42,7 @@
         }
     }
 
-    var content_box = Y.get('#' + content_box_id);
+    var content_box = Y.one('#' + content_box_id);
 
     var activator = new Y.lazr.activator.Activator(
         {contentBox: content_box});
@@ -56,7 +56,7 @@
     };
 
     var show_hide_buttons = function () {
-        var link = content_box.query('.yui-activator-data-box a');
+        var link = content_box.one('.yui-activator-data-box a');
         if (remove_button) {
             if (link === null || !show_remove_button) {
                 remove_button.addClass('yui-picker-hidden');
@@ -89,7 +89,7 @@
                 if (element.tagName == 'DD') {
                     if (current_field == attribute_name) {
                         // The field value is found
-                        node = Y.get(element).query('span');
+                        node = Y.one(element).one('span');
                     } else if (current_field == 'self_link') {
                         picker._resource_uri = element.innerHTML;
                     }
@@ -230,7 +230,7 @@
 
     picker.subscribe('save', function (e) {
         Y.log('Got save event.');
-        // Y.get() uses CSS3 selectors which don't work with ids containing
+        // Y.one() uses CSS3 selectors which don't work with ids containing
         // a period, so we have to use Y.DOM.byId().
         save(e.details[Y.Picker.SAVE_RESULT]);
     });
 
=== modified file 'lib/canonical/launchpad/javascript/lp/tests/test_lp_collapsibles.js'
--- lib/canonical/launchpad/javascript/lp/tests/test_lp_collapsibles.js	2009-07-08 17:21:50 +0000
+++ lib/canonical/launchpad/javascript/lp/tests/test_lp_collapsibles.js	2009-11-18 13:45:26 +0000
@@ -39,7 +39,7 @@
                 this.default_fieldset_content_node));
 
         // Reset the container to its default contents.
-        this.container = Y.get('#container-of-stuff');
+        this.container = Y.one('#container-of-stuff');
         this.container.set('innerHTML', '');
         this.container.appendChild(
             this.default_fieldset_node.cloneNode(
@@ -51,7 +51,7 @@
         // business of toggling the collapsible open and shut.
         Y.lp.activate_collapsibles();
 
-        var anchor = this.container.query('a');
+        var anchor = this.container.one('a');
         Assert.isNotNull(
             anchor, "activate_collapsibles() should create an anchor");
 
@@ -65,8 +65,8 @@
         // creates.
         Y.lp.activate_collapsibles();
 
-        var anchor = this.container.query('a');
-        var icon = anchor.query('img');
+        var anchor = this.container.one('a');
+        var icon = anchor.one('img');
 
         Assert.isNotNull(
             icon,
@@ -83,8 +83,8 @@
         // activate_collapsibles() adds a span to the anchor it creates.
         Y.lp.activate_collapsibles();
 
-        var anchor = this.container.query('a');
-        var span = anchor.query('span');
+        var anchor = this.container.one('a');
+        var span = anchor.one('span');
 
         Assert.isNotNull(
             span,
@@ -108,22 +108,22 @@
             wrapper_div,
             "activate_collapsibles() should add a wrapper div");
 
-        var collapsible = this.container.query('.collapsible');
+        var collapsible = this.container.one('.collapsible');
         Assert.isNotNull(
-            collapsible.query('.collapseWrapper'),
+            collapsible.one('.collapseWrapper'),
             "The collapseWrapper div should be within the collapsible.");
     },
 
     test_activate_collapsibles_collapses_collapsed: function() {
         // If a collapsible has the class 'collapsed',
         // activate_collapsibles() will pre-collapse it.
-        var collapsible = this.container.query('.collapsible');
+        var collapsible = this.container.one('.collapsible');
         collapsible.addClass('collapsed');
 
         Y.lp.activate_collapsibles();
 
-        var icon = collapsible.query('img');
-        var wrapper_div = collapsible.query('.collapseWrapper');
+        var icon = collapsible.one('img');
+        var wrapper_div = collapsible.one('.collapseWrapper');
         this.wait(function() {
             Assert.isTrue(wrapper_div.hasClass('lazr-closed'));
             Assert.areNotEqual(
@@ -136,9 +136,9 @@
         // won't be pre-collapsed.
         Y.lp.activate_collapsibles();
 
-        var collapsible = this.container.query('.collapsible');
-        var icon = collapsible.query('img');
-        var wrapper_div = collapsible.query('.collapseWrapper');
+        var collapsible = this.container.one('.collapsible');
+        var icon = collapsible.one('img');
+        var wrapper_div = collapsible.one('.collapseWrapper');
         this.wait(function() {
             Assert.isFalse(wrapper_div.hasClass('lazr-closed'));
             Assert.areNotEqual(
@@ -149,7 +149,7 @@
     test_toggle_collapsible_opens_collapsed_collapsible: function() {
         // Calling toggle_collapsible() on a collapsed collapsible will
         // toggle its state to open.
-        var collapsible = this.container.query('.collapsible');
+        var collapsible = this.container.one('.collapsible');
         collapsible.addClass('collapsed');
 
         Y.lp.activate_collapsibles();
@@ -157,8 +157,8 @@
         this.wait(function() {
 
             // The collapsible's wrapper div will now be open.
-            var icon = collapsible.query('img');
-            var wrapper_div = collapsible.query('.collapseWrapper');
+            var icon = collapsible.one('img');
+            var wrapper_div = collapsible.one('.collapseWrapper');
             Assert.isTrue(wrapper_div.hasClass('lazr-open'));
             Assert.areNotEqual(
                 -1, icon.get('src').indexOf('/@@/treeExpanded');
@@ -168,15 +168,15 @@
     test_toggle_collapsible_closes_open_collapsible: function() {
         // Calling toggle_collapsible() on an open collapsible will
         // toggle its state to closed.
-        var collapsible = this.container.query('.collapsible');
+        var collapsible = this.container.one('.collapsible');
 
         Y.lp.activate_collapsibles();
         Y.lp.toggle_collapsible(collapsible);
 
         this.wait(function() {
             // The collapsible's wrapper div will now be closed.
-            var icon = collapsible.query('img');
-            var wrapper_div = collapsible.query('.collapseWrapper');
+            var icon = collapsible.one('img');
+            var wrapper_div = collapsible.one('.collapseWrapper');
             Assert.isTrue(wrapper_div.hasClass('lazr-closed'));
             Assert.areNotEqual(
                 -1, icon.get('src').indexOf('/@@/treeCollapsed'));
@@ -220,13 +220,13 @@
             '    <p>No legend!</p>' +
             '</fieldset>');
 
-        var valid_collapsible = this.container.query('.collapsible');
+        var valid_collapsible = this.container.one('.collapsible');
         this.container.insertBefore(invalid_collapsible, valid_collapsible);
         Y.lp.activate_collapsibles();
 
         // The standard, valid collapsible is still set up correctly.
         Assert.isNotNull(
-            valid_collapsible.query('.collapseWrapper'),
+            valid_collapsible.one('.collapseWrapper'),
             "activate_collapsibles() should have added a wrapper div for " +
             "the valid collapsible.");
     },
@@ -243,9 +243,9 @@
         }
 
         Y.lp.activate_collapsibles();
-        Y.each(Y.all('.collapsible'), function(collapsible) {
+        Y.all('.collapsible').each(function(collapsible) {
             Assert.isNotNull(
-                collapsible.query('.collapseWrapper'),
+                collapsible.one('.collapseWrapper'),
                 "activate_collapsibles() should have added a wrapper div " +
                 "to all collapsibles.");
         });
@@ -279,9 +279,9 @@
         this.container.appendChild(new_collapsible);
         Y.lp.activate_collapsibles();
 
-        var collapsible = this.container.query('.collapsible');
+        var collapsible = this.container.one('.collapsible');
         Assert.isNull(
-            this.container.query('#should-be-removed'),
+            this.container.one('#should-be-removed'),
             "The should-be-removed link should have been removed");
     },
 
@@ -289,24 +289,24 @@
         // If activate_collapsibles() has already been called, calling
         // it again won't break the existing collapsibles.
         Y.lp.activate_collapsibles();
-        var collapsible = this.container.query('.collapsible');
-        var anchor = collapsible.query('a');
-        var span = anchor.query('span');
+        var collapsible = this.container.one('.collapsible');
+        var anchor = collapsible.one('a');
+        var span = anchor.one('span');
         var original_span_contents = span.get('innerHTML');
-        var wrapper = collapsible.query('.collapseWrapper');
+        var wrapper = collapsible.one('.collapseWrapper');
         var original_wrapper_contents = wrapper.get('innerHTML');
 
         // Calling activate_collapsibles() shouldn't break things.
         Y.lp.activate_collapsibles();
-        collapsible = this.container.query('.collapsible');
-        anchor = collapsible.query('a');
-        span = anchor.query('span');
-        wrapper = collapsible.query('.collapseWrapper');
+        collapsible = this.container.one('.collapsible');
+        anchor = collapsible.one('a');
+        span = anchor.one('span');
+        wrapper = collapsible.one('.collapseWrapper');
 
         Assert.isNotNull(
             anchor, "Existing collapsibles' anchors should be intact.");
 
-        var icon = anchor.query('img');
+        var icon = anchor.one('img');
         Assert.isNotNull(
             icon,
             "Existing collapsibles' icons should be intact.");
 
=== modified file 'lib/canonical/launchpad/javascript/registry/milestone_table.js'
--- lib/canonical/launchpad/javascript/registry/milestone_table.js	2009-06-19 20:35:13 +0000
+++ lib/canonical/launchpad/javascript/registry/milestone_table.js	2009-11-18 13:45:26 +0000
@@ -101,7 +101,7 @@
                 "Undefined properties in setup config for milestonetable.");
             }
         self._milestone_row_uri_template = config.milestone_row_uri_template;
-        self._tbody = Y.get(config.milestone_rows_id);
+        self._tbody = Y.one(config.milestone_rows_id);
         if (self._tbody === null) {
             throw new Error(
                 Y.substitute("'{milestone_rows_id}' not in page.", config));
 
=== modified file 'lib/canonical/launchpad/javascript/registry/milestoneoverlay.js'
--- lib/canonical/launchpad/javascript/registry/milestoneoverlay.js	2009-08-13 13:36:02 +0000
+++ lib/canonical/launchpad/javascript/registry/milestoneoverlay.js	2009-11-18 13:45:26 +0000
@@ -32,7 +32,7 @@
             milestone_form.clearError();
             milestone_form.hide();
             // Reset the HTML form inside the widget.
-            milestone_form.get('contentBox').query('form').reset();
+            milestone_form.get('contentBox').one('form').reset();
             next_step(parameters);
         };
 
@@ -42,7 +42,7 @@
             on: {
                 success: finish_new_milestone,
                 failure: function (ignore, response, args) {
-                    var error_box = Y.get('#milestone-error');
+                    var error_box = Y.one('#milestone-error');
                     var error_message = '<strong>' + response.statusText +
                                         '</strong><p>' +
                                         response.responseText +
 
=== modified file 'lib/canonical/launchpad/javascript/registry/tests/test_milestone_table.js'
--- lib/canonical/launchpad/javascript/registry/tests/test_milestone_table.js	2009-06-19 18:31:25 +0000
+++ lib/canonical/launchpad/javascript/registry/tests/test_milestone_table.js	2009-11-18 13:45:26 +0000
@@ -21,7 +21,7 @@
             },
 
         setUp: function() {
-            this.tbody = Y.get('#milestone-rows');
+            this.tbody = Y.one('#milestone-rows');
             },
 
         tearDown: function() {
@@ -71,7 +71,7 @@
         name: '_setup_milestone_event_data',
 
         setUp: function() {
-            this.tbody = Y.get('#milestone-rows');
+            this.tbody = Y.one('#milestone-rows');
             },
 
         tearDown: function() {
@@ -155,7 +155,7 @@
 
         setUp: function() {
             this.data =  milestonetable._setup_milestone_event_data(
-                {name: '0.1'}, Y.get('#milestone-rows'));
+                {name: '0.1'}, Y.one('#milestone-rows'));
             },
 
         tearDown: function() {
@@ -181,7 +181,7 @@
             this.response = {
                 responseText: " <tr><td>" + this.success + "<td></tr> "};
             this.data =  milestonetable._setup_milestone_event_data(
-                {name: '0.1'}, Y.get('#milestone-rows'));
+                {name: '0.1'}, Y.one('#milestone-rows'));
             // Needed to reset the DOM.
             this.table = this.data.tbody.ancestor();
             this.tbody_markup = this.table.get('innerHTML');
 
=== modified file 'lib/canonical/launchpad/javascript/registry/tests/timeline.js'
--- lib/canonical/launchpad/javascript/registry/tests/timeline.js	2009-10-06 22:11:50 +0000
+++ lib/canonical/launchpad/javascript/registry/tests/timeline.js	2009-11-18 13:45:26 +0000
@@ -76,7 +76,7 @@
  */
 function simulate(widget, selector, evtype, options) {
     var bounding_box = widget.get('boundingBox');
-    var rawnode = Y.Node.getDOMNode(bounding_box.query(selector));
+    var rawnode = Y.Node.getDOMNode(bounding_box.one(selector));
     Y.Event.simulate(rawnode, evtype, options);
 }
 
@@ -104,24 +104,24 @@
             "TimelineGraph was not created.");
 
         Assert.isNotNull(
-            this.content_box.query('canvas'),
+            this.content_box.one('canvas'),
             "A canvas should have been created.");
     },
 
     test_zoom_buttons: function() {
-        var zoom_in = this.content_box.query('a.yui-timelinegraph-zoom-in');
+        var zoom_in = this.content_box.one('a.yui-timelinegraph-zoom-in');
         Assert.isNotNull(
             zoom_in,
             'zoom_in link not found.');
 
-        var zoom_out = this.content_box.query('a.yui-timelinegraph-zoom-out');
+        var zoom_out = this.content_box.one('a.yui-timelinegraph-zoom-out');
         Assert.isNotNull(
             zoom_in,
             'zoom_out link not found.');
     },
 
     test_series_label: function() {
-        var label = this.content_box.query('div#trunk');
+        var label = this.content_box.one('div#trunk');
         Assert.isNotNull(
             label,
             "Series label not found.");
@@ -130,7 +130,7 @@
             label.get('title'),
             "Unexpected series label title.");
 
-        var link = label.query('a');
+        var link = label.one('a');
         Assert.isNotNull(
             link,
             "Series label does not contain a link.");
@@ -163,8 +163,8 @@
     },
 
     test_milestone_label_second_line: function() {
-        var label = this.content_box.query('div#ski');
-        var second_line = label.query('div');
+        var label = this.content_box.one('div#ski');
+        var second_line = label.one('div');
         Assert.areEqual(
             '2200-05-26',
             second_line.get('innerHTML'),
@@ -180,7 +180,7 @@
             'This test must be run in an iframe with id=' +
             this.timeline_graph.resize_frame + '.');
 
-        var canvas = this.content_box.query('canvas');
+        var canvas = this.content_box.one('canvas');
         var first_canvas_height = canvas.get('offsetHeight');
         Assert.areEqual(1, this.timeline_graph.graph_scale);
         Assert.areEqual(
@@ -192,7 +192,7 @@
 
         // The canvas is recreated in order to
         // resize correctly in all browsers.
-        canvas = this.content_box.query('canvas');
+        canvas = this.content_box.one('canvas');
         Assert.areEqual(1.1, this.timeline_graph.graph_scale);
         Assert.areEqual(
             canvas.get('offsetHeight'), frame.height,
@@ -204,7 +204,7 @@
         simulate(
             this.timeline_graph, '.yui-timelinegraph-zoom-out', 'click');
 
-        canvas = this.content_box.query('canvas');
+        canvas = this.content_box.one('canvas');
         Assert.areEqual(1, this.timeline_graph.graph_scale);
         Assert.areEqual(
             canvas.get('offsetHeight'), frame.height,
@@ -230,7 +230,7 @@
     },
 
     test_milestone_label: function() {
-        var label = this.content_box.query('div#alpha');
+        var label = this.content_box.one('div#alpha');
         Assert.isNotNull(
             label,
             "Milestone label not found.");
@@ -239,7 +239,7 @@
             label.get('title'),
             "Unexpected milestone label title.");
 
-        var link = label.query('a');
+        var link = label.one('a');
         Assert.isNotNull(
             link,
             "Milestone label does not contain a link.");
@@ -253,7 +253,7 @@
             link.get('href'),
             "Unexpected milestone link href.");
 
-        var second_line = label.query('div');
+        var second_line = label.one('div');
         Assert.isNull(
             second_line,
             "There should be no second line for landmarks when " +
 
=== modified file 'lib/canonical/launchpad/javascript/soyuz/archivesubscribers_index.js'
--- lib/canonical/launchpad/javascript/soyuz/archivesubscribers_index.js	2009-09-29 07:26:40 +0000
+++ lib/canonical/launchpad/javascript/soyuz/archivesubscribers_index.js	2009-11-18 13:45:26 +0000
@@ -18,22 +18,22 @@
 Y.soyuz.setup_archivesubscribers_index = function() {
     // If there are no errors then we hide the add-subscriber row and
     // potentially the whole table if there are no subscribers.
-    if (Y.Lang.isNull(Y.get('p.error.message'))) {
+    if (Y.Lang.isNull(Y.one('p.error.message'))) {
 
         // Hide the add-subscriber row.
-        var add_subscriber_row = Y.get(
+        var add_subscriber_row = Y.one(
             '#archive-subscribers .add-subscriber');
         add_subscriber_row.setStyle('display', 'none');
 
         // If there are no subscribers, then hide the complete section.
-        var subscribers = Y.get('#subscribers');
-        if (Y.Lang.isObject(Y.get('#no-subscribers'))) {
+        var subscribers = Y.one('#subscribers');
+        if (Y.Lang.isObject(Y.one('#no-subscribers'))) {
             subscribers.setStyle('display', 'none');
         }
     }
 
     // Add a link to open the add-subscriber row.
-    var placeholder = Y.get('#add-subscriber-placeholder');
+    var placeholder = Y.one('#add-subscriber-placeholder');
     placeholder.set(
         'innerHTML',
         '<a class="js-action sprite add" href="#">Add access</a>');
 
=== modified file 'lib/canonical/launchpad/javascript/soyuz/lp_dynamic_dom_updater.js'
--- lib/canonical/launchpad/javascript/soyuz/lp_dynamic_dom_updater.js	2009-06-30 21:06:27 +0000
+++ lib/canonical/launchpad/javascript/soyuz/lp_dynamic_dom_updater.js	2009-11-18 13:45:26 +0000
@@ -19,7 +19,7 @@
      * expected format.
      *
      * For example:
-     *     var table = Y.get('table#build-count-table');
+     *     var table = Y.one('table#build-count-table');
      *     var config = {
      *         domUpdateFunction: updateArchiveBuildStatusSummary
      *     }
@@ -93,7 +93,7 @@
      * into a DOM subtree so that it can update itself using an LP api method.
      *
      * For example:
-     *     var table = Y.get('table#build-count-table');
+     *     var table = Y.one('table#build-count-table');
      *     var config = {
      *         domUpdateFunction: updateArchiveBuildStatusSummary,
      *         uri: LP.client.cache.context.self_link,
 
=== modified file 'lib/canonical/launchpad/javascript/soyuz/tests/archivesubscribers_index.js'
--- lib/canonical/launchpad/javascript/soyuz/tests/archivesubscribers_index.js	2009-09-30 06:40:29 +0000
+++ lib/canonical/launchpad/javascript/soyuz/tests/archivesubscribers_index.js	2009-11-18 13:45:26 +0000
@@ -17,12 +17,12 @@
     name: 'add-subscriber',
 
     setUp: function() {
-        this.add_subscriber_placeholder = Y.get(
+        this.add_subscriber_placeholder = Y.one(
             '#add-subscriber-placeholder');
-        this.archive_subscribers_table_body = Y.get(
-            '#archive-subscribers').query('tbody');
-        this.error_div = Y.get('#errors');
-        this.subscribers_div = Y.get('#subscribers');
+        this.archive_subscribers_table_body = Y.one(
+            '#archive-subscribers').one('tbody');
+        this.error_div = Y.one('#errors');
+        this.subscribers_div = Y.one('#subscribers');
 
 
         // Ensure there are no errors displayed.
@@ -48,7 +48,7 @@
                 '</tr>'
                 ].join(''));
 
-        this.add_subscriber_row = Y.get(
+        this.add_subscriber_row = Y.one(
             '#archive-subscribers .add-subscriber');
     },
 
@@ -120,7 +120,7 @@
     test_click_add_access_displays_add_row: function() {
         // The add subscriber row is displayed after clicking 'Add access'.
         Y.soyuz.setup_archivesubscribers_index();
-        var link_node = this.add_subscriber_placeholder.query('a');
+        var link_node = this.add_subscriber_placeholder.one('a');
         Assert.areEqual(
             'Add access', link_node.get('innerHTML'));
 
 
=== modified file 'lib/canonical/launchpad/javascript/soyuz/update_archive_build_statuses.js'
--- lib/canonical/launchpad/javascript/soyuz/update_archive_build_statuses.js	2009-08-28 16:06:56 +0000
+++ lib/canonical/launchpad/javascript/soyuz/update_archive_build_statuses.js	2009-11-18 13:45:26 +0000
@@ -36,16 +36,14 @@
          * @config domUpdateFunction
          */
         domUpdateFunction: function(portlet_node, data_object){
-            var counter_nodelist = portlet_node.queryAll('.build-count');
-
             // For each node of the counter node in the portlet:
-            counter_nodelist.each(function(node){
+            portlet_node.all('.build-count').each(function(node){
                 // Check whether the node has a class matching the data name
                 // of the passed in data, and if so, set the innerHTML to
                 // the corresponding value.
                 Y.each(data_object, function(data_value, data_name){
                     if (node.hasClass(data_name)){
-                        previous_value = node.get("innerHTML");
+                        var previous_value = node.get("innerHTML");
                         node.set("innerHTML", data_value);
                         // If the value changed, just put a quick anim
                         // on the parent row.
@@ -69,7 +67,7 @@
          */
         stopUpdatesCheckFunction: function(portlet_node){
             // Stop updating only when there are zero pending builds:
-            var pending_elem = portlet_node.query(".pending");
+            var pending_elem = portlet_node.one(".pending");
             if (pending_elem === null){
                 return true;
             }
@@ -85,7 +83,7 @@
     Y.on("domready", function(){
         // Grab the Archive build count portlet and tell it how to
         // update itself:
-        var portlet = Y.get('div#build-status-summary');
+        var portlet = Y.one('div#build-status-summary');
         build_summary_portlet_dynamic_update_config.uri =
             LP.client.cache.context.self_link;
         portlet.plug(Y.lp.DynamicDomUpdater,
@@ -114,7 +112,7 @@
             Y.each(data_object, function(build_summary, source_id){
                 // Grab the related td element (and fail silently if it doesn't
                 // exist).
-                var td_elem = Y.get("#pubstatus" + source_id);
+                var td_elem = Y.one("#pubstatus" + source_id);
                 if (td_elem === null) {
                     return;
                 }
@@ -122,7 +120,7 @@
                 // We'll need to remember whether we've change the UI so that
                 // we can add a flash at the end if we do:
                 var td_ui_changed = false;
-                var img_node = td_elem.query('img');
+                var img_node = td_elem.one('img');
 
                 // If the status has changed then we need to update the td
                 // element's class and image:
@@ -145,12 +143,12 @@
                         switch(build_summary.status) {
                         case 'BUILDING':
                             new_src = '/@@/processing';
-                            new_title = 'There are some builds currently ' + 
+                            new_title = 'There are some builds currently ' +
                                         'building.';
                             break;
                         case 'NEEDSBUILD':
                             new_src = '/@@/build-needed';
-                            new_title = 'There are some builds waiting to ' + 
+                            new_title = 'There are some builds waiting to ' +
                                         'be built.';
                             break;
                         case 'FAILEDTOBUILD':
@@ -215,7 +213,7 @@
         },
 
         /**
-         * This function evaluates the parameters required for the 
+         * This function evaluates the parameters required for the
          * getBuildSummariesForSourceIds api function, using the current
          * state of the DOM subtree (ie. It finds the ids of builds in the
          * subtree that are have a class of either NEEDSBUILD or BUILDING.)
@@ -225,14 +223,14 @@
         parameterEvaluatorFunction: function(table_node){
             // Grab all the td's with the class 'build_status' and an additional
             // class of either 'NEEDSBUILD' or 'BUILDING':
-            // Note: filter('.NEEDSBUILD, .BUILDING') returns []
-            var td_list = table_node.queryAll('td.build_status');
+            var td_list = table_node.all('td.build_status');
             var tds_needsbuild = td_list.filter(".NEEDSBUILD");
             var tds_building = td_list.filter(".BUILDING");
             var tds_fullybuilt_pending = td_list.filter(".FULLYBUILT_PENDING");
 
-            if (tds_needsbuild.length === 0 && tds_building.length === 0 &&
-                tds_fullybuilt_pending.length === 0) {
+            if (tds_needsbuild.size() === 0 &&
+                tds_building.size() === 0 &&
+                tds_fullybuilt_pending.size() === 0) {
                 return null;
             }
 
@@ -259,10 +257,10 @@
          */
         stopUpdatesCheckFunction: function(table_node){
             // Stop updating only when there aren't any sources to update:
-            var td_list = table_node.queryAll('td.build_status');
-            return (td_list.filter(".NEEDSBUILD").length === 0 &&
-                    td_list.filter(".BUILDING").length === 0 &&
-                    td_list.filter(".FULLYBUILT_PENDING").length === 0);
+            var td_list = table_node.all('td.build_status');
+            return (td_list.filter(".NEEDSBUILD").size() === 0 &&
+                    td_list.filter(".BUILDING").size() === 0 &&
+                    td_list.filter(".FULLYBUILT_PENDING").size() === 0);
         }
     };
 
@@ -273,7 +271,7 @@
         // Grab the packages table and tell it how to update itself.
         // Note: there are situations, such as displaying empty result
         // sets, when the table will not be on the page.
-        var table = Y.get('table#packages_list');
+        var table = Y.one('table#packages_list');
         if (table !== null) {
            source_package_table_dynamic_update_config.uri =
                 LP.client.cache.context.self_link;
 
=== modified file 'lib/canonical/launchpad/javascript/translations/translations.js'
--- lib/canonical/launchpad/javascript/translations/translations.js	2009-10-01 11:10:51 +0000
+++ lib/canonical/launchpad/javascript/translations/translations.js	2009-11-18 13:45:26 +0000
@@ -103,7 +103,7 @@
     table.insertBefore(output, row.next());
 
     var entry_uri = '+imports/' + entry_id;
-    var div = output.query('div');
+    var div = output.one('div');
     var lp = new LP.client.Launchpad();
     lp.get(entry_uri, output_loader(div));
 };
 
=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
--- lib/lp/app/templates/base-layout-macros.pt	2009-11-10 21:49:38 +0000
+++ lib/lp/app/templates/base-layout-macros.pt	2009-11-18 13:45:26 +0000
@@ -43,7 +43,7 @@
       rooturl modules/canonical.launchpad.webapp.vhosts/allvhosts/configs/mainsite/rooturl;
       icingroot string:${rooturl}+icing/rev${revno};
       devmode modules/canonical.config/config/devmode;
-      yui string:${icingroot}/yui/3.0.0pr2/build;
+      yui string:${icingroot}/yui/current/build;
       lazr_js string:${icingroot}/lazr/build;
       lp_js string:${icingroot}/build"
   >
@@ -53,17 +53,45 @@
   </tal:comment>
 
   <tal:devmode condition="devmode">
-    <script type="text/javascript"
-            tal:attributes="src string:${yui}/yui/yui.js"></script>
+
+    <tal:comment replace="nothing">
+      Instead of loading the yui.js seed we will load three of it's five
+      sub-components.
+
+      We leave out get.js and loader.js, effectively disabling
+      dynamic loading of modules.
+
+      XXX mars 2009-11-03
+      To see what modules are missing you have to change yui-base.js to
+      yui-base-debug.js and move the <script/> node outside of this block.
+
+      This will hopefully be fixed in YUI itself.
+      See http://yuilibrary.com/projects/yui3/ticket/2528368
+    </tal:comment>
+    <script type="text/javascript"
+            tal:attributes="src string:${yui}/yui/yui-base.js"></script>
+    <script type="text/javascript"
+            tal:attributes="src string:${yui}/yui/yui-log.js"></script>
+    <script type="text/javascript"
+            tal:attributes="src string:${yui}/yui/yui-later.js"></script>
+
     <script type="text/javascript"
             tal:attributes="src string:${yui}/oop/oop.js"></script>
     <script type="text/javascript"
             tal:attributes="src string:${yui}/event/event.js"></script>
     <script type="text/javascript"
+            tal:attributes="src string:${yui}/event-custom/event-custom.js"></script>
+    <script type="text/javascript"
+            tal:attributes="src string:${yui}/event-simulate/event-simulate.js"></script>
+    <script type="text/javascript"
             tal:attributes="src string:${yui}/dom/dom.js"></script>
     <script type="text/javascript"
             tal:attributes="src string:${yui}/node/node.js"></script>
     <script type="text/javascript"
+            tal:attributes="src string:${yui}/node-focusmanager/node-focusmanager.js"></script>
+    <script type="text/javascript"
+            tal:attributes="src string:${yui}/node/node-event-simulate.js"></script>
+    <script type="text/javascript"
             tal:attributes="src string:${yui}/dump/dump.js"></script>
     <script type="text/javascript"
             tal:attributes="src string:${yui}/io/io.js"></script>
@@ -82,6 +110,8 @@
     <script type="text/javascript"
             tal:attributes="src string:${yui}/plugin/plugin.js"></script>
     <script type="text/javascript"
+            tal:attributes="src string:${yui}/pluginhost/pluginhost.js"></script>
+    <script type="text/javascript"
             tal:attributes="src string:${yui}/widget/widget.js"></script>
     <script type="text/javascript"
             tal:attributes="src string:${yui}/widget/widget-position-ext.js"></script>
@@ -267,7 +297,7 @@
     revno modules/canonical.launchpad.versioninfo/revno | string:unknown;
     rooturl modules/canonical.launchpad.webapp.vhosts/allvhosts/configs/mainsite/rooturl;
     icingroot string:${rooturl}+icing/rev${revno};
-    yui string:${icingroot}/yui/3.0.0pr2/build;
+    yui string:${icingroot}/yui/current/build;
     devmode modules/canonical.config/config/devmode">
   <tal:comment replace="nothing">
     This macro loads the old stylesheet, then the YUI CSS, and finally
 
=== modified file 'lib/lp/app/templates/base-layout.pt'
--- lib/lp/app/templates/base-layout.pt	2009-09-23 10:17:34 +0000
+++ lib/lp/app/templates/base-layout.pt	2009-11-18 13:45:26 +0000
@@ -24,7 +24,7 @@
   xmlns:i18n="http://xml.zope.org/namespaces/i18n"
   xml:lang="en" lang="en" dir="ltr">
   <head tal:define="
-    yui string:${icingroot}/yui/3.0.0pr2/build;
+    yui string:${icingroot}/yui/current/build;
     lazr_js string:${icingroot}/lazr/build;
     lp_js string:${icingroot}/build">
     <title tal:content="view/fmt:pagetitle">Page Title</title>
 
=== modified file 'lib/lp/bugs/templates/bug-portlet-subscribers.pt'
--- lib/lp/bugs/templates/bug-portlet-subscribers.pt	2009-11-05 14:56:01 +0000
+++ lib/lp/bugs/templates/bug-portlet-subscribers.pt	2009-11-18 13:45:26 +0000
@@ -25,7 +25,7 @@
     YUI().use('io-base', 'node', 'bugs.bugtask_index', function(Y) {
         // Must be done inline here to ensure the load event fires.
         // This is a work around for a YUI3 issue with event handling.
-        var subscription_link = Y.get('.menu-link-subscription');
+        var subscription_link = Y.one('.menu-link-subscription');
         var subscription_link_handler;
         if (subscription_link) {
             subscription_link_handler = subscription_link.on('click', function(e) {
 
=== modified file 'lib/lp/bugs/templates/bugtarget-portlet-bugfilters.pt'
--- lib/lp/bugs/templates/bugtarget-portlet-bugfilters.pt	2009-07-17 17:59:07 +0000
+++ lib/lp/bugs/templates/bugtarget-portlet-bugfilters.pt	2009-11-18 13:45:25 +0000
@@ -14,11 +14,11 @@
     <script type="text/javascript">
     YUI().use('io-base', 'node', function(Y) {
       Y.on('domready', function() {
-        var portlet = Y.get('#portlet-bugfilters');
-        Y.get('#bugfilters-portlet-spinner').setStyle('display', 'block');
+        var portlet = Y.one('#portlet-bugfilters');
+        Y.one('#bugfilters-portlet-spinner').setStyle('display', 'block');
 
         function hide_spinner() {
-          Y.get('#bugfilters-portlet-spinner').setStyle('display', 'none');
+          Y.one('#bugfilters-portlet-spinner').setStyle('display', 'none');
         }
 
         function on_success(transactionid, response, arguments) {
@@ -29,7 +29,7 @@
 
         var config = {on: {success: on_success,
                            failure: hide_spinner}};
-        var url = Y.get('#bugtarget-bugfilters-link').getAttribute('href');
+        var url = Y.one('#bugtarget-bugfilters-link').getAttribute('href');
         var request = Y.io(url, config);
       });
     });
 
=== modified file 'lib/lp/bugs/templates/bugtarget-portlet-bugtags.pt'
--- lib/lp/bugs/templates/bugtarget-portlet-bugtags.pt	2009-09-13 20:39:15 +0000
+++ lib/lp/bugs/templates/bugtarget-portlet-bugtags.pt	2009-11-18 13:45:26 +0000
@@ -11,15 +11,15 @@
   <script type="text/javascript">
     YUI().use('io-base', 'node', function(Y) {
       Y.on('domready', function() {
-        Y.get('#tags-portlet-spinner').setStyle('display', 'block');
+        Y.one('#tags-portlet-spinner').setStyle('display', 'block');
 
         function hide_spinner() {
-          Y.get('#tags-portlet-spinner').setStyle('display', 'none');
+          Y.one('#tags-portlet-spinner').setStyle('display', 'none');
         }
 
         function on_success(transactionid, response, arguments) {
           hide_spinner();
-          var portlet = Y.get('#portlet-tags');
+          var portlet = Y.one('#portlet-tags');
           if (Y.Lang.trim(response.responseText).length == 0) {
             portlet.setStyle('display', 'none')
           }
@@ -31,7 +31,7 @@
 
         var config = {on: {success: on_success,
                            failure: hide_spinner}};
-        var url = Y.get('#tags-content-link').getAttribute('href').replace('bugs.', '');
+        var url = Y.one('#tags-content-link').getAttribute('href').replace('bugs.', '');
         Y.io(url, config);
       });
     });
 
=== modified file 'lib/lp/bugs/templates/bugtask-index.pt'
--- lib/lp/bugs/templates/bugtask-index.pt	2009-10-28 06:08:11 +0000
+++ lib/lp/bugs/templates/bugtask-index.pt	2009-11-18 13:45:26 +0000
@@ -157,7 +157,7 @@
                       // non-JS form, we first disable the link. This is awful and
                       // must be fixed as soon as YUI3 is fixed.
                       if (LP.client.links['me'] !== undefined) {
-                          Y.get('#edit-tags-trigger').on('click', function(e) {
+                          Y.one('#edit-tags-trigger').on('click', function(e) {
                               e.halt();
                           });
                       }
 
=== modified file 'lib/lp/code/templates/branch-import-details.pt'
--- lib/lp/code/templates/branch-import-details.pt	2009-09-15 04:21:59 +0000
+++ lib/lp/code/templates/branch-import-details.pt	2009-11-18 13:45:26 +0000
@@ -33,7 +33,7 @@
               </a>
               <script type="text/javascript">
                   YUI().use('event', 'node', function(Y) {
-                    Y.on("domready", function () { Y.get('#tryagainlink').setStyle('display', 'inline') });
+                    Y.on("domready", function () { Y.one('#tryagainlink').setStyle('display', 'inline') });
                   });
               </script>
             </form>
 
=== modified file 'lib/lp/code/templates/branch-listing.pt'
--- lib/lp/code/templates/branch-listing.pt	2009-10-28 23:40:13 +0000
+++ lib/lp/code/templates/branch-listing.pt	2009-11-18 13:45:26 +0000
@@ -64,7 +64,7 @@
 
         spark_div = branch_sparks[spark_div][0];
 
-        if (Y.get('#' + spark_div) !== null) {
+        if (Y.one('#' + spark_div) !== null) {
             json_url = branch_sparks[0][1];
             var container = spark_div;
             var uri = json_url;
 
=== modified file 'lib/lp/code/templates/branch-portlet-subscribers.pt'
--- lib/lp/code/templates/branch-portlet-subscribers.pt	2009-09-15 03:34:45 +0000
+++ lib/lp/code/templates/branch-portlet-subscribers.pt	2009-11-18 13:45:26 +0000
@@ -44,7 +44,7 @@
     YUI().use('io-base', 'node', 'code.branchsubscription', function(Y) {
 
     if(Y.UA.ie) {
-        Y.get('#subscriber-list').set('innerHTML',
+        Y.one('#subscriber-list').set('innerHTML',
             'Could not load subscribers, javascript is disabled.');
         return;
     }
 
=== modified file 'lib/lp/code/templates/branchmergeproposal-generic-listing.pt'
--- lib/lp/code/templates/branchmergeproposal-generic-listing.pt	2009-09-16 04:29:55 +0000
+++ lib/lp/code/templates/branchmergeproposal-generic-listing.pt	2009-11-18 13:45:26 +0000
@@ -27,10 +27,10 @@
 YUI().use('node', function(Y) {
 
   function submit_filter() {
-    Y.get('#filter_form').submit();
+    Y.one('#filter_form').submit();
   }
   Y.on('domready', function () {
-    var field = Y.get("[id=field.status]");
+    var field = Y.one("[id=field.status]");
     field.on('change', submit_filter);
   });
 
 
=== modified file 'lib/lp/registry/templates/distributionsourcepackage-index.pt'
--- lib/lp/registry/templates/distributionsourcepackage-index.pt	2009-11-07 04:37:23 +0000
+++ lib/lp/registry/templates/distributionsourcepackage-index.pt	2009-11-18 13:45:26 +0000
@@ -271,11 +271,11 @@
     // XXX Michael Nelson 20090702 bug=340497 This slider
     // needs an integration test.
     // Collapse the body of the slider widget initially.
-    Y.get('#related-ppa-versions .widget-bd').addClass('lazr-closed');
+    Y.one('#related-ppa-versions .widget-bd').addClass('lazr-closed');
 
     // Ensure that the widget header uses the correct sprite icon
     // and gets the styling for javascript actions applied.
-    var widget_header = Y.get('#related-ppa-versions .widget-hd');
+    var widget_header = Y.one('#related-ppa-versions .widget-hd');
     widget_header.addClass('sprite');
     widget_header.addClass('treeCollapsed');
     widget_header.addClass('js-action');
 
=== modified file 'lib/lp/registry/templates/object-timeline-graph.pt'
--- lib/lp/registry/templates/object-timeline-graph.pt	2009-09-28 20:48:08 +0000
+++ lib/lp/registry/templates/object-timeline-graph.pt	2009-11-18 13:45:26 +0000
@@ -48,7 +48,7 @@
 
                   // Don't display graph if there are zero milestones or
                   // releases.
-                  var container = Y.get('#timeline-container');
+                  var container = Y.one('#timeline-container');
                   container.setStyle('display', 'block');
                   var config = {
                       timeline: timeline,
@@ -59,7 +59,7 @@
                   }
                   var graph = new Y.registry.timeline.TimelineGraph(config);
                   graph.render();
-                  Y.get('#spinner').setStyle('display', 'none');
+                  Y.one('#spinner').setStyle('display', 'none');
                   // Scroll to the most recent milestones or
                   // releases on the development focus series.
                   graph.scroll_to_last_development_focus_landmark();
 
=== modified file 'lib/lp/registry/templates/person-macros.pt'
--- lib/lp/registry/templates/person-macros.pt	2009-09-18 19:31:04 +0000
+++ lib/lp/registry/templates/person-macros.pt	2009-11-18 13:45:26 +0000
@@ -200,7 +200,7 @@
         // XXX: Brad Crittenden 2009-01-30
         // bug=http://yuilibrary.com/projects/yui3/ticket/2423101
         // Dotted CSS selectors not parsed correctly.  Therefore not
-        // using Y.get().
+        // using Y.one().
         var name = document.getElementById('field.name');
         name.value = prefix + name.value.replace(/^$private_prefix/, '');
 
 
=== modified file 'lib/lp/registry/templates/product-new.pt'
--- lib/lp/registry/templates/product-new.pt	2009-10-01 11:53:27 +0000
+++ lib/lp/registry/templates/product-new.pt	2009-11-18 13:45:26 +0000
@@ -34,11 +34,11 @@
          * XXX BarryWarsaw 12-May-2009
          * http://yuilibrary.com/projects/yui3/ticket/2423101
          * Note that we have to use the more verbose way of getting field.name
-         * because Y.get() doesn't like the dots in the Zope field names.
+         * because Y.one() doesn't like the dots in the Zope field names.
          */
-        var url_field = Y.get(Y.DOM.byId('field.name'));
+        var url_field = Y.one(Y.DOM.byId('field.name'));
         if (url_field) {
-            var name_field = Y.get(Y.DOM.byId('field.displayname'));
+            var name_field = Y.one(Y.DOM.byId('field.displayname'));
             function autofill(e) {
                 var name_value = name_field.get('value');
                 if (name_value == '') {
@@ -110,17 +110,17 @@
         }
 
         /* Handle the reveals when there are search results. */
-        var details_buttons = Y.get('#registration-details-buttons');
-        var form_actions = Y.get('#launchpad-form-actions');
-        var form_widgets = Y.get('#launchpad-form-widgets');
-        var search_results = Y.get('#search-results');
-        var step_title = Y.get('#step-title');
-        var title = Y.get('#registration-details-title');
+        var details_buttons = Y.one('#registration-details-buttons');
+        var form_actions = Y.one('#launchpad-form-actions');
+        var form_widgets = Y.one('#launchpad-form-widgets');
+        var search_results = Y.one('#search-results');
+        var step_title = Y.one('#step-title');
+        var title = Y.one('#registration-details-title');
 
         /* This is the magic hidden widget used by the MultiStepView. */
-        var marker = Y.get(Y.DOM.byId('field.__visited_steps__'));
+        var marker = Y.one(Y.DOM.byId('field.__visited_steps__'));
 
-        var separator = Y.get('#registration-separator');
+        var separator = Y.one('#registration-separator');
         function show_separator(flag) {
             if (!separator) {
                 /* The separator is not on the page, because there were no
@@ -141,14 +141,14 @@
          * to leave the search results there.
          */
         function complete_registration(e) {
-            var expander = Y.get('#search-results-expander');
+            var expander = Y.one('#search-results-expander');
 
             /* Slide in the search results and hide them under a link. */
             expander.removeClass('unseen');
             expander.on('click', function(e) {
                 e.preventDefault();
 
-                var arrow = Y.get('#search-results-arrow');
+                var arrow = Y.one('#search-results-arrow');
                 if (arrow.getAttribute('src') == '/@@/treeCollapsed') {
                     /* The search results are currently hidden.  Slide them
                      * out and turn the arrow to point downward.
 
=== modified file 'lib/lp/registry/templates/productrelease-add-from-series.pt'
--- lib/lp/registry/templates/productrelease-add-from-series.pt	2009-09-03 22:35:47 +0000
+++ lib/lp/registry/templates/productrelease-add-from-series.pt	2009-11-18 13:45:26 +0000
@@ -29,12 +29,12 @@
         // to be escaped.
 
         var get_by_id = function(id) {
-            return Y.get(Y.DOM.byId(id));
+            return Y.one(Y.DOM.byId(id));
         };
 
         var add_milestone_to_menu = function(parameters) {
             var select_menu = get_by_id('field.milestone_for_release');
-            var new_milestone_option = Y.get(
+            var new_milestone_option = Y.one(
                 new Option(parameters.name + '*', parameters.name));
             select_menu.appendChild(new_milestone_option);
             var children = select_menu.get('children');
 
=== modified file 'lib/lp/registry/templates/teammembership-index.pt'
--- lib/lp/registry/templates/teammembership-index.pt	2009-10-08 00:26:50 +0000
+++ lib/lp/registry/templates/teammembership-index.pt	2009-11-18 13:45:26 +0000
@@ -24,9 +24,9 @@
           // Ensure that when the picker is used the radio button switches
           // from 'Never' to 'On' and the expiry field is enabled.
           Y.on("available", function(e) {
-              var choose_link = Y.get("#expiration-widget a.js-action");
-              var radio_on = Y.get("#date");
-              var expiration_date = Y.get(
+              var choose_link = Y.one("#expiration-widget a.js-action");
+              var radio_on = Y.one("#date");
+              var expiration_date = Y.one(
                   document.getElementById('membership.expirationdate'));
               choose_link.on('click', function(e) {
                 expiration_date.set('disabled', false);
 
=== modified file 'lib/lp/registry/templates/timeline-macros.pt'
--- lib/lp/registry/templates/timeline-macros.pt	2009-10-02 17:20:49 +0000
+++ lib/lp/registry/templates/timeline-macros.pt	2009-11-18 13:45:26 +0000
@@ -39,9 +39,9 @@
           if (Y.UA.ie) {
               return;
           }
-          var loading_el = Y.get('#timeline-loading');
+          var loading_el = Y.one('#timeline-loading');
           loading_el.setStyle('display', 'block');
-          var iframe = Y.get('#timeline-iframe');
+          var iframe = Y.one('#timeline-iframe');
           iframe.set('src', timeline_url);
           Y.on('load', function(e) {
               loading_el.setStyle('display', 'none');
 
=== modified file 'lib/lp/soyuz/templates/archive-edit-dependencies.pt'
--- lib/lp/soyuz/templates/archive-edit-dependencies.pt	2009-10-16 13:20:48 +0000
+++ lib/lp/soyuz/templates/archive-edit-dependencies.pt	2009-11-18 13:45:26 +0000
@@ -69,7 +69,7 @@
        // contained by the label.
        function highlight_checked (nodes) {
            nodes.each(function(input) {
-               var label = Y.get(input.get("parentNode"));
+               var label = Y.one(input.get("parentNode"));
                if (input.get("checked")) {
                    label.setStyle("fontWeight", "bold");
                }
@@ -79,45 +79,38 @@
            });
        };
 
-       var main_area = Y.get("#mainarea");
+       var main_area = Y.one("#mainarea");
 
        // Highlight the selected radio button input on page load.
-       var inputs = main_area.queryAll("input.highlight-selected");
+       var inputs = main_area.all("input.highlight-selected");
        highlight_checked(inputs);
 
        // Install signal handlers for all radio-button inputs to
        // recalculate with options should be highlighted when one of
        // them is clicked.
-       inputs.each(function(input) {
-           input.on("click", function(e) {
-               var main_area = Y.get("#mainarea");
-               var inputs = main_area.queryAll("input.highlight-selected");
-               highlight_checked(inputs);
-           });
-       });
+       inputs.on("click", function(e) {
+           highlight_checked(inputs);
+       }, this);
 
        // Install handlers to decorate selected check-box inputs when
        // they get clicked. Selected options text (next sibling) will
        // be decorated with 'line-through' style and rendered in
        // 'red'. Options not selected (or unselected) text will be
        // rendered in 'blue' and without any decoration.
-       var inputs = main_area.queryAll("input.line-through-when-checked");
-       if (inputs) {
-           inputs.each(function(input) {
-               input.on("click", function(e) {
-                   var input = e.currentTarget;
-                   var link = input.next();
-                   if (input.get("checked")) {
-                       link.setStyle("color", "red");
-                       link.setStyle("textDecoration", "line-through");
-                   }
-                   else {
-                       link.setStyle("color", "blue");
-                       link.setStyle("textDecoration", "none");
-                   }
-               });
+       main_area.all(
+           "input.line-through-when-checked").on('click', function(e) {
+               var input = e.currentTarget;
+               var link = input.next();
+               if (input.get("checked")) {
+                   link.setStyle("color", "red");
+                   link.setStyle("textDecoration", "line-through");
+               }
+               else {
+                   link.setStyle("color", "blue");
+                   link.setStyle("textDecoration", "none");
+               }
            });
-       };
+       });
    });
 </script>
 
 
=== modified file 'lib/lp/soyuz/templates/archive-index.pt'
--- lib/lp/soyuz/templates/archive-index.pt	2009-09-22 04:06:47 +0000
+++ lib/lp/soyuz/templates/archive-index.pt	2009-11-18 13:45:26 +0000
@@ -148,11 +148,11 @@
     }).use('node', 'event', 'lazr.effects', function(Y) {
 
     // Hide the widget body contents.
-    Y.get('#ppa-install .widget-body').addClass('lazr-closed');
+    Y.one('#ppa-install .widget-body').addClass('lazr-closed');
 
     // Ensure that the widget header uses the correct sprite icon
     // and gets the styling for javascript actions applied.
-    var widget_header = Y.get('#ppa-install .widget-header');
+    var widget_header = Y.one('#ppa-install .widget-header');
     widget_header.addClass('sprite');
     widget_header.addClass('treeCollapsed');
     widget_header.addClass('js-action');
 
=== modified file 'lib/lp/soyuz/templates/archive-macros.pt'
--- lib/lp/soyuz/templates/archive-macros.pt	2009-10-16 11:47:55 +0000
+++ lib/lp/soyuz/templates/archive-macros.pt	2009-11-18 13:45:26 +0000
@@ -88,14 +88,14 @@
  * the expander itself.
  */
 function toggleExpandableRow(expander) {
-    var row = Y.get('#' + expander.get('id').replace('-expander', ''));
-    var icon = expander.query('img');
+    var row = Y.one('#' + expander.get('id').replace('-expander', ''));
+    var icon = expander.one('img');
 
     var row_display = row.getStyle('display');
     if (row_display == 'none') {
         row.setStyle('display', 'table-row');
         icon.set('src', '/@@/treeExpanded');
-        var container = Y.get('#' + row.get('id') + '-container');
+        var container = Y.one('#' + row.get('id') + '-container');
         if (trim(container.get('innerHTML')) == ''){
             startUpdate(container);
         }
 
=== modified file 'lib/lp/soyuz/templates/archive-packages.pt'
--- lib/lp/soyuz/templates/archive-packages.pt	2009-09-18 21:00:18 +0000
+++ lib/lp/soyuz/templates/archive-packages.pt	2009-11-18 13:45:26 +0000
@@ -65,7 +65,7 @@
     in_progress_message = Y.soyuz.makeInProgressNode(
         'Fetching repository size ...')
 
-    var container = Y.get('#package-counters');
+    var container = Y.one('#package-counters');
     container.set('innerHTML', '');
     container.appendChild(in_progress_message);
 
 
=== modified file 'lib/lp/soyuz/windmill/tests/test_archivesubscribersindex.py'
--- lib/lp/soyuz/windmill/tests/test_archivesubscribersindex.py	2009-09-29 12:09:39 +0000
+++ lib/lp/soyuz/windmill/tests/test_archivesubscribersindex.py	2009-11-18 13:45:26 +0000
@@ -15,13 +15,11 @@
 
 from canonical.launchpad.ftests import login, logout
 from canonical.launchpad.windmill.testing.lpuser import LaunchpadUser
+from canonical.launchpad.windmill.testing import constants
 from lp.registry.interfaces.distribution import IDistributionSet
 from lp.soyuz.windmill.testing import SoyuzWindmillLayer
 from lp.testing import TestCaseWithFactory
 
-WAIT_PAGELOAD = u'30000'
-WAIT_ELEMENT_COMPLETE = u'30000'
-WAIT_CHECK_CHANGE = u'1000'
 ADD_ACCESS_LINK = u'//a[@class="js-action sprite add"]'
 CHOOSE_SUBSCRIBER_LINK = u'//a[@id="show-widget-field-subscriber"]'
 SUBSCRIBER_SEARCH_FIELD = (
@@ -30,6 +28,7 @@
 FIRST_SUBSCRIBER_RESULT = (
     u'//div[@id="yui-pretty-overlay-modal"]'
      '//span[@class="yui-picker-result-title"]')
+MESSAGE_WINDOW = u'//div[@class="informational message"]'
 
 
 class TestArchiveSubscribersIndex(TestCaseWithFactory):
@@ -59,15 +58,16 @@
     def test_add_subscriber(self):
         """Test adding a private PPA subscriber.."""
         client = WindmillTestClient('Adding private PPA subscribers.')
-        
+
         self.lpuser.ensure_login(client)
 
         client.open(url='http://launchpad.dev:8085/~joe-bloggs/'
                         '+archive/myppa/+subscriptions')
-        client.waits.forPageLoad(timeout=WAIT_PAGELOAD)
+        client.waits.forPageLoad(timeout=constants.PAGE_LOAD)
 
         # Click on the JS add access action.
-        client.waits.forElement(xpath=ADD_ACCESS_LINK)
+        client.waits.forElement(
+            xpath=ADD_ACCESS_LINK, timeout=constants.FOR_ELEMENT)
         client.click(xpath=ADD_ACCESS_LINK)
 
         # Open the picker, search for 'launchpad' and choose the first
@@ -76,15 +76,18 @@
         client.type(xpath=SUBSCRIBER_SEARCH_FIELD, text='launchpad')
         client.click(xpath=SUBSCRIBER_SEARCH_BUTTON)
 
-        client.waits.forElement(xpath=FIRST_SUBSCRIBER_RESULT)
+        client.waits.forElement(
+            xpath=FIRST_SUBSCRIBER_RESULT, timeout=constants.FOR_ELEMENT)
         client.click(xpath=FIRST_SUBSCRIBER_RESULT)
 
         # Add the new subscriber.
         client.click(id='field.actions.add')
-        client.waits.forPageLoad(timeout=WAIT_PAGELOAD)
+        client.waits.forPageLoad(timeout=constants.PAGE_LOAD)
 
         # And verify that the correct informational message is displayed.
         # It would be nice if we could use ... here.
+        client.waits.forElement(
+            xpath=MESSAGE_WINDOW, timeout=constants.FOR_ELEMENT)
         client.asserts.assertText(
             xpath=u'//div[@class="informational message"]',
             validator='You have granted access for Launchpad Developers '
 
=== modified file 'lib/lp/translations/templates/object-templates.pt'
--- lib/lp/translations/templates/object-templates.pt	2009-10-22 11:49:30 +0000
+++ lib/lp/translations/templates/object-templates.pt	2009-11-18 13:45:26 +0000
@@ -35,19 +35,17 @@
         }
       </style>
       <script language="JavaScript" type="text/javascript">
-      YUI().use('node', function(Y) {
+      YUI().use('node-base', 'event-delegate', function(Y) {
           Y.on('domready', function(e) {
-              Y.all('.template_links').addClass('inactive_links');
-              var template_rows = Y.all('.template_row');
-              template_rows.each(function(row) {
-                  var template_links = row.query('.template_links');
-                  row.on('mouseover', function(e) {
-                      template_links.removeClass('inactive_links');
-                  });
-                  row.on('mouseout', function(e) {
-                      template_links.addClass('inactive_links');
-                  });
-              });
+              Y.all('#template_table .template_links').addClass('inactive_links');
+
+              Y.delegate('mouseover', function(e) {
+                  this.removeClass('inactive_links');
+              }, '#template_table tbody', '.template_links');
+
+              Y.delegate('mouseout', function(e) {
+                  this.addClass('inactive_links');
+              }, '#template_table tbody', '.template_links');
           });
       });
       </script>
 
=== modified file 'lib/lp/translations/templates/pofile-export.pt'
--- lib/lp/translations/templates/pofile-export.pt	2009-11-06 01:16:21 +0000
+++ lib/lp/translations/templates/pofile-export.pt	2009-11-18 13:45:26 +0000
@@ -16,9 +16,9 @@
     YUI().use('node', 'event', function(Y){
         Y.on('domready', function(){
             // The pochanged option is only available for the PO format.
-            var formatlist = Y.get('#div_format select');
-            var checkbox = Y.get('#div_pochanged input');
-            var changedtext = Y.get('#div_pochanged span');
+            var formatlist = Y.one('#div_format select');
+            var checkbox = Y.one('#div_pochanged input');
+            var changedtext = Y.one('#div_pochanged span');
             function toggle_pochanged() {
                 if (formatlist.get('value') == 'PO') {
                     changedtext.removeClass('disabledpochanged');
 
=== modified file 'lib/lp/translations/templates/pofile-translate.pt'
--- lib/lp/translations/templates/pofile-translate.pt	2009-09-14 16:19:15 +0000
+++ lib/lp/translations/templates/pofile-translate.pt	2009-11-18 13:45:26 +0000
@@ -38,8 +38,8 @@
           }
 
           var updateNotificationBox = function(e) {
-              var notice = Y.get('.important-notice-container');
-              var balloon = notice.query('.important-notice-balloon');
+              var notice = Y.one('.important-notice-container');
+              var balloon = notice.one('.important-notice-balloon');
               var dismiss_notice_cookie = ('translation-docs-for-' +
                                            documentation_cookie);
 
@@ -50,7 +50,7 @@
                  notice.setStyle('display', 'none');
               }
 
-              var cancel_button = notice.query(
+              var cancel_button = notice.one(
                   '.important-notice-cancel-button');
               // Cancel button starts out hidden.  If user has JavaScript,
               // then we want to show it.
 
=== modified file 'lib/lp/translations/templates/translationimportqueueentry-index.pt'
--- lib/lp/translations/templates/translationimportqueueentry-index.pt	2009-09-01 12:09:27 +0000
+++ lib/lp/translations/templates/translationimportqueueentry-index.pt	2009-11-18 13:45:26 +0000
@@ -29,7 +29,7 @@
         function getElemById(elem_id) {
             // XXX 'elem_id' is a Zope form field, and triggers
             // YUI bug #2423101.  We'll work around it.
-            return Y.get(Y.DOM.byId(elem_id));
+            return Y.one(Y.DOM.byId(elem_id));
         }
 
         function getEnclosingTR(fieldname) {
 
=== modified file 'setup.py'
--- setup.py	2009-10-31 12:07:16 +0000
+++ setup.py	2009-11-18 13:45:26 +0000
@@ -27,6 +27,7 @@
         'bzr',
         'chameleon.core',
         'chameleon.zpt',
+        'cssutils',
         'feedvalidator',
         'funkload',
         'launchpadlib',
@@ -37,6 +38,7 @@
         'lazr.lifecycle',
         'lazr.restful',
         'lazr.smtptest',
+        'lazr.testing',
         'lazr.uri',
         'lazr-js',
         'mechanize',
 
=== modified file 'versions.cfg'
--- versions.cfg	2009-11-17 20:34:27 +0000
+++ versions.cfg	2009-11-18 13:45:26 +0000
@@ -11,6 +11,7 @@
 chameleon.core = 1.0b35
 chameleon.zpt = 1.0b17
 ClientForm = 0.2.10
+cssutils = 0.9.6
 # Required by Windmill to run on 2.4
 ctypes = 1.0.2
 docutils = 0.5
@@ -32,8 +33,9 @@
 lazr.restful = 0.9.17
 lazr.restfulclient = 0.9.10
 lazr.smtptest = 1.1
+lazr.testing = 0.1.1
 lazr.uri = 1.0.2
-lazr-js = 0.9.1
+lazr-js = 0.9dev-r153
 martian = 0.11
 mechanize = 0.1.11
 mocker = 0.10.1