Code review comment for lp:~marmyshev/openlp/presentation
Revision history for this message
| matysek (mzibricky) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Guys, should i do here something else for merging it?
From my point of view:
- Are you able to reproduce the issue 'The presentation /file/name is incomplete, please reload.'?
- if yes - are you able to fix it?
- if not - I will have to look at it what' wrong
- the disappearing dialog is not directly related to your code - it should be fixed but not in this pull request
Other than that I'm fine with merging it.