Merge lp:~marmyshev/openlp/bag_1225763 into lp:openlp

Proposed by Dmitriy Marmyshev
Status: Merged
Merged at revision: 2360
Proposed branch: lp:~marmyshev/openlp/bag_1225763
Merge into: lp:openlp
Diff against target: 34 lines (+4/-2)
2 files modified
.bzrignore (+1/-0)
openlp/core/ui/media/mediacontroller.py (+3/-2)
To merge this branch: bzr merge lp:~marmyshev/openlp/bag_1225763
Reviewer Review Type Date Requested Status
Raoul Snyman Needs Fixing
Review via email: mp+186243@code.launchpad.net

Description of the change

fixed: replacing background with video unblank screen even if it blanked to theme.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

You need at least one (not necessarily related) test please.

review: Needs Fixing
Revision history for this message
Dmitriy Marmyshev (marmyshev) wrote :

Yes, I know. but it is hard for me to start to write tests... :(
But I'll do it!

Revision history for this message
Samuel Mehrbrodt (sam92) wrote :

I wrote the test and created a new merge proposal: https://code.launchpad.net/~sam92/openlp/bag_1225763/+merge/214771

You can then delete this one.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2013-09-14 02:42:12 +0000
3+++ .bzrignore 2013-09-18 05:24:10 +0000
4@@ -2,6 +2,7 @@
5 *.*~
6 \#*\#
7 *.eric4project
8+*.eric5project
9 *.ropeproject
10 *.e4*
11 .eric4project
12
13=== modified file 'openlp/core/ui/media/mediacontroller.py'
14--- openlp/core/ui/media/mediacontroller.py 2013-08-31 18:17:38 +0000
15+++ openlp/core/ui/media/mediacontroller.py 2013-09-18 05:24:10 +0000
16@@ -527,7 +527,8 @@
17 else:
18 self.media_volume(controller, controller.media_info.volume)
19 if status:
20- display.frame.evaluateJavaScript('show_blank("desktop");')
21+ if not controller.media_info.is_background:
22+ display.frame.evaluateJavaScript('show_blank("desktop");')
23 self.current_media_players[controller.controller_type].set_visible(display, True)
24 # Flash needs to be played and will not AutoPlay
25 if controller.media_info.is_flash:
26@@ -538,7 +539,7 @@
27 controller.mediabar.actions['playbackPause'].setVisible(True)
28 controller.mediabar.actions['playbackStop'].setVisible(True)
29 if controller.is_live:
30- if controller.hide_menu.defaultAction().isChecked():
31+ if controller.hide_menu.defaultAction().isChecked() and not controller.media_info.is_background:
32 controller.hide_menu.defaultAction().trigger()
33 # Start Timer for ui updates
34 if not self.timer.isActive():