Code review comment for lp:~markthomas/serverguide/serverguide-review-7.5

Revision history for this message
Peter Matulis (petermatulis) wrote :

A wonderful contribution! Thank you Mark. A few comments below.

1. wording

(a)
"This section covers the use of sssd to authenticate user logins against an Active Directory via sssd and PAM using sssd's "ad" provider."

Maybe:

"This section describes the use of sssd and PAM for authenticating users against Microsoft Active Directory."

(b)
"This guide assumes that a working Active Directory domain already configured."

Maybe:

"This guide assumes that a working Active Directory domain is already configured.

(c)
"The domain and kerberos realm used in this example is myubuntu.example.com ."

Maybe the realm should be in all caps. You mention both domain and realm so not sure.

(d)
"Add an alias /etc/hosts specifying the FQDN."

Maybe:

"Add an entry to /etc/hosts for specifying the FQDN."

(e)
"kerberos" should be capitalized everywhere: Kerberos.

2. format

(a) All commands should be formatted like so:

<screen>
<command>command_goes_here</command>
</screen>

(b) All filenames should be formatted like so:

<filename>file_goes_here</filename>

(c) References should be hyperlinks. See end of this page as an exemplar:

https://help.ubuntu.com/14.04/serverguide/openldap-server.html

Long ugly URLs should also not be exposed to the reader.

review: Needs Fixing

« Back to merge proposal