Merge lp:~markodolar/screenshot-tool/screenshot-tool into lp:~elementary-apps/screenshot-tool/trunk

[MarkoD]

Listen to structure events

Screenshot Tool didn't receive updates when other windows were resized. This branch adds event mask to all windows so that program receives size (and some other) updates.

More details - if i understood gdk source correctly:
When querying windows first time Window objects are created and Gdk stores them internally. After that they didn't receive any geometry updates. And when you use window get_width() or get_height() you get old values from that internal Gdk list, not directly from X.

[Zisu Andrei (matzipan)]

I confirm this branch fixes the issue, and cannot find any obvious regressions.

There's a comment inline.

review: Needs Fixing

[Adam Bieńkowski (donadigo)]

Please use lower cases for variables:
instead of "wantedMask" do "wanted_mask", I would also change it for something like "final_mask".

[MarkoD (markodolar)]

You are right Andrei, i could probably just set events directly. I was just
trying to be on safe side and set only once for each window because i do
not know the cost of set_events method. Will fix it.

Adam thanks for comment, but looks like i won't be needing variables at all
after fix. :) But i know now for next time..

On Sat, 12 Nov 2016 at 23:59 Adam Bieńkowski <email address hidden> wrote:

> Please use lower cases for variables:
> instead of "wantedMask" do "wanted_mask", I would also change it for
> something like "final_mask".
> --
>
> https://code.launchpad.net/~markodolar/screenshot-tool/screenshot-tool/+merge/310711
> You are the owner of lp:~markodolar/screenshot-tool/screenshot-tool.
>

[lp:~markodolar/screenshot-tool/screenshot-tool]

249. By MarkoD on 2016-11-12

Set events directly without checking if they are already set.

[Zisu Andrei (matzipan)]

review: Approve (code and functionality)

=== modified file 'src/ScreenshotWindow.vala'
--- src/ScreenshotWindow.vala	2016-10-06 20:27:33 +0000
+++ src/ScreenshotWindow.vala	2016-11-12 23:23:06 +0000
@@ -400,6 +400,9 @@
                     if (screen.get_active_window () == item) {
                         win = item;
                     }
+
+                    // Recieve updates of other windows when they are resized
+                    item.set_events (item.get_events () | Gdk.EventMask.STRUCTURE_MASK);
                 }
 
                 this.present ();