Merge lp:~markodolar/pantheon-calculator/pantheon-calculator into lp:~elementary-apps/pantheon-calculator/trunk

Proposed by Adam Bieńkowski
Status: Merged
Approved by: Danielle Foré
Approved revision: no longer in the source branch.
Merged at revision: 290
Proposed branch: lp:~markodolar/pantheon-calculator/pantheon-calculator
Merge into: lp:~elementary-apps/pantheon-calculator/trunk
Diff against target: 21 lines (+4/-0)
1 file modified
src/MainWindow.vala (+4/-0)
To merge this branch: bzr merge lp:~markodolar/pantheon-calculator/pantheon-calculator
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Review via email: mp+309802@code.launchpad.net

Commit message

* Set basic grid alignment to FILL
* Vertically center and expand the entry

Description of the change

Aligns main and extended grid.

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Looks good, thanks for your branch!

review: Approve
290. By MarkoD

* Set basic grid alignment to FILL
* Vertically center and expand the entry

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/MainWindow.vala'
--- src/MainWindow.vala 2016-09-17 23:37:45 +0000
+++ src/MainWindow.vala 2016-11-01 21:44:26 +0000
@@ -121,6 +121,8 @@
121 entry.set_alignment (1);121 entry.set_alignment (1);
122 entry.set_text (settings.get_string ("entry-content"));122 entry.set_text (settings.get_string ("entry-content"));
123 entry.get_style_context ().add_class ("h2");123 entry.get_style_context ().add_class ("h2");
124 entry.vexpand = true;
125 entry.valign = Gtk.Align.CENTER;
124126
125 button_calc = new Button ("=", _("Calculate Result"));127 button_calc = new Button ("=", _("Calculate Result"));
126 button_calc.get_style_context ().add_class ("h2");128 button_calc.get_style_context ().add_class ("h2");
@@ -162,6 +164,8 @@
162 var basic_grid = new Gtk.Grid ();164 var basic_grid = new Gtk.Grid ();
163 basic_grid.column_spacing = 6;165 basic_grid.column_spacing = 6;
164 basic_grid.row_spacing = 6;166 basic_grid.row_spacing = 6;
167 basic_grid.valign = Gtk.Align.FILL;
168
165 basic_grid.attach (entry, 0, 0, 4, 1);169 basic_grid.attach (entry, 0, 0, 4, 1);
166 basic_grid.attach (button_del, 0, 1, 1, 1);170 basic_grid.attach (button_del, 0, 1, 1, 1);
167 basic_grid.attach (button_undo, 1, 1, 1, 1);171 basic_grid.attach (button_undo, 1, 1, 1, 1);

Subscribers

People subscribed via source and target branches

to all changes: