Code review comment for lp:~markjtully/zeitgeist-datasources/thunderbird

Revision history for this message
Mark Tully (markjtully) wrote :

It appears to me from testing that libzeitgeist will need to be changed to accommodate event.origin. I can add several subjects to an event easily enough, however.

So, as far as I can see, there are 3 options:

1: Commit what's here at the moment and patch the extension if libzeitgeist is changed. The Firefox dataprovider (at least) will also presumably need to be patched to work with changes in libzeitgeist.

2: Wait until libzeitgeist is changed, then commit the Thunderbird dataprovider with support for event.origin

3: Change the Thunderbird dataprovider to use 2 subjects, one defining the email and one defining the mailbox the email arrives to and then patch the extension if event.origin support arrives later.

« Back to merge proposal