Code review comment for lp:~markjtully/zeitgeist-datasources/thunderbird

Revision history for this message
Seif Lotfy (seif) wrote :

@RainCT or we can use it as the mailbox as the event.origin

@Teester we have a slot called event.origin (its not in the API)
in module.js<http://bazaar.launchpad.net/~markjtully/zeitgeist-datasources/thunderbird/revision/157/thunderbird/extension/chrome/content/module.js>
change
zeitgeist_event_new_full to send an extra argument origin right after
"actor"
I am not sure libzeitgeist supports this change yet I will bug one of the
devs about it. https://bugs.launchpad.net/libzeitgeist/+bug/879852

@mhr3 can u have a look please

On Sat, Oct 22, 2011 at 12:46 PM, Siegfried Gevatter <email address hidden>wrote:

> 2011/10/22 Teester <email address hidden>:
> > Just to make sure I understand:
> > Using the terminology from
> http://zeitgeist-project.com/docs/0.7/datamodel.html#event, the Actor
> parameter should be the inbox address rather than
> application://thunderbird.desktop, in order to tie the event to the email
> account rather than to Thunderbird?
>
> No, the actor is the application related to the event.
>
> I think I'd add the account to which the message was send as a second
> subject with subject_manifestation=MAILBOX.
>
> --
>
> https://code.launchpad.net/~markjtully/zeitgeist-datasources/thunderbird/+merge/79506
> Your team Zeitgeist Data-Sources Team is requested to review the proposed
> merge of lp:~markjtully/zeitgeist-datasources/thunderbird into
> lp:zeitgeist-datasources.
>

« Back to merge proposal