Merge lp:~markjtully/unity-lens-music/genres into lp:unity-lens-music

Proposed by Mark Tully
Status: Merged
Approved by: Michal Hruby
Approved revision: 78
Merged at revision: 79
Proposed branch: lp:~markjtully/unity-lens-music/genres
Merge into: lp:unity-lens-music
Diff against target: 67 lines (+16/-0)
1 file modified
src/genre.vala (+16/-0)
To merge this branch: bzr merge lp:~markjtully/unity-lens-music/genres
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+101414@code.launchpad.net

Commit message

Added more genres to the genre map

Description of the change

This change adds extra genres to the genre map. It does not change any of the UI (ie. doesn't add any new genre filters) The new genre map looks like:

blues --> blues
classic --> classic, classical, opera (new)
country --> country
disco --> disco
funk --> funk
rock --> rock, heavy, hard, rock and roll (new)
metal --> metal, heavy, heavy metal
hip hop --> hip-hop, rap (new), rap & hip-hop (new)
house --> house, chillout, minimal, hard, electronic, dance (new)
new wave --> new-wave
r-and-b --> r-and-b, r&b (new)
punk --> punk, punk rock, hardcore, heavy
jazz --> jazz
pop --> pop
reggae --> reggae
soul --> soul, gospel
techno --> techno, minimal, trance, chillout, electronic, electronica, dance (new)
other --> other, african, alternative, ambient, asian, brazilian, celtic (new), christmas (new), folk (new), latin (new), oldies (new), soundtrack (new), traditional (new), world (new)

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Thanks Mark, it's looking good and since it just adds extra genre mapping I don't think tests are needed.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/genre.vala'
--- src/genre.vala 2012-03-19 13:06:29 +0000
+++ src/genre.vala 2012-04-10 16:49:49 +0000
@@ -55,6 +55,7 @@
55 /* classic */55 /* classic */
56 map.set (CLASSIC_ID, "classic");56 map.set (CLASSIC_ID, "classic");
57 map.set (CLASSIC_ID, "classical");57 map.set (CLASSIC_ID, "classical");
58 map.set (CLASSIC_ID, "opera");
5859
59 /* country */60 /* country */
60 map.set (COUNTRY_ID, "country");61 map.set (COUNTRY_ID, "country");
@@ -69,13 +70,17 @@
69 map.set (ROCK_ID, "rock");70 map.set (ROCK_ID, "rock");
70 map.set (ROCK_ID, "heavy");71 map.set (ROCK_ID, "heavy");
71 map.set (ROCK_ID, "hard");72 map.set (ROCK_ID, "hard");
73 map.set (ROCK_ID, "rock and roll");
7274
73 /* metal */75 /* metal */
74 map.set (METAL_ID, "metal");76 map.set (METAL_ID, "metal");
75 map.set (METAL_ID, "heavy");77 map.set (METAL_ID, "heavy");
78 map.set (METAL_ID, "heavy metal");
7679
77 /*hip hop */80 /*hip hop */
78 map.set (HIPHOP_ID, "hip-hop");81 map.set (HIPHOP_ID, "hip-hop");
82 map.set (HIPHOP_ID, "rap");
83 map.set (HIPHOP_ID, "rap & hip hop");
7984
80 /*house*/85 /*house*/
81 map.set (HOUSE_ID, "house");86 map.set (HOUSE_ID, "house");
@@ -83,12 +88,14 @@
83 map.set (HOUSE_ID, "minimal");88 map.set (HOUSE_ID, "minimal");
84 map.set (HOUSE_ID, "hard");89 map.set (HOUSE_ID, "hard");
85 map.set (HOUSE_ID, "electronic");90 map.set (HOUSE_ID, "electronic");
91 map.set (HOUSE_ID, "dance");
8692
87 /*new wave*/93 /*new wave*/
88 map.set (NEWWAVE_ID, "new-wave");94 map.set (NEWWAVE_ID, "new-wave");
8995
90 /*r-and-b*/96 /*r-and-b*/
91 map.set (RANDB_ID, "r-and-b");97 map.set (RANDB_ID, "r-and-b");
98 map.set (RANDB_ID, "r&b");
9299
93 /*punk*/100 /*punk*/
94 map.set (PUNK_ID, "punk");101 map.set (PUNK_ID, "punk");
@@ -116,6 +123,7 @@
116 map.set (TECHNO_ID, "chillout");123 map.set (TECHNO_ID, "chillout");
117 map.set (TECHNO_ID, "electronic");124 map.set (TECHNO_ID, "electronic");
118 map.set (TECHNO_ID, "electronica");125 map.set (TECHNO_ID, "electronica");
126 map.set (TECHNO_ID, "dance");
119127
120 /*other*/128 /*other*/
121 map.set (OTHER_ID, "other");129 map.set (OTHER_ID, "other");
@@ -124,6 +132,14 @@
124 map.set (OTHER_ID, "ambient");132 map.set (OTHER_ID, "ambient");
125 map.set (OTHER_ID, "asian");133 map.set (OTHER_ID, "asian");
126 map.set (OTHER_ID, "brazilian");134 map.set (OTHER_ID, "brazilian");
135 map.set (OTHER_ID, "celtic");
136 map.set (OTHER_ID, "christmas");
137 map.set (OTHER_ID, "folk");
138 map.set (OTHER_ID, "latin");
139 map.set (OTHER_ID, "oldies");
140 map.set (OTHER_ID, "soundtrack");
141 map.set (OTHER_ID, "traditional");
142 map.set (OTHER_ID, "world");
127143
128 inverted_map = new HashMap<string, string> ();144 inverted_map = new HashMap<string, string> ();
129 foreach (var key in map.get_keys ())145 foreach (var key in map.get_keys ())

Subscribers

People subscribed via source and target branches

to all changes: