OpenStack Dashboard (Horizon)

Merge lp:~markgius/horizon/lp788388 into lp:~hudson-openstack/horizon/trunk

  1. lp788388
  2. Merge into trunk
Proposed by Mark Gius
Status: Merged
Approved by: Devin Carlen
Approved revision: 54
Merged at revision: 55
Proposed branch: lp:~markgius/horizon/lp788388
Merge into: lp:~hudson-openstack/horizon/trunk
Diff against target: 18 lines (+6/-0)
1 file modified
run_tests.sh (+6/-0)
To merge this branch: bzr merge lp:~markgius/horizon/lp788388
Reviewer Review Type Date Requested Status
Devin Carlen Approve
Review via email: mp+62544@code.launchpad.net

Description of the change

Fix run_tests.sh to return non-zero exit status when test cases fail. run_tests.sh currently only returns the exit status of the openstack-dashboard tests, ignoring the exit status of the django-openstack tests.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'run_tests.sh'
2--- run_tests.sh 2011-05-16 21:51:09 +0000
3+++ run_tests.sh 2011-05-26 19:16:40 +0000
4@@ -5,8 +5,14 @@
5 bin/buildout
6 bin/test
7
8+OPENSTACK_RESULT=$?
9+
10 cd ../openstack-dashboard
11 python tools/install_venv.py
12
13 cp local/local_settings.py.example local/local_settings.py
14 tools/with_venv.sh dashboard/manage.py test
15+
16+DASHBOARD_RESULT=$?
17+
18+exit $(($OPENSTACK_RESULT || $DASHBOARD_RESULT))

Subscribers

People subscribed via source and target branches