OpenStack Dashboard (Horizon)

Merge lp:~markgius/horizon/lp727414 into lp:~hudson-openstack/horizon/trunk

  1. lp727414
  2. Merge into trunk
Proposed by Mark Gius
Status: Merged
Approved by: Devin Carlen
Approved revision: 51
Merged at revision: 51
Proposed branch: lp:~markgius/horizon/lp727414
Merge into: lp:~hudson-openstack/horizon/trunk
Prerequisite: lp:~markgius/horizon/lp787222
Diff against target: 22 lines (+3/-2)
1 file modified
openstack-dashboard/tools/install_venv.py (+3/-2)
To merge this branch: bzr merge lp:~markgius/horizon/lp727414
Reviewer Review Type Date Requested Status
Devin Carlen Approve
Review via email: mp+62050@code.launchpad.net

Description of the change

Makes existing messages for check_dependencies more clear. output for later steps already clear.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openstack-dashboard/tools/install_venv.py'
2--- openstack-dashboard/tools/install_venv.py 2011-05-23 22:55:52 +0000
3+++ openstack-dashboard/tools/install_venv.py 2011-05-23 22:55:52 +0000
4@@ -64,6 +64,7 @@
5 def check_dependencies():
6 """Make sure virtualenv is in the path."""
7
8+ print 'checking dependencies...'
9 if not HAS_VIRTUALENV:
10 print 'not found.'
11 # Try installing it via easy_install...
12@@ -73,8 +74,8 @@
13 die('ERROR: virtualenv not found.\n\nevelopment requires'
14 ' virtualenv, please install it using your favorite'
15 ' package management tool')
16- print 'done.'
17- print 'done.'
18+ print 'virtualenv installation done.'
19+ print 'dependency check done.'
20
21
22 def create_virtualenv(venv=VENV):

Subscribers

People subscribed via source and target branches