Code review comment for lp:~mariosplivalo/juju-deployer/juju-deployer

thanks.

On Fri, May 30, 2014 at 10:12 AM, Mario Splivalo <
<email address hidden>> wrote:

> > The original option is semantically confusing, if you pass --local-mods
> it
> > should means: enable local modifications and it should be True by
> default,
> > also the destination variable should be called dest="local_mods" for
> > reflecting this.
> >
> > Mario, Does that makes sense for you? If does, please modify the code
> > accordingly.
>
> Actually, the code is ok, just the help text is missleading. The default
> is for the deployer not to allow local charm modifications. If you,
> however, add --local-mods option, it will allow local charm modifications.
> Therefore, the help text should read like this:
>
> -L, --local-mods Allow deployment of locally-modified charms
>
>
> I've pushed the changes and created merge request.
> --
>
> https://code.launchpad.net/~mariosplivalo/juju-deployer/juju-deployer/+merge/221457
> Your team juju-deployers is subscribed to branch lp:juju-deployer.
>