Hello Mario,
Aside from the following lint errors:
tests/03_deploy_replicaset.py:39:1: E302 expected 2 blank lines, found 1 tests/03_deploy_replicaset.py:50:20: F821 undefined name 'sentry_dict' tests/03_deploy_replicaset.py:51:18: F821 undefined name 'sentry_dict' tests/03_deploy_replicaset.py:82:1: E265 block comment should start with '# ' tests/03_deploy_replicaset.py:83:1: E265 block comment should start with '# ' tests/03_deploy_replicaset.py:84:1: E265 block comment should start with '# ' hooks/hooks.py:17:1: F401 'operator' imported but unused hooks/hooks.py:33:1: F401 'fatal' imported but unused hooks/hooks.py:49:1: F401 'local_unit' imported but unused hooks/hooks.py:96:33: E113 unexpected indentation make: *** [lint] Error 1
I made a few observations regarding to the code, I hope you can drive those in order to keep reviewing this proposal.
thanks.
« Back to merge proposal
Hello Mario,
Aside from the following lint errors:
tests/03_ deploy_ replicaset. py:39:1: E302 expected 2 blank lines, found 1 deploy_ replicaset. py:50:20: F821 undefined name 'sentry_dict' deploy_ replicaset. py:51:18: F821 undefined name 'sentry_dict' deploy_ replicaset. py:82:1: E265 block comment should start with '# ' deploy_ replicaset. py:83:1: E265 block comment should start with '# ' deploy_ replicaset. py:84:1: E265 block comment should start with '# ' py:17:1: F401 'operator' imported but unused py:33:1: F401 'fatal' imported but unused py:49:1: F401 'local_unit' imported but unused py:96:33: E113 unexpected indentation
tests/03_
tests/03_
tests/03_
tests/03_
tests/03_
hooks/hooks.
hooks/hooks.
hooks/hooks.
hooks/hooks.
make: *** [lint] Error 1
I made a few observations regarding to the code, I hope you can drive those in order to keep reviewing this proposal.
thanks.