Code review comment for lp:~mariosplivalo/charms/trusty/mongodb/replsets-fix-try

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Hello Mario,

Aside from the following lint errors:

tests/03_deploy_replicaset.py:39:1: E302 expected 2 blank lines, found 1
tests/03_deploy_replicaset.py:50:20: F821 undefined name 'sentry_dict'
tests/03_deploy_replicaset.py:51:18: F821 undefined name 'sentry_dict'
tests/03_deploy_replicaset.py:82:1: E265 block comment should start with '# '
tests/03_deploy_replicaset.py:83:1: E265 block comment should start with '# '
tests/03_deploy_replicaset.py:84:1: E265 block comment should start with '# '
hooks/hooks.py:17:1: F401 'operator' imported but unused
hooks/hooks.py:33:1: F401 'fatal' imported but unused
hooks/hooks.py:49:1: F401 'local_unit' imported but unused
hooks/hooks.py:96:33: E113 unexpected indentation
make: *** [lint] Error 1

I made a few observations regarding to the code, I hope you can drive those in order to keep reviewing this proposal.

thanks.

review: Needs Fixing

« Back to merge proposal