Juju Charms Collection
mongodb package

Code review comment for lp:~mariosplivalo/charms/trusty/mongodb/replsets-fix-try

  1. Trusty Tahr (14.04)
  2. replsets-fix-try
  3. Merge into trunk
Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Hello Mario,

Thanks for contributing to this charm. Next are my observations regarding to this first iteration on the review:

1) Lint has failures.

tests/03_deploy_replicaset.py:34:1: E302 expected 2 blank lines, found 1
tests/03_deploy_replicaset.py:45:20: F821 undefined name 'sentry_dict'
tests/03_deploy_replicaset.py:46:18: F821 undefined name 'sentry_dict'
tests/03_deploy_replicaset.py:77:1: E265 block comment should start with '# '
tests/03_deploy_replicaset.py:78:1: E265 block comment should start with '# '
tests/03_deploy_replicaset.py:79:1: E265 block comment should start with '# '
make: *** [lint] Error 1

2) Please change the makefile to just cover the hooks package.

 test: .venv
        @echo Starting unit tests...
- .venv/bin/nosetests -s --nologcapture --with-coverage $(EXTRA) unit_tests/
+ .venv/bin/nosetests -s --nologcapture --with-coverage $(EXTRA) --cover-package hooks unit_tests/

3) Please review the inline comments.

review: Needs Fixing

« Back to merge proposal