Code review comment for lp:~mardy/webbrowser-app/per-account-dir2

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

> Scratch the above comment, I hadn’t noticed that WebContext was resolving to
> UbuntuWebContext.qml.
>
> However this change will break the browser, because it means we instantiate
> several contexts with the same datapath (which is the reason why the shared
> context is a singleton in the first place).

We should really enforce this clearly in Oxide (currently, instantiating more than one WebContext with the same data path will result in obscure aborts like bug 1278315, but we could do an explicit abort with a more helpful error message)

« Back to merge proposal