Code review comment for lp:~mardy/webbrowser-app/per-account-dir2

Revision history for this message
Alberto Mardegan (mardy) wrote :

> 118 - asynchronous: true
>
> Why did you remove this attribute from the Loader?

I'm not sure; this was in the branch by Alex, on which I based my work. Let's ask him later.

> In webapp-container.qml:
> console.log("Cookies were not moved")
> you might want to use console.warn(…) instead.

It can be that cookies are not moved because the OA cookies are older then those in the webapp; actually, this is what will happen most of the times. So, the cookies not being moved is not really an error condition.

All your other suggestions have now been implemented.

« Back to merge proposal