Code review comment for lp:~mardy/webbrowser-app/per-account-dir2

Revision history for this message
Olivier Tilloy (osomon) wrote :

463 + if (successful && credentialsId) {

Isn’t 'credentialsId' guaranteed to be non-null if 'successful' is true? Or are you checking that it’s ≠ 0 as well? If not, I would say that the 'successful' parameter is redundant.

« Back to merge proposal