Merge lp:~mardy/webbrowser-app/lp1441873 into lp:webbrowser-app

Proposed by Alberto Mardegan
Status: Merged
Approved by: David Barth
Approved revision: 991
Merged at revision: 1074
Proposed branch: lp:~mardy/webbrowser-app/lp1441873
Merge into: lp:webbrowser-app
Prerequisite: lp:~mardy/webbrowser-app/refactoring
Diff against target: 110 lines (+70/-0)
3 files modified
src/app/webcontainer/AccountErrorScreen.qml (+54/-0)
src/app/webcontainer/AccountsLogic.qml (+2/-0)
src/app/webcontainer/AccountsPage.qml (+14/-0)
To merge this branch: bzr merge lp:~mardy/webbrowser-app/lp1441873
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+258991@code.launchpad.net

Commit message

Show an error screen if the trust session could not be opened.

Description of the change

Show an error screen if the trust session could not be opened.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
lp:~mardy/webbrowser-app/lp1441873 updated
986. By Alberto Mardegan

merge refactoring
[ CI Train Bot ]
* Resync trunk.
[ Leo Arias ]
* Fix the base class used when launching the app in autopilot tests.
[ Leonardo Arias Fonseca ]
* Fix the base class used when launching the app in autopilot tests.
[ Olivier Tilloy ]
* Also set XDG_CONFIG_HOME (needed for tests not to override user-
  defined settings).
* Update translation template.
* Use the new Oxide APIs to better control visibility of the chrome.
  This bumps the runtime dependency on liboxideqt-qmlplugin to 1.7.
  (LP: #1441064, #1453908)
[ Riccardo Padovani ]
* Add support for data: URIs in the address bar, and remove length
  limitation for TLDs. (LP: #1377953, #1441281, #1450154)
* Add support for data: URIs in the address bar, and remove length
  limitation for TLDs. (LP: #1377953, #1441281, #1450154)
[ Ugo Riboni ]
* Add suggestions from search engines in the suggestions list. (LP:
  #1351151)

987. By Alberto Mardegan

merge refactoring

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~mardy/webbrowser-app/lp1441873 updated
988. By Alberto Mardegan

Store the initialized accounts as a JSON array

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~mardy/webbrowser-app/lp1441873 updated
989. By Alberto Mardegan

Properly propagate the session cookie mode.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
lp:~mardy/webbrowser-app/lp1441873 updated
990. By Alberto Mardegan

Properly initialize variable

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
lp:~mardy/webbrowser-app/lp1441873 updated
991. By Alberto Mardegan

Update error message

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'src/app/webcontainer/AccountErrorScreen.qml'
--- src/app/webcontainer/AccountErrorScreen.qml 1970-01-01 00:00:00 +0000
+++ src/app/webcontainer/AccountErrorScreen.qml 2015-06-23 12:37:15 +0000
@@ -0,0 +1,54 @@
1/*
2 * Copyright 2015 Canonical Ltd.
3 *
4 * This file is part of webbrowser-app.
5 *
6 * webbrowser-app is free software; you can redistribute it and/or modify
7 * it under the terms of the GNU General Public License as published by
8 * the Free Software Foundation; version 3.
9 *
10 * webbrowser-app is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License
16 * along with this program. If not, see <http://www.gnu.org/licenses/>.
17 */
18
19import QtQuick 2.0
20import Ubuntu.Components 1.1
21
22Rectangle {
23 id: root
24
25 property alias message: messageLabel.text
26 signal closed()
27
28 anchors.fill: parent
29
30 Column {
31 anchors.fill: parent
32 anchors.margins: units.gu(4)
33
34 spacing: units.gu(3)
35
36 Label {
37 width: parent.width
38 fontSize: "x-large"
39 text: i18n.tr("Account error")
40 }
41
42 Label {
43 id: messageLabel
44 width: parent.width
45 wrapMode: Text.Wrap
46 }
47
48 Button {
49 anchors.horizontalCenter: parent.horizontalCenter
50 text: i18n.tr("Close")
51 onClicked: root.closed()
52 }
53 }
54}
055
=== modified file 'src/app/webcontainer/AccountsLogic.qml'
--- src/app/webcontainer/AccountsLogic.qml 2015-06-23 12:37:14 +0000
+++ src/app/webcontainer/AccountsLogic.qml 2015-06-23 12:37:15 +0000
@@ -59,6 +59,8 @@
59 onFinished: {59 onFinished: {
60 if ("accountId" in reply) {60 if ("accountId" in reply) {
61 root.checkAccounts()61 root.checkAccounts()
62 } else if ("errorName" in reply) {
63 root.errorScreenRequested(i18n.tr("Account window could not be opened. You can only create one account at a time; please try again after closing all other account windows."))
62 } else {64 } else {
63 root.quitRequested()65 root.quitRequested()
64 }66 }
6567
=== modified file 'src/app/webcontainer/AccountsPage.qml'
--- src/app/webcontainer/AccountsPage.qml 2015-06-23 12:37:14 +0000
+++ src/app/webcontainer/AccountsPage.qml 2015-06-23 12:37:15 +0000
@@ -46,6 +46,7 @@
46 onAccountSelected: root.__emitAccountSelected(credentialsId, willMoveCookies)46 onAccountSelected: root.__emitAccountSelected(credentialsId, willMoveCookies)
47 onContextReady: root.contextReady()47 onContextReady: root.contextReady()
48 onQuitRequested: root.quitRequested()48 onQuitRequested: root.quitRequested()
49 onErrorScreenRequested: showErrorScreen(message)
49 }50 }
5051
51 AccountsSplashScreen {52 AccountsSplashScreen {
@@ -61,6 +62,14 @@
61 onSkip: accountsLogic.proceedWithNoAccount()62 onSkip: accountsLogic.proceedWithNoAccount()
62 }63 }
6364
65 // Only temporarily used for bug https://bugs.launchpad.net/bugs/1441873
66 AccountErrorScreen {
67 id: errorScreen
68
69 visible: false
70 onClosed: root.quitRequested()
71 }
72
64 Loader {73 Loader {
65 id: accountChooserLoader74 id: accountChooserLoader
66 anchors.fill: parent75 anchors.fill: parent
@@ -104,6 +113,11 @@
104 __setupProviderData()113 __setupProviderData()
105 }114 }
106115
116 function showErrorScreen(message) {
117 errorScreen.message = message
118 errorScreen.visible = true
119 }
120
107 function showSplashScreen() {121 function showSplashScreen() {
108 splashScreen.visible = true122 splashScreen.visible = true
109 }123 }

Subscribers

People subscribed via source and target branches

to status/vote changes: