Code review comment for lp:~mardy/webbrowser-app/add-onlineaccount-support-for-container2

Revision history for this message
Olivier Tilloy (osomon) wrote :

1108 + WebkitCookieStore {
1109 + id: webkitCookieStore
1110 + dbPath: dataLocation + "/.QtWebKit/cookies.db"
1111 + }
1112 +
1113 + ChromeCookieStore {
1114 + id: chromeCookieStore
1115 + dbPath: dataLocation + "/cookies.sqlite"
1116 + }

The two implementations of CookieStore are instantiated at all times, even though only one (or possibly none) of them is used. Can only one of them be instantiated dynamically in loadLoginView() instead?

« Back to merge proposal