Merge lp:~mardy/ubuntuone-credentials/token-valid-1572943 into lp:ubuntuone-credentials
Proposed by
Alberto Mardegan
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | dobey | ||||
Approved revision: | 239 | ||||
Merged at revision: | 238 | ||||
Proposed branch: | lp:~mardy/ubuntuone-credentials/token-valid-1572943 | ||||
Merge into: | lp:ubuntuone-credentials | ||||
Prerequisite: | lp:~mardy/ubuntuone-credentials/library-symbols | ||||
Diff against target: |
69 lines (+22/-10) 3 files modified
libubuntuoneauth/tests/test_token.cpp (+7/-0) libubuntuoneauth/tests/test_token.h (+1/-0) libubuntuoneauth/token.cpp (+14/-10) |
||||
To merge this branch: | bzr merge lp:~mardy/ubuntuone-credentials/token-valid-1572943 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
dobey (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+293059@code.launchpad.net |
Commit message
Make Token::isValid() return false on tokens created out of empty strings.
Description of the change
Make Token::isValid() return false on tokens created out of empty strings.
To post a comment you must log in.
PASSED: Continuous integration, rev:239 jenkins. qa.ubuntu. com/job/ ubuntuone- credentials- ci/151/ jenkins. qa.ubuntu. com/job/ ubuntuone- credentials- wily-amd64- ci/28 jenkins. qa.ubuntu. com/job/ ubuntuone- credentials- wily-armhf- ci/28 jenkins. qa.ubuntu. com/job/ ubuntuone- credentials- wily-armhf- ci/28/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ ubuntuone- credentials- wily-i386- ci/28
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntuone- credentials- ci/151/ rebuild
http://