Merge lp:~mardy/ubuntu-system-settings-online-accounts/empty-page-1594944 into lp:ubuntu-system-settings-online-accounts
Status: | Merged |
---|---|
Approved by: | Alberto Mardegan |
Approved revision: | 372 |
Merged at revision: | 391 |
Proposed branch: | lp:~mardy/ubuntu-system-settings-online-accounts/empty-page-1594944 |
Merge into: | lp:ubuntu-system-settings-online-accounts |
Diff against target: |
235 lines (+44/-45) 3 files modified
online-accounts-ui/provider-request.cpp (+29/-26) online-accounts-ui/qml/ProviderRequest.qml (+12/-17) tests/online-accounts-ui/tst_provider_request.cpp (+3/-2) |
To merge this branch: | bzr merge lp:~mardy/ubuntu-system-settings-online-accounts/empty-page-1594944 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
dobey (community) | Needs Fixing | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+298123@code.launchpad.net |
Commit message
Properly handle early termination of account access requests
When a degenerate request (coming from an unconfined process with empty application ID) was received, the allowed() signal was emitted from the Component.
However, given that this all was happening inside the QQuickView:
To solve this, we export a "request" object to QML, whose methods replace the old signals.
Description of the change
Properly handle early termination of account access requests
When a degenerate request (coming from an unconfined process with empty application ID) was received, the allowed() signal was emitted from the Component.
However, given that this all was happening inside the QQuickView:
To solve this, we export a "request" object to QML, whose methods replace the old signals.
I've build this in the silo where I have the ubuntuone- credentials changes, and a blank window is still opened, so this doesn't seem to resolve the bug.
Also, I was trying to find where this file exists on disk, so I could edit in place instead of building a silo, given it's a trivial change, however I do not see this file being installed to the system at all. Is it only included as a resource in Qt?