Merge lp:~mardy/signon-ui/end-request into lp:signon-ui
Proposed by
Alberto Mardegan
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | David King | ||||
Approved revision: | 57 | ||||
Merged at revision: | 57 | ||||
Proposed branch: | lp:~mardy/signon-ui/end-request | ||||
Merge into: | lp:signon-ui | ||||
Diff against target: |
16 lines (+2/-2) 1 file modified
src/browser-request.cpp (+2/-2) |
||||
To merge this branch: | bzr merge lp:~mardy/signon-ui/end-request | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
jenkins (community) | continuous-integration | Approve | |
David King (community) | Approve | ||
Review via email: mp+123899@code.launchpad.net |
Description of the change
Don't show the final dialog if no UI was previously shown
If the request is completed without having shown any UI, don't bring up the
dialog just to tell the user that the request has finished.
To post a comment you must log in.
Just realized that I got myself confused with the description. :-) )->accept( )) instead of continuing loading the page.
The change here is not about showing the notification, but about terminating the request (by calling m_dialog(