Code review comment for lp:~mardy/online-accounts-api/providers-1627001

Revision history for this message
Alberto Mardegan (mardy) wrote :

> I may be missing something here, but (not being familiar with the code), it
> looks like the translated service name is not present? We need the translated
> name of the service too (such as "Google" or "Dropbox", or their equivalents
> in Arabic script, or whatever).

It's there, line 549 of the diff. I'll soon prepare a test app to verify that everything is place, in case unit tests are not catching everything.

« Back to merge proposal