Merge lp:~mardy/autopilot-gtk/lp1176234 into lp:autopilot-gtk

[Alberto Mardegan]

Initialize rect fields to -1

This makes the globalRect variable return negative values (for some reason, not -1 but -2147483648) when the rectangle is offscreen.

Initialize rect fields to -1

This makes the globalRect variable return negative values (for some reason, not -1 but -2147483648) when the rectangle is offscreen.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:37
http://jenkins.qa.ubuntu.com/job/autopilot-gtk-ci/38/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-gtk-raring-amd64-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-gtk-raring-armhf-ci/13

Click here to trigger a rebuild:
http://s-jenkins:8080/job/autopilot-gtk-ci/38/rebuild

review: Approve (continuous-integration)

[Martin Pitt (pitti)]

This looks correct to me as a safety measure, but see my comments in bug 1176234 about not being able to reproduce this.

review: Approve

[Martin Pitt (pitti)]

Even though the bug isn't reproducible, it's a good safety measure anyway to avoid uninitialized values, so I approve this now.

=== modified file 'lib/GtkNode.cpp'
--- lib/GtkNode.cpp	2013-05-07 01:47:49 +0000
+++ lib/GtkNode.cpp	2013-05-07 06:24:24 +0000
@@ -114,6 +114,7 @@
   builder_wrapper.add("visible", visible);
   if (visible) {
     gint x, y, width, height;
+    x = y = width = height = -1;
     atk_component_get_extents(atk_component, &x, &y, &width, &height,
                               ATK_XY_SCREEN);
     GVariant *rect_gvariant = ComposeRectVariant(x, y, width, height);