Merge lp:~mardy/account-polld/lp1493733 into lp:~ubuntu-push-hackers/account-polld/trunk

[Alberto Mardegan]

Remove non working Facebook plugin

Facebook removed the possibility to retrieve notifications, effective from October 6, 2015. From https://developers.facebook.com/docs/apps/changelog/#v2_4:

"The GET /v2.4/{user_id}/home, GET /v2.4/{user_id}/inbox, and GET /v2.4/{user_id}/notifications operations as well as read_stream, read_mailbox, and manage_notifications permissions are deprecated in v2.4."

and

"From October 6, 2015 onwards, in all previous API versions, these endpoints will return empty arrays"

This change contains a couple of packaging changes:
* debian/control, debian/account-polld.conf:
  Remove mentions of Facebook from the descriptions.

Remove non working Facebook plugin

Facebook removed the possibility to retrieve notifications, effective from October 6, 2015. From https://developers.facebook.com/docs/apps/changelog/#v2_4:

"The GET /v2.4/{user_id}/home, GET /v2.4/{user_id}/inbox, and GET /v2.4/{user_id}/notifications operations as well as read_stream, read_mailbox, and manage_notifications permissions are deprecated in v2.4."

and

"From October 6, 2015 onwards, in all previous API versions, these endpoints will return empty arrays"

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:138
http://jenkins.qa.ubuntu.com/job/account-polld-ci/89/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-armhf-ci/4/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/89/rebuild

review: Approve (continuous-integration)

[lp:~mardy/account-polld/lp1493733]

139. By Alberto Mardegan on 2015-09-10

Sync changelog from archive

No-change test rebuild for g++5 ABI transition

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:139
http://jenkins.qa.ubuntu.com/job/account-polld-ci/90/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-armhf-ci/5/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-i386-ci/5

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/90/rebuild

review: Approve (continuous-integration)

[Jonas G. Drange (jonas-drange)]

Could you make a note of why the files under debian/ changed, as I think it's required for landing. Thanks!

review: Needs Information

[lp:~mardy/account-polld/lp1493733]

140. By Alberto Mardegan on 2015-10-12

Update changelog

* Remove non-working facebook integration. (LP: #1493733)
* debian/control, debian/account-polld.conf:
  Remove mentions of Facebook from the descriptions.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:140
http://jenkins.qa.ubuntu.com/job/account-polld-ci/91/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-armhf-ci/6/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-i386-ci/6

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/91/rebuild

review: Approve (continuous-integration)

=== modified file 'cmd/account-polld/main.go'
--- cmd/account-polld/main.go	2015-03-20 17:51:02 +0000
+++ cmd/account-polld/main.go	2015-10-12 13:54:21 +0000
@@ -27,7 +27,6 @@
 	"launchpad.net/account-polld/accounts"
 	"launchpad.net/account-polld/gettext"
 	"launchpad.net/account-polld/plugins"
-	"launchpad.net/account-polld/plugins/facebook"
 	"launchpad.net/account-polld/plugins/gmail"
 	"launchpad.net/account-polld/plugins/twitter"
 	"launchpad.net/account-polld/pollbus"
@@ -47,7 +46,6 @@
 
 	SERVICENAME_GMAIL    = "com.ubuntu.developer.webapps.webapp-gmail_webapp-gmail"
 	SERVICENAME_TWITTER  = "com.ubuntu.developer.webapps.webapp-twitter_webapp-twitter"
-	SERVICENAME_FACEBOOK = "com.ubuntu.developer.webapps.webapp-facebook_webapp-facebook"
 )
 
 const (
@@ -119,10 +117,6 @@
 				case SERVICENAME_GMAIL:
 					log.Println("Creating account with id", data.AccountId, "for", data.ServiceName)
 					plugin = gmail.New(data.AccountId)
-				case SERVICENAME_FACEBOOK:
-					// This is just stubbed until the plugin exists.
-					log.Println("Creating account with id", data.AccountId, "for", data.ServiceName)
-					plugin = facebook.New(data.AccountId)
 				case SERVICENAME_TWITTER:
 					// This is just stubbed until the plugin exists.
 					log.Println("Creating account with id", data.AccountId, "for", data.ServiceName)
 
=== modified file 'debian/account-polld.conf'
--- debian/account-polld.conf	2014-08-06 14:29:13 +0000
+++ debian/account-polld.conf	2015-10-12 13:54:21 +0000
@@ -1,4 +1,4 @@
-description "account-polld checks for notifications for twitter, facebook and gmail and passes them on to the Ubuntu Push Postal service"
+description "account-polld checks for notifications for twitter and gmail and passes them on to the Ubuntu Push Postal service"
 
 start on started ubuntu-push-client
 stop on stopping ubuntu-push-client
 
=== modified file 'debian/changelog'
--- debian/changelog	2015-04-10 17:19:48 +0000
+++ debian/changelog	2015-10-12 13:54:21 +0000
@@ -1,3 +1,17 @@
+account-polld (0.1+15.04.20151012-0ubuntu1) UNRELEASED; urgency=medium
+
+  * Remove non-working facebook integration. (LP: #1493733)
+  * debian/control, debian/account-polld.conf:
+    Remove mentions of Facebook from the descriptions.
+
+ -- Alberto Mardegan <[e-mail]>  Mon, 12 Oct 2015 16:49:52 +0300
+
+account-polld (0.1+15.04.20150410-0ubuntu2~gcc5.1) wily; urgency=medium
+
+  * No-change test rebuild for g++5 ABI transition
+
+ -- Steve Langasek <[e-mail]>  Wed, 15 Jul 2015 07:18:29 +0000
+
 account-polld (0.1+15.04.20150410-0ubuntu1) vivid; urgency=medium
 
   [ John R. Lenton ]
 
=== modified file 'debian/control'
--- debian/control	2014-08-24 00:04:44 +0000
+++ debian/control	2015-10-12 13:54:21 +0000
@@ -29,7 +29,7 @@
 Built-Using: ${misc:Built-Using}
 Recommends: accountsservice,
 Description: Poll daemon for notifications though the Ubuntu Push Client
- This component polls facebook, twitter and gmail for updates and
+ This component polls twitter and gmail for updates and
  communicates with the postal service provided by the ubuntu push client
  to expose notifications for the click webapps for the aforementioned
  services.
 
=== removed directory 'plugins/facebook'
=== removed file 'plugins/facebook/facebook.go'
--- plugins/facebook/facebook.go	2015-03-20 14:34:48 +0000
+++ plugins/facebook/facebook.go	1970-01-01 00:00:00 +0000
@@ -1,453 +0,0 @@
-/*
- Copyright 2014 Canonical Ltd.
-
- This program is free software: you can redistribute it and/or modify it
- under the terms of the GNU General Public License version 3, as published
- by the Free Software Foundation.
-
- This program is distributed in the hope that it will be useful, but
- WITHOUT ANY WARRANTY; without even the implied warranties of
- MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
- PURPOSE.  See the GNU General Public License for more details.
-
- You should have received a copy of the GNU General Public License along
- with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-package facebook
-
-import (
-	"encoding/json"
-	"fmt"
-	"net/http"
-	"net/url"
-	"os"
-	"strings"
-	"time"
-
-	"log"
-
-	"launchpad.net/account-polld/accounts"
-	"launchpad.net/account-polld/gettext"
-	"launchpad.net/account-polld/plugins"
-)
-
-const (
-	facebookTime                        = "2006-01-02T15:04:05-0700"
-	maxIndividualNotifications          = 2
-	consolidatedNotificationsIndexStart = maxIndividualNotifications
-	maxIndividualThreads                = 2
-	consolidatedThreadsIndexStart       = maxIndividualThreads
-	timeOffset                          = -5
-	pluginName                          = "facebook"
-)
-
-var baseUrl, _ = url.Parse("https://graph.facebook.com/v2.0/")
-
-type timeStamp string
-
-func (state fbState) persist(accountId uint) (err error) {
-	err = plugins.Persist(pluginName, accountId, state)
-	if err != nil {
-		log.Print("facebook plugin", accountId, ": failed to save state: ", err)
-		return err
-	}
-	return nil
-}
-
-func stateFromStorage(accountId uint) (state fbState, err error) {
-	err = plugins.FromPersist(pluginName, accountId, &state)
-	if err != nil {
-		return state, err
-	}
-	if _, err := time.Parse(facebookTime, string(state.LastUpdate)); err != nil {
-		return state, err
-	}
-	if _, err := time.Parse(facebookTime, string(state.LastInboxUpdate)); err != nil {
-		return state, err
-	}
-	return state, nil
-}
-
-type fbState struct {
-	LastUpdate      timeStamp `json:"last_notification_update"`
-	LastInboxUpdate timeStamp `json:"last_inbox_update"`
-}
-
-type fbPlugin struct {
-	state     fbState
-	accountId uint
-}
-
-var doRequest = request
-
-func request(authData *accounts.AuthData, path string) (*http.Response, error) {
-	// Resolve path relative to Graph API base URL, and add access token
-	u, err := baseUrl.Parse(path)
-	if err != nil {
-		return nil, err
-	}
-	query := u.Query()
-	query.Add("access_token", authData.AccessToken)
-	u.RawQuery = query.Encode()
-
-	return http.Get(u.String())
-}
-
-func New(accountId uint) plugins.Plugin {
-	state, err := stateFromStorage(accountId)
-	if err != nil {
-		log.Print("facebook plugin ", accountId, ": cannot load previous state from storage: ", err)
-	} else {
-		log.Print("facebook plugin ", accountId, ": last state loaded from storage")
-	}
-	return &fbPlugin{state: state, accountId: accountId}
-}
-
-func (p *fbPlugin) ApplicationId() plugins.ApplicationId {
-	return "com.ubuntu.developer.webapps.webapp-facebook_webapp-facebook"
-}
-
-func (p *fbPlugin) decodeResponse(resp *http.Response, result interface{}) error {
-	defer resp.Body.Close()
-	decoder := json.NewDecoder(resp.Body)
-	if resp.StatusCode != http.StatusOK {
-		var result errorDoc
-		if err := decoder.Decode(&result); err != nil {
-			return err
-		}
-		if result.Error.Code == 190 {
-			return plugins.ErrTokenExpired
-		}
-		return &result.Error
-	}
-	// TODO: Follow the "paging.next" link if we get more than one
-	// page full of notifications.
-	return decoder.Decode(result)
-}
-
-func (p *fbPlugin) filterNotifications(doc Document, lastUpdate *timeStamp) []Notification {
-	var validNotifications []Notification
-	latestUpdate := *lastUpdate
-	for i := 0; i < doc.size(); i++ {
-		n := doc.notification(i)
-		if !n.isValid(*lastUpdate) {
-			log.Println("facebook plugin: skipping:", n)
-		} else {
-			log.Println("facebook plugin: valid:", n)
-			validNotifications = append(validNotifications, n) // get the actual reference, not the copy
-			if n.updatedTime() > latestUpdate {
-				latestUpdate = n.updatedTime()
-			}
-		}
-	}
-	*lastUpdate = latestUpdate
-	p.state.persist(p.accountId)
-	return validNotifications
-}
-
-func (p *fbPlugin) buildPushMessages(notifications []Notification, doc Document, max int, consolidatedIndexStart int) *plugins.PushMessageBatch {
-	pushMsg := make([]*plugins.PushMessage, len(notifications))
-	for i, n := range notifications {
-		pushMsg[i] = n.buildPushMessage()
-	}
-	return &plugins.PushMessageBatch{
-		Messages:        pushMsg,
-		Limit:           max,
-		OverflowHandler: doc.handleOverflow,
-		Tag:             doc.getTag(),
-	}
-}
-
-func (p *fbPlugin) parseResponse(resp *http.Response) (*plugins.PushMessageBatch, error) {
-	var result notificationDoc
-	if err := p.decodeResponse(resp, &result); err != nil {
-		return nil, err
-	}
-	// TODO filter out of date messages before operating?
-	validNotifications := p.filterNotifications(&result, &p.state.LastUpdate)
-	pushMsgs := p.buildPushMessages(validNotifications, &result, maxIndividualNotifications, consolidatedNotificationsIndexStart)
-	return pushMsgs, nil
-}
-
-func (p *fbPlugin) parseInboxResponse(resp *http.Response) (*plugins.PushMessageBatch, error) {
-	var result inboxDoc
-	if err := p.decodeResponse(resp, &result); err != nil {
-		return nil, err
-	}
-	validThreads := p.filterNotifications(&result, &p.state.LastInboxUpdate)
-	pushMsgs := p.buildPushMessages(validThreads, &result, maxIndividualThreads, consolidatedThreadsIndexStart)
-	return pushMsgs, nil
-}
-
-func (p *fbPlugin) getNotifications(authData *accounts.AuthData) (*plugins.PushMessageBatch, error) {
-	resp, err := doRequest(authData, "me/notifications")
-	if err != nil {
-		log.Println("facebook plugin: notifications poll failed: ", err)
-		return nil, err
-	}
-	notifications, err := p.parseResponse(resp)
-	if err != nil {
-		log.Println("facebook plugin: failed to parse notification response: ", err)
-		return nil, err
-	}
-	return notifications, nil
-}
-
-func (p *fbPlugin) getInbox(authData *accounts.AuthData) (*plugins.PushMessageBatch, error) {
-	resp, err := doRequest(authData, "me/inbox?fields=unread,unseen,comments.limit(1)")
-	if err != nil {
-		log.Println("facebook plugin: inbox poll failed: ", err)
-		return nil, err
-	}
-	inbox, err := p.parseInboxResponse(resp)
-	if err != nil {
-		log.Println("facebook plugin: failed to parse inbox response: ", err)
-		return nil, err
-	}
-	return inbox, nil
-}
-
-func (p *fbPlugin) Poll(authData *accounts.AuthData) ([]*plugins.PushMessageBatch, error) {
-	// This envvar check is to ease testing.
-	if token := os.Getenv("ACCOUNT_POLLD_TOKEN_FACEBOOK"); token != "" {
-		authData.AccessToken = token
-	}
-	notifications, notifErr := p.getNotifications(authData)
-	inbox, inboxErr := p.getInbox(authData)
-	// only return error if both requests failed
-	if notifErr != nil && inboxErr != nil {
-		return nil, fmt.Errorf("poll failed with '%s' and '%s'", notifErr, inboxErr)
-	}
-	if notifErr != nil {
-		return []*plugins.PushMessageBatch{inbox}, nil
-	}
-	if inboxErr != nil {
-		return []*plugins.PushMessageBatch{notifications}, nil
-	}
-	return []*plugins.PushMessageBatch{notifications, inbox}, nil
-}
-
-func toEpoch(stamp timeStamp) int64 {
-	if t, err := time.Parse(facebookTime, string(stamp)); err == nil {
-		return t.Unix()
-	}
-	return time.Now().Unix()
-}
-
-// The notifications response format is described here:
-// https://developers.facebook.com/docs/graph-api/reference/v2.0/user/notifications/
-type notificationDoc struct {
-	Data   []notification `json:"data"`
-	Paging struct {
-		Previous string `json:"previous"`
-		Next     string `json:"next"`
-	} `json:"paging"`
-}
-
-type notification struct {
-	Id          string    `json:"id"`
-	From        object    `json:"from"`
-	To          object    `json:"to"`
-	CreatedTime timeStamp `json:"created_time"`
-	UpdatedTime timeStamp `json:"updated_time"`
-	Title       string    `json:"title"`
-	Link        string    `json:"link"`
-	Application object    `json:"application"`
-	Unread      int       `json:"unread"`
-	Object      object    `json:"object"`
-}
-
-func picture(msgId string, id string) string {
-	u, err := baseUrl.Parse(fmt.Sprintf("%s/picture", id))
-	if err != nil {
-		log.Println("facebook plugin: cannot get picture for", msgId)
-		return ""
-	}
-	query := u.Query()
-	query.Add("redirect", "true")
-	u.RawQuery = query.Encode()
-	return u.String()
-}
-
-type object struct {
-	Id   string `json:"id"`
-	Name string `json:"name"`
-}
-
-// The error response format is described here:
-// https://developers.facebook.com/docs/graph-api/using-graph-api/v2.0#errors
-type errorDoc struct {
-	Error GraphError `json:"error"`
-}
-
-type GraphError struct {
-	Message string `json:"message"`
-	Type    string `json:"type"`
-	Code    int    `json:"code"`
-	Subcode int    `json:"error_subcode"`
-}
-
-func (err *GraphError) Error() string {
-	return err.Message
-}
-
-// The inbox response format is described here:
-// https://developers.facebook.com/docs/graph-api/reference/v2.0/user/inbox
-type inboxDoc struct {
-	Data   []thread `json:"data"`
-	Paging struct {
-		Previous string `json:"previous"`
-		Next     string `json:"next"`
-	} `json:"paging"`
-	Summary summary `json:"summary"`
-}
-
-type summary struct {
-	UnseenCount int       `json:"unseen_count"`
-	UnreadCount int       `json:"unread_count"`
-	UpdatedTime timeStamp `json:"updated_time"`
-}
-
-type thread struct {
-	Id          string    `json:"id"`
-	Comments    comments  `json:"comments"`
-	To          []object  `json:"to"`
-	Unread      int       `json:"unread"`
-	Unseen      int       `json:"unseen"`
-	UpdatedTime timeStamp `json:"updated_time"`
-	Paging      struct {
-		Previous string `json:"previous"`
-		Next     string `json:"next"`
-	} `json:"paging"`
-}
-
-type comments struct {
-	Data   []message `json:"data"`
-	Paging struct {
-		Previous string `json:"previous"`
-		Next     string `json:"next"`
-	} `json:"paging"`
-}
-
-type message struct {
-	CreatedTime timeStamp `json:"created_time"`
-	From        object    `json:"from"`
-	Id          string    `json:"id"`
-	Message     string    `json:message`
-}
-
-func (doc *inboxDoc) getTag() string {
-	return "inbox"
-}
-
-func (doc *inboxDoc) handleOverflow(pushMsg []*plugins.PushMessage) *plugins.PushMessage {
-	usernames := []string{}
-	for _, m := range pushMsg {
-		usernames = append(usernames, m.Notification.Card.Summary)
-		if len(usernames) > 10 {
-			usernames[10] = "…"
-			break
-		}
-	}
-	// TRANSLATORS: This represents a message summary about more facebook messages
-	summary := gettext.Gettext("Multiple more messages")
-	// TRANSLATORS: This represents a message body with the comma separated facebook usernames
-	body := fmt.Sprintf(gettext.Gettext("From %s"), strings.Join(usernames, ", "))
-	action := "https://m.facebook.com/messages"
-	epoch := time.Now().Unix()
-	return plugins.NewStandardPushMessage(summary, body, action, "", epoch)
-}
-
-func (doc *inboxDoc) size() int {
-	return len(doc.Data)
-}
-
-func (doc *inboxDoc) notification(idx int) Notification {
-	return &doc.Data[idx]
-}
-
-func (t *thread) buildPushMessage() *plugins.PushMessage {
-	link := "https://www.facebook.com/messages?action=recent-messages"
-	epoch := toEpoch(t.UpdatedTime)
-	// get the single message we fetch
-	message := t.Comments.Data[0]
-	return plugins.NewStandardPushMessage(message.From.Name, message.Message, link, picture(t.Id, message.From.Id), epoch)
-}
-
-func (t *thread) isValid(tStamp timeStamp) bool {
-	limit := timeStamp(time.Now().Add(timeOffset * time.Minute).Format(facebookTime))
-	return tStamp < t.UpdatedTime && t.UpdatedTime < limit && t.Unread != 0 && t.Unseen != 0
-}
-
-func (t *thread) updatedTime() timeStamp {
-	return t.UpdatedTime
-}
-
-func (t *thread) String() string {
-	return fmt.Sprintf("id: %s, dated: %s, unread: %d, unseen: %d", t.Id, t.UpdatedTime, t.Unread, t.Unseen)
-}
-
-func (doc *notificationDoc) getTag() string {
-	return "notification"
-}
-
-func (doc *notificationDoc) handleOverflow(pushMsg []*plugins.PushMessage) *plugins.PushMessage {
-	usernames := []string{}
-	for _, m := range pushMsg {
-		usernames = append(usernames, m.Notification.Card.Summary)
-		if len(usernames) > 10 {
-			usernames[10] = "…"
-			break
-		}
-	}
-	// TRANSLATORS: This represents a notification summary about more facebook notifications
-	summary := gettext.Gettext("Multiple more notifications")
-	// TRANSLATORS: This represents a notification body with the comma separated facebook usernames
-	body := fmt.Sprintf(gettext.Gettext("From %s"), strings.Join(usernames, ", "))
-	action := "https://m.facebook.com"
-	epoch := time.Now().Unix()
-	return plugins.NewStandardPushMessage(summary, body, action, "", epoch)
-}
-
-func (doc *notificationDoc) size() int {
-	return len(doc.Data)
-}
-
-func (doc *notificationDoc) notification(idx int) Notification {
-	return &doc.Data[idx]
-}
-
-func (n *notification) buildPushMessage() *plugins.PushMessage {
-	epoch := toEpoch(n.UpdatedTime)
-	return plugins.NewStandardPushMessage(n.From.Name, n.Title, n.Link, picture(n.Id, n.From.Id), epoch)
-}
-
-func (n *notification) isValid(tStamp timeStamp) bool {
-	return n.UpdatedTime > tStamp && n.Unread >= 1
-}
-
-func (n *notification) updatedTime() timeStamp {
-	return n.UpdatedTime
-}
-
-func (n *notification) String() string {
-	return fmt.Sprintf("id: %s, dated: %s, unread: %d", n.Id, n.UpdatedTime, n.Unread)
-}
-
-type Document interface {
-	getTag() string
-	handleOverflow([]*plugins.PushMessage) *plugins.PushMessage
-	size() int
-	notification(int) Notification
-}
-
-type Notification interface {
-	buildPushMessage() *plugins.PushMessage
-	isValid(timeStamp) bool
-	updatedTime() timeStamp
-	String() string
-}
-
-var _ Notification = (*thread)(nil)
-var _ Notification = (*notification)(nil)
 
=== removed file 'plugins/facebook/facebook_test.go'
--- plugins/facebook/facebook_test.go	2015-03-20 14:34:48 +0000
+++ plugins/facebook/facebook_test.go	1970-01-01 00:00:00 +0000
@@ -1,835 +0,0 @@
-/*
- Copyright 2014 Canonical Ltd.
-
- This program is free software: you can redistribute it and/or modify it
- under the terms of the GNU General Public License version 3, as published
- by the Free Software Foundation.
-
- This program is distributed in the hope that it will be useful, but
- WITHOUT ANY WARRANTY; without even the implied warranties of
- MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
- PURPOSE.  See the GNU General Public License for more details.
-
- You should have received a copy of the GNU General Public License along
- with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-package facebook
-
-import (
-	"bytes"
-	"encoding/json"
-	"fmt"
-	"io"
-	"io/ioutil"
-	"net/http"
-	"net/url"
-	"os"
-	"path"
-	"path/filepath"
-	"time"
-
-	"net/http/httptest"
-	"testing"
-
-	. "launchpad.net/gocheck"
-
-	"launchpad.net/account-polld/accounts"
-	"launchpad.net/account-polld/plugins"
-	"launchpad.net/go-xdg/v0"
-)
-
-type S struct {
-	tempDir string
-	ts      *httptest.Server
-}
-
-var _ = Suite(&S{})
-
-func Test(t *testing.T) { TestingT(t) }
-
-// closeWraper adds a dummy Close() method to a reader
-type closeWrapper struct {
-	io.Reader
-}
-
-func (r closeWrapper) Close() error {
-	return nil
-}
-
-const (
-	errorBody = `
-{
-  "error": {
-    "message": "Unknown path components: /xyz",
-    "type": "OAuthException",
-    "code": 2500
-  }
-}`
-	tokenExpiredErrorBody = `
-{
-  "error": {
-    "message": "Error validating access token: Session has expired",
-    "type": "OAuthException",
-    "code": 190 ,
-    "error_subcode": 463
-  }
-}`
-	notificationsBody = `
-{
-  "data": [
-    {
-      "id": "notif_id",
-      "from": {
-        "id": "sender_id",
-        "name": "Sender"
-      },
-      "to": {
-        "id": "recipient_id",
-        "name": "Recipient"
-      },
-      "created_time": "2014-07-12T09:51:57+0000",
-      "updated_time": "2014-07-12T09:51:57+0000",
-      "title": "Sender posted on your timeline: \"The message...\"",
-      "link": "http://www.facebook.com/recipient/posts/id",
-      "application": {
-        "name": "Wall",
-        "namespace": "wall",
-        "id": "2719290516"
-      },
-      "unread": 1
-    },
-    {
-      "id": "notif_1105650586_80600069",
-      "from": {
-        "id": "sender2_id",
-        "name": "Sender2"
-      },
-      "to": {
-        "id": "recipient_id",
-        "name": "Recipient"
-      },
-      "created_time": "2014-07-08T06:17:52+0000",
-      "updated_time": "2014-07-08T06:17:52+0000",
-      "title": "Sender2's birthday was on July 7.",
-      "link": "http://www.facebook.com/profile.php?id=xxx&ref=brem",
-      "application": {
-        "name": "Gifts",
-        "namespace": "superkarma",
-        "id": "329122197162272"
-      },
-      "unread": 1,
-      "object": {
-        "id": "sender2_id",
-        "name": "Sender2"
-      }
-    }
-  ],
-  "paging": {
-    "previous": "https://graph.facebook.com/v2.0/recipient/notifications?limit=5000&since=1405158717&__paging_token=enc_AewDzwIQmWOwPNO-36GaZsaJAog8l93HQ7uLEO-gp1Tb6KCiolXfzMCcGY2KjrJJsDJXdDmNJObICr5dewfMZgGs",
-    "next": "https://graph.facebook.com/v2.0/recipient/notifications?limit=5000&until=1404705077&__paging_token=enc_Aewlhut5DQyhqtLNr7pLCMlYU012t4XY7FOt7cooz4wsWIWi-Jqz0a0IDnciJoeLu2vNNQkbtOpCmEmsVsN4hkM4"
-  },
-  "summary": [
-  ]
-}
-`
-	largeNotificationsBody = `
-{
-  "data": [
-    {
-      "id": "notif_id",
-      "from": {
-        "id": "sender_id",
-        "name": "Sender"
-      },
-      "to": {
-        "id": "recipient_id",
-        "name": "Recipient"
-      },
-      "created_time": "2014-07-12T09:51:57+0000",
-      "updated_time": "2014-07-12T09:51:57+0000",
-      "title": "Sender posted on your timeline: \"The message...\"",
-      "link": "http://www.facebook.com/recipient/posts/id",
-      "application": {
-        "name": "Wall",
-        "namespace": "wall",
-        "id": "2719290516"
-      },
-      "unread": 1
-    },
-    {
-      "id": "notif_1105650586_80600069",
-      "from": {
-        "id": "sender2_id",
-        "name": "Sender2"
-      },
-      "to": {
-        "id": "recipient_id",
-        "name": "Recipient"
-      },
-      "created_time": "2014-07-08T06:17:52+0000",
-      "updated_time": "2014-07-08T06:17:52+0000",
-      "title": "Sender2's birthday was on July 7.",
-      "link": "http://www.facebook.com/profile.php?id=xxx&ref=brem",
-      "application": {
-        "name": "Gifts",
-        "namespace": "superkarma",
-        "id": "329122197162272"
-      },
-      "unread": 1,
-      "object": {
-        "id": "sender2_id",
-        "name": "Sender2"
-      }
-    },
-    {
-      "id": "notif_id_3",
-      "from": {
-        "id": "sender3_id",
-        "name": "Sender3"
-      },
-      "to": {
-        "id": "recipient_id",
-        "name": "Recipient"
-      },
-      "created_time": "2014-07-12T09:51:57+0000",
-      "updated_time": "2014-07-12T09:51:57+0000",
-      "title": "Sender posted on your timeline: \"The message...\"",
-      "link": "http://www.facebook.com/recipient/posts/id",
-      "application": {
-        "name": "Wall",
-        "namespace": "wall",
-        "id": "2719290516"
-      },
-      "unread": 1
-    },
-    {
-      "id": "notif_id_4",
-      "from": {
-        "id": "sender4_id",
-        "name": "Sender2"
-      },
-      "to": {
-        "id": "recipient_id",
-        "name": "Recipient"
-      },
-      "created_time": "2014-07-08T06:17:52+0000",
-      "updated_time": "2014-07-08T06:17:52+0000",
-      "title": "Sender2's birthday was on July 7.",
-      "link": "http://www.facebook.com/profile.php?id=xxx&ref=brem",
-      "application": {
-        "name": "Gifts",
-        "namespace": "superkarma",
-        "id": "329122197162272"
-      },
-      "unread": 1
-    }
-  ],
-  "paging": {
-    "previous": "https://graph.facebook.com/v2.0/recipient/notifications?limit=5000&since=1405158717&__paging_token=enc_AewDzwIQmWOwPNO-36GaZsaJAog8l93HQ7uLEO-gp1Tb6KCiolXfzMCcGY2KjrJJsDJXdDmNJObICr5dewfMZgGs",
-    "next": "https://graph.facebook.com/v2.0/recipient/notifications?limit=5000&until=1404705077&__paging_token=enc_Aewlhut5DQyhqtLNr7pLCMlYU012t4XY7FOt7cooz4wsWIWi-Jqz0a0IDnciJoeLu2vNNQkbtOpCmEmsVsN4hkM4"
-  },
-  "summary": [
-  ]
-}
-`
-
-	inboxBody = `
-{
-  "data": [
-    {
-      "unread": 1, 
-      "unseen": 1, 
-      "id": "445809168892281", 
-      "updated_time": "2014-08-25T18:39:32+0000", 
-      "comments": {
-        "data": [
-          {
-            "id": "445809168892281_1408991972", 
-            "from": {
-              "id": "346217352202239", 
-              "name": "Pollod Magnifico"
-            }, 
-            "message": "Hola mundo!", 
-            "created_time": "2014-08-25T18:39:32+0000"
-          }
-        ], 
-        "paging": {
-          "previous": "https://graph.facebook.com/v2.0/445809168892281/comments?limit=1&since=1408991972&__paging_token=enc_Aew2kKJXEXzdm9k89DvLYz_y8nYxUbvElWcn6h_pKMRsoAPTPpkU7-AsGhkcYF6M1qbomOnFJf9ckL5J3hTltLFq", 
-          "next": "https://graph.facebook.com/v2.0/445809168892281/comments?limit=1&until=1408991972&__paging_token=enc_Aewlixpk4h4Vq79-W1ixrTM6ONbsMUDrcj0vLABs34tbhWarfpQLf818uoASWNDEpQO4XEXh5HbgHpcCqnuNVEOR"
-        }
-      }
-    },
-    {
-      "unread": 2, 
-      "unseen": 1, 
-      "id": "445809168892282", 
-      "updated_time": "2014-08-25T18:39:32+0000", 
-      "comments": {
-        "data": [
-          {
-            "id": "445809168892282_1408991973", 
-            "from": {
-              "id": "346217352202239", 
-              "name": "Pollitod Magnifico"
-            }, 
-            "message": "Hola!", 
-            "created_time": "2014-08-25T18:39:32+0000"
-          }
-        ], 
-        "paging": {
-          "previous": "https://graph.facebook.com/v2.0/445809168892281/comments?limit=1&since=1408991972&__paging_token=enc_Aew2kKJXEXzdm9k89DvLYz_y8nYxUbvElWcn6h_pKMRsoAPTPpkU7-AsGhkcYF6M1qbomOnFJf9ckL5J3hTltLFq", 
-          "next": "https://graph.facebook.com/v2.0/445809168892281/comments?limit=1&until=1408991972&__paging_token=enc_Aewlixpk4h4Vq79-W1ixrTM6ONbsMUDrcj0vLABs34tbhWarfpQLf818uoASWNDEpQO4XEXh5HbgHpcCqnuNVEOR"
-        }
-      }
-    },
-    {
-      "unread": 2, 
-      "unseen": 1, 
-      "id": "445809168892283", 
-      "updated_time": "2014-08-25T18:39:32+0000", 
-      "comments": {
-        "data": [
-          {
-            "id": "445809168892282_1408991973", 
-            "from": {
-              "id": "346217352202240", 
-              "name": "A Friend"
-            }, 
-            "message": "mellon", 
-            "created_time": "2014-08-25T18:39:32+0000"
-          }
-        ], 
-        "paging": {
-          "previous": "https://graph.facebook.com/v2.0/445809168892281/comments?limit=1&since=1408991972&__paging_token=enc_Aew2kKJXEXzdm9k89DvLYz_y8nYxUbvElWcn6h_pKMRsoAPTPpkU7-AsGhkcYF6M1qbomOnFJf9ckL5J3hTltLFq", 
-          "next": "https://graph.facebook.com/v2.0/445809168892281/comments?limit=1&until=1408991972&__paging_token=enc_Aewlixpk4h4Vq79-W1ixrTM6ONbsMUDrcj0vLABs34tbhWarfpQLf818uoASWNDEpQO4XEXh5HbgHpcCqnuNVEOR"
-        }
-      }
-    }
-
-
-  ], 
-  "paging": {
-    "previous": "https://graph.facebook.com/v2.0/270128826512416/inbox?fields=unread,unseen,comments.limit(1)&limit=25&since=1408991972&__paging_token=enc_Aey99ACSOyZqN_7I-yWLnY8K3dqu4wVsx-Th3kMHMTMQ5VPbQRPgCQiJps0II1QAXDAVzHplqPS8yNgq8Zs_G2aK", 
-    "next": "https://graph.facebook.com/v2.0/270128826512416/inbox?fields=unread,unseen,comments.limit(1)&limit=25&until=1408991972&__paging_token=enc_AewjHkk10NNjRCXJCoaP5hyf22kw-htwxsDaVOiLY-IiXxB99sKNGlfFFmkcG-VeMGUETI2agZGR_1IWP5W4vyPL"
-  }, 
-  "summary": {
-    "unseen_count": 0, 
-    "unread_count": 1, 
-    "updated_time": "2014-08-25T19:05:49+0000"
-  }
-}
-`
-)
-
-func (s *S) SetUpTest(c *C) {
-	s.tempDir = c.MkDir()
-	plugins.XdgDataFind = func(a string) (string, error) {
-		return filepath.Join(s.tempDir, a), nil
-	}
-	plugins.XdgDataEnsure = func(a string) (string, error) {
-		p := filepath.Join(s.tempDir, a)
-		base := path.Dir(p)
-		if _, err := os.Stat(base); err != nil {
-			os.MkdirAll(base, 0700)
-		}
-		return p, nil
-	}
-	s.ts = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		fmt.Fprintln(w, "Hello, client")
-	}))
-	baseUrl, _ = url.Parse(s.ts.URL)
-}
-
-func (s *S) TearDownTest(c *C) {
-	plugins.XdgDataFind = xdg.Data.Find
-	plugins.XdgDataEnsure = xdg.Data.Find
-	doRequest = request
-	s.ts.Close()
-}
-
-func (s *S) TestParseNotifications(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusOK,
-		Body:       closeWrapper{bytes.NewReader([]byte(notificationsBody))},
-	}
-	p := &fbPlugin{}
-	batch, err := p.parseResponse(resp)
-	c.Assert(err, IsNil)
-	c.Assert(batch, NotNil)
-	messages := batch.Messages
-	c.Assert(len(messages), Equals, 2)
-	c.Check(messages[0].Notification.Card.Summary, Equals, "Sender")
-	c.Check(messages[0].Notification.Card.Body, Equals, "Sender posted on your timeline: \"The message...\"")
-	c.Check(messages[1].Notification.Card.Summary, Equals, "Sender2")
-	c.Check(messages[1].Notification.Card.Body, Equals, "Sender2's birthday was on July 7.")
-	c.Check(p.state.LastUpdate, Equals, timeStamp("2014-07-12T09:51:57+0000"))
-}
-
-func (s *S) TestParseLotsOfNotifications(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusOK,
-		Body:       closeWrapper{bytes.NewReader([]byte(largeNotificationsBody))},
-	}
-	p := &fbPlugin{}
-	batch, err := p.parseResponse(resp)
-	c.Assert(err, IsNil)
-	c.Assert(batch, NotNil)
-	messages := batch.Messages
-	c.Assert(len(messages), Equals, 4)
-	c.Check(messages[0].Notification.Card.Summary, Equals, "Sender")
-	c.Check(messages[0].Notification.Card.Body, Equals, "Sender posted on your timeline: \"The message...\"")
-	c.Check(messages[1].Notification.Card.Summary, Equals, "Sender2")
-	c.Check(messages[1].Notification.Card.Body, Equals, "Sender2's birthday was on July 7.")
-	ofMsg := batch.OverflowHandler(messages[2:])
-	c.Check(ofMsg.Notification.Card.Summary, Equals, "Multiple more notifications")
-	c.Check(ofMsg.Notification.Card.Body, Equals, "From Sender3, Sender2")
-	c.Check(p.state.LastUpdate, Equals, timeStamp("2014-07-12T09:51:57+0000"))
-}
-
-func (s *S) TestIgnoreOldNotifications(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusOK,
-		Body:       closeWrapper{bytes.NewReader([]byte(notificationsBody))},
-	}
-	p := &fbPlugin{state: fbState{LastUpdate: "2014-07-08T06:17:52+0000"}}
-	batch, err := p.parseResponse(resp)
-	c.Assert(err, IsNil)
-	c.Assert(batch, NotNil)
-	messages := batch.Messages
-	c.Assert(len(messages), Equals, 1)
-	c.Check(messages[0].Notification.Card.Summary, Equals, "Sender")
-	c.Check(messages[0].Notification.Card.Body, Equals, "Sender posted on your timeline: \"The message...\"")
-	c.Check(p.state.LastUpdate, Equals, timeStamp("2014-07-12T09:51:57+0000"))
-}
-
-func (s *S) TestParseResponseErrorResponse(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusBadRequest,
-		Body:       closeWrapper{bytes.NewReader([]byte(errorBody))},
-	}
-	p := &fbPlugin{}
-	notifications, err := p.parseResponse(resp)
-	c.Check(notifications, IsNil)
-	c.Assert(err, Not(IsNil))
-	graphErr := err.(*GraphError)
-	c.Check(graphErr.Message, Equals, "Unknown path components: /xyz")
-	c.Check(graphErr.Code, Equals, 2500)
-}
-
-func (s *S) TestDecodeResponseErrorResponse(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusBadRequest,
-		Body:       closeWrapper{bytes.NewReader([]byte(errorBody))},
-	}
-	p := &fbPlugin{}
-	var result notificationDoc
-	err := p.decodeResponse(resp, &result)
-	c.Check(result, DeepEquals, notificationDoc{})
-	c.Assert(err, Not(IsNil))
-	graphErr := err.(*GraphError)
-	c.Check(graphErr.Message, Equals, "Unknown path components: /xyz")
-	c.Check(graphErr.Code, Equals, 2500)
-}
-
-func (s *S) TestDecodeResponseErrorResponseFails(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusBadRequest,
-		Body:       closeWrapper{bytes.NewReader([]byte("hola" + errorBody))},
-	}
-	p := &fbPlugin{}
-	var result notificationDoc
-	err := p.decodeResponse(resp, &result)
-	c.Check(result, DeepEquals, notificationDoc{})
-	c.Assert(err, NotNil)
-	jsonErr := err.(*json.SyntaxError)
-	c.Check(jsonErr.Offset, Equals, int64(1))
-}
-
-func (s *S) TestTokenExpiredErrorResponse(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusBadRequest,
-		Body:       closeWrapper{bytes.NewReader([]byte(tokenExpiredErrorBody))},
-	}
-	p := &fbPlugin{}
-	notifications, err := p.parseResponse(resp)
-	c.Check(notifications, IsNil)
-	c.Assert(err, Equals, plugins.ErrTokenExpired)
-}
-
-func (s *S) TestParseInbox(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusOK,
-		Body:       closeWrapper{bytes.NewReader([]byte(inboxBody))},
-	}
-	p := &fbPlugin{}
-	batch, err := p.parseInboxResponse(resp)
-	c.Assert(err, IsNil)
-	c.Assert(batch, NotNil)
-	messages := batch.Messages
-	c.Assert(len(messages), Equals, 3)
-	c.Check(messages[0].Notification.Card.Summary, Equals, "Pollod Magnifico")
-	c.Check(messages[0].Notification.Card.Body, Equals, "Hola mundo!")
-	c.Check(messages[1].Notification.Card.Summary, Equals, "Pollitod Magnifico")
-	c.Check(messages[1].Notification.Card.Body, Equals, "Hola!")
-
-	ofMsg := batch.OverflowHandler(messages[batch.Limit:])
-
-	c.Check(ofMsg.Notification.Card.Summary, Equals, "Multiple more messages")
-	c.Check(ofMsg.Notification.Card.Body, Equals, "From A Friend")
-	c.Check(p.state.LastInboxUpdate, Equals, timeStamp("2014-08-25T18:39:32+0000"))
-}
-
-func (s *S) TestDecodeResponse(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusOK,
-		Body:       closeWrapper{bytes.NewReader([]byte(inboxBody))},
-	}
-	p := &fbPlugin{}
-	var doc inboxDoc
-	err := p.decodeResponse(resp, &doc)
-	c.Check(err, IsNil)
-	c.Check(len(doc.Data), Equals, 3)
-}
-
-func (s *S) TestDecodeResponseFails(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusOK,
-		Body:       closeWrapper{bytes.NewReader([]byte("hola" + inboxBody))},
-	}
-	p := &fbPlugin{}
-	var doc inboxDoc
-	err := p.decodeResponse(resp, &doc)
-	c.Assert(err, NotNil)
-	jsonErr := err.(*json.SyntaxError)
-	c.Check(jsonErr.Offset, Equals, int64(1))
-}
-
-func (s *S) TestFilterNotifications(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusOK,
-		Body:       closeWrapper{bytes.NewReader([]byte(inboxBody))},
-	}
-	p := &fbPlugin{}
-	var doc inboxDoc
-	p.decodeResponse(resp, &doc)
-	var state fbState
-	notifications := p.filterNotifications(&doc, &state.LastInboxUpdate)
-	c.Check(notifications, HasLen, 3)
-	// check if the lastInboxUpdate is updated
-	c.Check(state.LastInboxUpdate, Equals, timeStamp("2014-08-25T18:39:32+0000"))
-}
-
-func (s *S) TestBuildPushMessages(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusOK,
-		Body:       closeWrapper{bytes.NewReader([]byte(inboxBody))},
-	}
-	var state fbState
-	p := &fbPlugin{state: state, accountId: 32}
-	var doc inboxDoc
-	p.decodeResponse(resp, &doc)
-	notifications := p.filterNotifications(&doc, &p.state.LastInboxUpdate)
-	batch := p.buildPushMessages(notifications, &doc, doc.size(), doc.size())
-	c.Assert(batch, NotNil)
-	c.Check(batch.Messages, HasLen, doc.size())
-}
-
-func (s *S) TestBuildPushMessagesConsolidate(c *C) {
-	resp := &http.Response{
-		StatusCode: http.StatusOK,
-		Body:       closeWrapper{bytes.NewReader([]byte(inboxBody))},
-	}
-	var state fbState
-	p := &fbPlugin{state: state, accountId: 32}
-	var doc inboxDoc
-	p.decodeResponse(resp, &doc)
-	notifications := p.filterNotifications(&doc, &p.state.LastInboxUpdate)
-	max := doc.size() - 2
-	batch := p.buildPushMessages(notifications, &doc, max, max)
-	c.Assert(batch, NotNil)
-	// we should get all the messages in a batch with Limit=max
-	c.Check(batch.Messages, HasLen, len(notifications))
-	c.Check(batch.Limit, Equals, max)
-}
-
-func (s *S) TestStateFromStorageInitialState(c *C) {
-	state, err := stateFromStorage(32)
-	c.Check(err, NotNil)
-	c.Check(state.LastUpdate, Equals, timeStamp(""))
-	c.Check(state.LastInboxUpdate, Equals, timeStamp(""))
-}
-
-func (s *S) TestStateFromStoragePersist(c *C) {
-	filePath := filepath.Join(s.tempDir, "facebook.test/facebook-32.json")
-	state, err := stateFromStorage(32)
-	c.Check(err, NotNil)
-	state.LastInboxUpdate = timeStamp("2014-08-25T18:39:32+0000")
-	state.LastUpdate = timeStamp("2014-08-25T18:39:33+0000")
-	err = state.persist(32)
-	c.Check(err, IsNil)
-	jsonData, err := ioutil.ReadFile(filePath)
-	c.Check(err, IsNil)
-	var data map[string]string
-	json.Unmarshal(jsonData, &data)
-	c.Check(data["last_inbox_update"], Equals, "2014-08-25T18:39:32+0000")
-	c.Check(data["last_notification_update"], Equals, "2014-08-25T18:39:33+0000")
-}
-
-func (s *S) TestStateFromStoragePersistFails(c *C) {
-	state := fbState{LastInboxUpdate: "2014-08-25T18:39:32+0000", LastUpdate: "2014-08-25T18:39:33+0000"}
-	plugins.XdgDataEnsure = plugins.XdgDataFind
-	err := state.persist(32)
-	c.Check(err, NotNil)
-}
-
-func (s *S) TestStateFromStorage(c *C) {
-	state := fbState{LastInboxUpdate: "2014-08-25T18:39:32+0000", LastUpdate: "2014-08-25T18:39:33+0000"}
-	err := state.persist(32)
-	c.Check(err, IsNil)
-	newState, err := stateFromStorage(32)
-	c.Check(err, IsNil)
-	c.Check(newState.LastUpdate, Equals, timeStamp("2014-08-25T18:39:33+0000"))
-	c.Check(newState.LastInboxUpdate, Equals, timeStamp("2014-08-25T18:39:32+0000"))
-	// bad format
-	state = fbState{LastInboxUpdate: "yesterday", LastUpdate: "2014-08-25T18:39:33+0000"}
-	state.persist(32)
-	_, err = stateFromStorage(32)
-	c.Check(err, NotNil)
-	state = fbState{LastInboxUpdate: "2014-08-25T18:39:33+0000", LastUpdate: "today"}
-	state.persist(32)
-	_, err = stateFromStorage(32)
-	c.Check(err, NotNil)
-}
-
-func (s *S) TestNew(c *C) {
-	state := fbState{LastInboxUpdate: "2014-08-25T18:39:32+0000", LastUpdate: "2014-08-25T18:39:33+0000"}
-	state.persist(32)
-	p := New(32)
-	fb := p.(*fbPlugin)
-	c.Check(fb.state, DeepEquals, state)
-	// with bad format
-	state = fbState{LastInboxUpdate: "hola", LastUpdate: "mundo"}
-	state.persist(32)
-	p = New(32)
-	fb = p.(*fbPlugin)
-	c.Check(fb.state, DeepEquals, state)
-}
-
-func (s *S) TestApplicationId(c *C) {
-	expected := plugins.ApplicationId("com.ubuntu.developer.webapps.webapp-facebook_webapp-facebook")
-	p := New(32)
-	c.Check(p.ApplicationId(), Equals, expected)
-}
-
-func (s *S) TestThreadIsValid(c *C) {
-	t := thread{}
-	t.Unseen = 1
-	t.Unread = 2
-	// 10m before Now, the thread should be valid
-	t.UpdatedTime = timeStamp(time.Now().Add(-10 * time.Minute).Format(facebookTime))
-	tStamp := timeStamp(time.Now().Add(-20 * time.Minute).Format(facebookTime))
-	c.Check(t.isValid(tStamp), Equals, true)
-	// 2m before Now, the thread should be invalid
-	t.UpdatedTime = timeStamp(time.Now().Add(-2 * time.Minute).Format(facebookTime))
-	c.Check(t.isValid(tStamp), Equals, false)
-	// unseen = 0
-	t.Unseen = 0
-	t.UpdatedTime = timeStamp(time.Now().Add(-10 * time.Minute).Format(facebookTime))
-	c.Check(t.isValid(tStamp), Equals, false)
-	// unread = 0, unseen = 1
-	t.Unread = 0
-	t.Unseen = 1
-	c.Check(t.isValid(tStamp), Equals, false)
-}
-
-func (s *S) TestGetInbox(c *C) {
-	doRequest = func(a *accounts.AuthData, url string) (*http.Response, error) {
-		return &http.Response{
-			StatusCode: http.StatusOK,
-			Body:       closeWrapper{bytes.NewReader([]byte(inboxBody))},
-		}, nil
-	}
-	var state fbState
-	authData := accounts.AuthData{}
-	authData.AccessToken = "foo"
-	p := &fbPlugin{state: state, accountId: 32}
-	batch, err := p.getInbox(&authData)
-	c.Assert(err, IsNil)
-	c.Assert(batch, NotNil)
-	msgs := batch.Messages
-	c.Check(msgs, HasLen, 3)
-}
-
-func (s *S) TestGetInboxRequestFails(c *C) {
-	doRequest = func(a *accounts.AuthData, url string) (*http.Response, error) {
-		return &http.Response{
-			StatusCode: http.StatusBadRequest,
-			Body:       closeWrapper{bytes.NewReader([]byte(""))},
-		}, fmt.Errorf("please, fail")
-	}
-	var state fbState
-	authData := accounts.AuthData{}
-	authData.AccessToken = "foo"
-	p := &fbPlugin{state: state, accountId: 32}
-	_, err := p.getInbox(&authData)
-	c.Check(err, NotNil)
-}
-
-func (s *S) TestGetInboxParseResponseFails(c *C) {
-	doRequest = func(a *accounts.AuthData, url string) (*http.Response, error) {
-		return &http.Response{
-			StatusCode: http.StatusOK,
-			Body:       closeWrapper{bytes.NewReader([]byte("hola" + inboxBody))},
-		}, nil
-	}
-	var state fbState
-	authData := accounts.AuthData{}
-	authData.AccessToken = "foo"
-	p := &fbPlugin{state: state, accountId: 32}
-	_, err := p.getInbox(&authData)
-	c.Check(err, NotNil)
-}
-
-func (s *S) TestGetNotifications(c *C) {
-	doRequest = func(a *accounts.AuthData, url string) (*http.Response, error) {
-		return &http.Response{
-			StatusCode: http.StatusOK,
-			Body:       closeWrapper{bytes.NewReader([]byte(notificationsBody))},
-		}, nil
-	}
-	var state fbState
-	authData := accounts.AuthData{}
-	authData.AccessToken = "foo"
-	p := &fbPlugin{state: state, accountId: 32}
-	batch, err := p.getNotifications(&authData)
-	c.Assert(err, IsNil)
-	c.Assert(batch, NotNil)
-	msgs := batch.Messages
-	c.Check(msgs, HasLen, 2)
-}
-
-func (s *S) TestGetNotificationsRequestFails(c *C) {
-	doRequest = func(a *accounts.AuthData, url string) (*http.Response, error) {
-		return &http.Response{
-			StatusCode: http.StatusBadRequest,
-			Body:       closeWrapper{bytes.NewReader([]byte(""))},
-		}, fmt.Errorf("please, fail")
-	}
-	var state fbState
-	authData := accounts.AuthData{}
-	authData.AccessToken = "foo"
-	p := &fbPlugin{state: state, accountId: 32}
-	_, err := p.getNotifications(&authData)
-	c.Check(err, NotNil)
-}
-
-func (s *S) TestGetNotificationsParseResponseFails(c *C) {
-	doRequest = func(a *accounts.AuthData, url string) (*http.Response, error) {
-		return &http.Response{
-			StatusCode: http.StatusOK,
-			Body:       closeWrapper{bytes.NewReader([]byte("hola" + notificationsBody))},
-		}, nil
-	}
-	var state fbState
-	authData := accounts.AuthData{}
-	authData.AccessToken = "foo"
-	p := &fbPlugin{state: state, accountId: 32}
-	_, err := p.getNotifications(&authData)
-	c.Check(err, NotNil)
-}
-
-func (s *S) TestPoll(c *C) {
-	doRequest = func(a *accounts.AuthData, url string) (*http.Response, error) {
-		body := inboxBody
-		if url == "me/notifications" {
-			body = notificationsBody
-		}
-		return &http.Response{
-			StatusCode: http.StatusOK,
-			Body:       closeWrapper{bytes.NewReader([]byte(body))},
-		}, nil
-	}
-	var state fbState
-	authData := accounts.AuthData{}
-	authData.AccessToken = "foo"
-	p := &fbPlugin{state: state, accountId: 32}
-	batches, err := p.Poll(&authData)
-	c.Assert(err, IsNil)
-	c.Assert(batches, NotNil)
-	c.Assert(batches, HasLen, 2)
-	c.Assert(batches[0], NotNil)
-	c.Assert(batches[1], NotNil)
-	c.Check(batches[0].Tag, Equals, "notification")
-	c.Check(batches[0].Messages, HasLen, 2)
-	c.Check(batches[1].Tag, Equals, "inbox")
-	c.Check(batches[1].Messages, HasLen, 3)
-}
-
-func (s *S) TestPollSingleError(c *C) {
-	doRequest = func(a *accounts.AuthData, url string) (*http.Response, error) {
-		body := inboxBody
-		if url == "me/notifications" {
-			body = "hola" + notificationsBody
-		}
-		return &http.Response{
-			StatusCode: http.StatusOK,
-			Body:       closeWrapper{bytes.NewReader([]byte(body))},
-		}, nil
-	}
-	var state fbState
-	authData := accounts.AuthData{}
-	authData.AccessToken = "foo"
-	p := &fbPlugin{state: state, accountId: 32}
-	batches, err := p.Poll(&authData)
-	c.Assert(err, IsNil)
-	c.Assert(batches, HasLen, 1)
-	c.Assert(batches[0], NotNil)
-	c.Check(batches[0].Messages, HasLen, 3)
-}
-
-func (s *S) TestPollError(c *C) {
-	doRequest = func(a *accounts.AuthData, url string) (*http.Response, error) {
-		body := "hola" + inboxBody
-		if url == "me/notifications" {
-			body = "hola" + notificationsBody
-		}
-		return &http.Response{
-			StatusCode: http.StatusOK,
-			Body:       closeWrapper{bytes.NewReader([]byte(body))},
-		}, nil
-	}
-	var state fbState
-	authData := accounts.AuthData{}
-	authData.AccessToken = "foo"
-	p := &fbPlugin{state: state, accountId: 32}
-	_, err := p.Poll(&authData)
-	c.Check(err, NotNil)
-}
-
-func (s *S) TestPollUseEnvToken(c *C) {
-	doRequest = func(a *accounts.AuthData, url string) (*http.Response, error) {
-		c.Check(a.AccessToken, Equals, "bar")
-		return nil, fmt.Errorf("please, fail")
-	}
-	var state fbState
-	authData := accounts.AuthData{}
-	authData.AccessToken = "foo"
-	os.Setenv("ACCOUNT_POLLD_TOKEN_FACEBOOK", "bar")
-	// defer the unset
-	defer os.Setenv("ACCOUNT_POLLD_TOKEN_FACEBOOK", "")
-	p := &fbPlugin{state: state, accountId: 32}
-	_, err := p.Poll(&authData)
-	c.Check(err, NotNil)
-}
-
-func (s *S) TestRequest(c *C) {
-	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		fmt.Fprintln(w, "Hello, client")
-	}))
-	defer ts.Close()
-	baseUrl, _ = url.Parse(ts.URL)
-	authData := accounts.AuthData{}
-	authData.AccessToken = "foo"
-	_, err := request(&authData, "me/notifications")
-	c.Check(err, IsNil)
-}