Merge lp:~mardy/account-plugins/use-new-api into lp:account-plugins

Proposed by Alberto Mardegan
Status: Merged
Approved by: Víctor R. Ruiz
Approved revision: 54
Merged at revision: 56
Proposed branch: lp:~mardy/account-plugins/use-new-api
Merge into: lp:account-plugins
Diff against target: 16 lines (+1/-3)
1 file modified
tools/account-console (+1/-3)
To merge this branch: bzr merge lp:~mardy/account-plugins/use-new-api
Reviewer Review Type Date Requested Status
Víctor R. Ruiz (community) Approve
jenkins (community) continuous-integration Needs Fixing
Alvaro Lopez Ortega Pending
David King Pending
Review via email: mp+116198@code.launchpad.net

Description of the change

Use new API to get credentials ID

This fixes a crash, actually :-)

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Looks fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tools/account-console'
--- tools/account-console 2012-03-13 12:30:06 +0000
+++ tools/account-console 2012-07-23 06:33:20 +0000
@@ -165,11 +165,9 @@
165 print >> sys.stderr, 'Service "%s" not found' % args.service165 print >> sys.stderr, 'Service "%s" not found' % args.service
166 sys.exit(1)166 sys.exit(1)
167167
168 # get the signon identity
169 identity = account.get_int(args.signon_id_field)
170
171 account_service = Accounts.AccountService.new(account, service)168 account_service = Accounts.AccountService.new(account, service)
172 auth_data = account_service.get_auth_data()169 auth_data = account_service.get_auth_data()
170 identity = auth_data.get_credentials_id()
173 method = auth_data.get_method()171 method = auth_data.get_method()
174 mechanism = auth_data.get_mechanism()172 mechanism = auth_data.get_mechanism()
175 session_data = auth_data.get_parameters()173 session_data = auth_data.get_parameters()

Subscribers

People subscribed via source and target branches