Code review comment for lp:~marcustomlinson/unity8/lp-1356410

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

> Have a look at the other onGotoScope implementation, calling
> root.favoriteSelected(scopeId); is not correct

Ok, I get what you're saying -there is some method to my madness I promise ;)

My intention is to achieve a logical animation back to the dash. What I do now is close the temp scope, switch back to the favourites tab, then redirect the gotoScope to the root's implementation (which in turn animates the opening of the favourited scope from there). I feel this looks quite clean.

« Back to merge proposal