Code review comment for lp:~marcustomlinson/unity-scopes-shell/oa_loading_bar

Revision history for this message
Paweł Stołowski (stolowski) wrote :

> > 36 if (status.service_enabled)
> > 37 {
> > 38 - service_enabled = true;
> > 39 - break;
> > 40 + return true;
> > 41 }
> >
> > Just "return status.service_enabled" ?
>
> That if statement is within a loop over all accounts. So default is false, the
> if one is enabled return true

Ah, ok, that wasn't obvious from the diff. Looks good now, thanks!

« Back to merge proposal