Code review comment for lp:~marcustomlinson/unity-scopes-shell/lp-1567429

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

> Looks good, I think it will improve the perceived performance of Settings page
> quite a bit already. I yet need to check the silo and how it impacts search.
>
> I think there is one other potential improvement we could make though: make
> the call to m_scopeProxy->child_scopes() non-blocking. I think currently since
> it blocks the main thread we may see the loading bar animation struggling
> during search. What do you think about starting the call in a separate thread
> and *only* waiting for the call to finish when the settings are actually
> accessed/needed (e.g. in call to data() if there is no better place)?

Good point. Ok I've moved the child scopes update to a background thread, expected to complete upon a call to settings()

« Back to merge proposal