Code review comment for lp:~marcustomlinson/unity-scopes-api/scope_process_lifetime

Revision history for this message
Michal Hruby (mhr3) wrote :

I can confirm what Pawel is saying, there's still some weirdness going on, namely:

1) scoperunners don't terminate after receiving SIGTERM
2) I do not see the log line "RegistryObject::ScopeProcess::on_process_death(): ..." after sending the scoperunner process SIGKILL.
3) After sending SIGKILL I still see the process in ps list as a zombie (ie waitpid not called)
4) Sending a request after sending SIGKILL to scoperunner doesn't restart the scope (although I guess that's because the registry doesn't realize it's dead (see 2)). Is that supposed to work with this branch?

review: Needs Fixing

« Back to merge proposal