Code review comment for lp:~marcustomlinson/unity-scopes-api/scope_debug_mode

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

> 940 +bool ZmqScope::debug_mode()
> 941 +{
> 942 + // We only need to retrieve the debug mode state once, so we
> cache it in debug_mode_
> 943 + if (!debug_mode_)
>
> This looks racy to me. The thread that calls debug_mode() isn't the
> necessarily the same one each time, is it?

K, fixed.

« Back to merge proposal