Merge lp:~marcustomlinson/unity-scopes-api/revert_debug_timeout_config_params into lp:unity-scopes-api/devel
- revert_debug_timeout_config_params
- Merge into devel
Proposed by
Marcus Tomlinson
Status: | Merged |
---|---|
Approved by: | Paweł Stołowski |
Approved revision: | 607 |
Merged at revision: | 607 |
Proposed branch: | lp:~marcustomlinson/unity-scopes-api/revert_debug_timeout_config_params |
Merge into: | lp:unity-scopes-api/devel |
Diff against target: |
422 lines (+23/-99) 14 files modified
CMakeLists.txt (+1/-1) CONFIGFILES (+0/-18) RELEASE_NOTES.md (+0/-5) debian/changelog (+0/-7) debian/libunity-scopes3.symbols (+0/-1) include/unity/scopes/internal/DfltConfig.h.in (+7/-9) include/unity/scopes/internal/RegistryConfig.h (+0/-2) include/unity/scopes/internal/zmq_middleware/ZmqConfig.h (+0/-2) include/unity/scopes/internal/zmq_middleware/ZmqMiddleware.h (+0/-2) scoperegistry/scoperegistry.cpp (+11/-15) src/scopes/internal/RegistryConfig.cpp (+1/-13) src/scopes/internal/zmq_middleware/ZmqConfig.cpp (+0/-13) src/scopes/internal/zmq_middleware/ZmqMiddleware.cpp (+0/-6) src/scopes/internal/zmq_middleware/ZmqScope.cpp (+3/-5) |
To merge this branch: | bzr merge lp:~marcustomlinson/unity-scopes-api/revert_debug_timeout_config_params |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paweł Stołowski (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+263499@code.launchpad.net |
Commit message
Reverted Debug.Process.
Description of the change
To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'CMakeLists.txt' | |||
2 | --- CMakeLists.txt 2015-06-29 10:26:01 +0000 | |||
3 | +++ CMakeLists.txt 2015-07-01 11:05:00 +0000 | |||
4 | @@ -218,7 +218,7 @@ | |||
5 | 218 | # API version | 218 | # API version |
6 | 219 | set(UNITY_SCOPES_MAJOR 0) | 219 | set(UNITY_SCOPES_MAJOR 0) |
7 | 220 | set(UNITY_SCOPES_MINOR 6) | 220 | set(UNITY_SCOPES_MINOR 6) |
9 | 221 | set(UNITY_SCOPES_MICRO 20) | 221 | set(UNITY_SCOPES_MICRO 19) |
10 | 222 | set(UNITY_SCOPES_SOVERSION 3) | 222 | set(UNITY_SCOPES_SOVERSION 3) |
11 | 223 | 223 | ||
12 | 224 | # Version for testing, with all symbols visible | 224 | # Version for testing, with all symbols visible |
13 | 225 | 225 | ||
14 | === modified file 'CONFIGFILES' | |||
15 | --- CONFIGFILES 2015-06-29 12:58:18 +0000 | |||
16 | +++ CONFIGFILES 2015-07-01 11:05:00 +0000 | |||
17 | @@ -226,15 +226,6 @@ | |||
18 | 226 | 226 | ||
19 | 227 | The default value is 5000 milliseconds. | 227 | The default value is 5000 milliseconds. |
20 | 228 | 228 | ||
21 | 229 | - Debug.Locate.Timeout | ||
22 | 230 | |||
23 | 231 | This parameter overrides the value of Locate.Timeout above when DebugMode is enabled on | ||
24 | 232 | a target scope. (See DebugMode in <scope_id>.ini for more details) | ||
25 | 233 | |||
26 | 234 | Only values in the range 10 to 120000 milliseconds are accepted. | ||
27 | 235 | |||
28 | 236 | The default value is 30000 milliseconds. | ||
29 | 237 | |||
30 | 238 | - Registry.Timeout | 229 | - Registry.Timeout |
31 | 239 | 230 | ||
32 | 240 | The timeout to be used when invoking a twoway operation on the registry other | 231 | The timeout to be used when invoking a twoway operation on the registry other |
33 | @@ -315,15 +306,6 @@ | |||
34 | 315 | config group, otherwise the middleware can prematurely conclude that | 306 | config group, otherwise the middleware can prematurely conclude that |
35 | 316 | a locate() request failed to start a scope. | 307 | a locate() request failed to start a scope. |
36 | 317 | 308 | ||
37 | 318 | - Debug.Process.Timeout | ||
38 | 319 | |||
39 | 320 | This parameter overrides the value of Process.Timeout above when DebugMode is enabled on | ||
40 | 321 | a target scope. (See DebugMode in <scope_id>.ini for more details) | ||
41 | 322 | |||
42 | 323 | Only values in the range 10 to 120000 milliseconds are accepted. | ||
43 | 324 | |||
44 | 325 | The default value is 30000 milliseconds. | ||
45 | 326 | |||
46 | 327 | 309 | ||
47 | 328 | Smartscopes.ini | 310 | Smartscopes.ini |
48 | 329 | -------------- | 311 | -------------- |
49 | 330 | 312 | ||
50 | === modified file 'RELEASE_NOTES.md' | |||
51 | --- RELEASE_NOTES.md 2015-06-29 10:26:01 +0000 | |||
52 | +++ RELEASE_NOTES.md 2015-07-01 11:05:00 +0000 | |||
53 | @@ -1,11 +1,6 @@ | |||
54 | 1 | Release notes | 1 | Release notes |
55 | 2 | ============= | 2 | ============= |
56 | 3 | 3 | ||
57 | 4 | Changes in version 0.6.20 | ||
58 | 5 | ========================= | ||
59 | 6 | - Added Debug.Process.Timeout configuration parameter to Registry.ini | ||
60 | 7 | - Added Debug.Locate.Timeout configuration parameter to Zmq.ini | ||
61 | 8 | |||
62 | 9 | Changes in version 0.6.19 | 4 | Changes in version 0.6.19 |
63 | 10 | ========================= | 5 | ========================= |
64 | 11 | - Support UNITY_SCOPES_CONFIG_DIR environment variable. | 6 | - Support UNITY_SCOPES_CONFIG_DIR environment variable. |
65 | 12 | 7 | ||
66 | === modified file 'debian/changelog' | |||
67 | --- debian/changelog 2015-06-29 10:26:01 +0000 | |||
68 | +++ debian/changelog 2015-07-01 11:05:00 +0000 | |||
69 | @@ -1,10 +1,3 @@ | |||
70 | 1 | unity-scopes-api (0.6.20-0ubuntu1) UNRELEASED; urgency=medium | ||
71 | 2 | |||
72 | 3 | * Added Debug.Process.Timeout configuration parameter to Registry.ini | ||
73 | 4 | * Added Debug.Locate.Timeout configuration parameter to Zmq.ini | ||
74 | 5 | |||
75 | 6 | -- Marcus Tomlinson <marcus.tomlinson@canonical.com> Mon, 29 Jun 2015 07:56:37 +0200 | ||
76 | 7 | |||
77 | 8 | unity-scopes-api (0.6.19+15.10.20150617.2-0ubuntu1) wily; urgency=medium | 1 | unity-scopes-api (0.6.19+15.10.20150617.2-0ubuntu1) wily; urgency=medium |
78 | 9 | 2 | ||
79 | 10 | [ Pawel Stolowski ] | 3 | [ Pawel Stolowski ] |
80 | 11 | 4 | ||
81 | === modified file 'debian/libunity-scopes3.symbols' | |||
82 | --- debian/libunity-scopes3.symbols 2015-06-29 09:04:07 +0000 | |||
83 | +++ debian/libunity-scopes3.symbols 2015-07-01 11:05:00 +0000 | |||
84 | @@ -395,7 +395,6 @@ | |||
85 | 395 | (c++)"unity::scopes::internal::MiddlewareFactory::MiddlewareFactory(unity::scopes::internal::RuntimeImpl*)@Base" 0.4.0+14.04.20140312.1 | 395 | (c++)"unity::scopes::internal::MiddlewareFactory::MiddlewareFactory(unity::scopes::internal::RuntimeImpl*)@Base" 0.4.0+14.04.20140312.1 |
86 | 396 | (c++)"unity::scopes::internal::MiddlewareFactory::to_kind(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)@Base" 0.4.0+14.04.20140312.1 | 396 | (c++)"unity::scopes::internal::MiddlewareFactory::to_kind(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)@Base" 0.4.0+14.04.20140312.1 |
87 | 397 | (c++)"unity::scopes::internal::RegistryConfig::click_installdir() const@Base" 0.4.3+14.10.20140428 | 397 | (c++)"unity::scopes::internal::RegistryConfig::click_installdir() const@Base" 0.4.3+14.10.20140428 |
88 | 398 | (c++)"unity::scopes::internal::RegistryConfig::debug_process_timeout() const@Base" 0replaceme | ||
89 | 399 | (c++)"unity::scopes::internal::RegistryConfig::identity() const@Base" 0.4.0+14.04.20140312.1 | 398 | (c++)"unity::scopes::internal::RegistryConfig::identity() const@Base" 0.4.0+14.04.20140312.1 |
90 | 400 | (c++)"unity::scopes::internal::RegistryConfig::mw_configfile() const@Base" 0.4.0+14.04.20140312.1 | 399 | (c++)"unity::scopes::internal::RegistryConfig::mw_configfile() const@Base" 0.4.0+14.04.20140312.1 |
91 | 401 | (c++)"unity::scopes::internal::RegistryConfig::mw_kind() const@Base" 0.4.0+14.04.20140312.1 | 400 | (c++)"unity::scopes::internal::RegistryConfig::mw_kind() const@Base" 0.4.0+14.04.20140312.1 |
92 | 402 | 401 | ||
93 | === modified file 'include/unity/scopes/internal/DfltConfig.h.in' | |||
94 | --- include/unity/scopes/internal/DfltConfig.h.in 2015-06-29 06:00:21 +0000 | |||
95 | +++ include/unity/scopes/internal/DfltConfig.h.in 2015-07-01 11:05:00 +0000 | |||
96 | @@ -46,15 +46,13 @@ | |||
97 | 46 | 46 | ||
98 | 47 | static constexpr char const* DFLT_SS_SCOPE_IDENTITY = "SmartScope"; | 47 | static constexpr char const* DFLT_SS_SCOPE_IDENTITY = "SmartScope"; |
99 | 48 | 48 | ||
109 | 49 | static constexpr int DFLT_REAP_EXPIRY = 45; // seconds | 49 | static constexpr int DFLT_REAP_EXPIRY = 45; // seconds |
110 | 50 | static constexpr int DFLT_REAP_INTERVAL = 10; // seconds | 50 | static constexpr int DFLT_REAP_INTERVAL = 10; // seconds |
111 | 51 | static constexpr int DFLT_PROCESS_TIMEOUT = 4000; // milliseconds | 51 | static constexpr int DFLT_PROCESS_TIMEOUT = 4000; // milliseconds |
112 | 52 | static constexpr int DFLT_DEBUG_PROCESS_TIMEOUT = 30000; // milliseconds | 52 | static constexpr int DFLT_ZMQ_TWOWAY_TIMEOUT = 500; // milliseconds |
113 | 53 | static constexpr int DFLT_ZMQ_TWOWAY_TIMEOUT = 500; // milliseconds | 53 | static constexpr int DFLT_ZMQ_LOCATE_TIMEOUT = 5000; // milliseconds |
114 | 54 | static constexpr int DFLT_ZMQ_LOCATE_TIMEOUT = 5000; // milliseconds | 54 | static constexpr int DFLT_ZMQ_REGISTRY_TIMEOUT = 5000; // milliseconds |
115 | 55 | static constexpr int DFLT_ZMQ_DEBUG_LOCATE_TIMEOUT = 30000; // milliseconds | 55 | static constexpr int DFLT_ZMQ_CHILDSCOPES_TIMEOUT = 2000; // milliseconds |
107 | 56 | static constexpr int DFLT_ZMQ_REGISTRY_TIMEOUT = 5000; // milliseconds | ||
108 | 57 | static constexpr int DFLT_ZMQ_CHILDSCOPES_TIMEOUT = 2000; // milliseconds | ||
116 | 58 | 56 | ||
117 | 59 | static constexpr char const* DFLT_HOME_CACHE_SUBDIR = ".local/share/unity-scopes"; | 57 | static constexpr char const* DFLT_HOME_CACHE_SUBDIR = ".local/share/unity-scopes"; |
118 | 60 | static constexpr char const* DFLT_HOME_APP_SUBDIR = ".local/share"; | 58 | static constexpr char const* DFLT_HOME_APP_SUBDIR = ".local/share"; |
119 | 61 | 59 | ||
120 | === modified file 'include/unity/scopes/internal/RegistryConfig.h' | |||
121 | --- include/unity/scopes/internal/RegistryConfig.h 2015-06-29 06:02:37 +0000 | |||
122 | +++ include/unity/scopes/internal/RegistryConfig.h 2015-07-01 11:05:00 +0000 | |||
123 | @@ -43,7 +43,6 @@ | |||
124 | 43 | std::string click_installdir() const; // Directory for Click scope config files | 43 | std::string click_installdir() const; // Directory for Click scope config files |
125 | 44 | std::string scoperunner_path() const; // Path to scoperunner binary | 44 | std::string scoperunner_path() const; // Path to scoperunner binary |
126 | 45 | int process_timeout() const; // Milliseconds to wait before scope is considereed non-responsive. | 45 | int process_timeout() const; // Milliseconds to wait before scope is considereed non-responsive. |
127 | 46 | int debug_process_timeout() const; // Milliseconds to wait before scope is considereed non-responsive in debug mode. | ||
128 | 47 | 46 | ||
129 | 48 | private: | 47 | private: |
130 | 49 | std::string identity_; | 48 | std::string identity_; |
131 | @@ -54,7 +53,6 @@ | |||
132 | 54 | std::string click_installdir_; | 53 | std::string click_installdir_; |
133 | 55 | std::string scoperunner_path_; | 54 | std::string scoperunner_path_; |
134 | 56 | int process_timeout_; // Milliseconds | 55 | int process_timeout_; // Milliseconds |
135 | 57 | int debug_process_timeout_; // Milliseconds | ||
136 | 58 | }; | 56 | }; |
137 | 59 | 57 | ||
138 | 60 | } // namespace internal | 58 | } // namespace internal |
139 | 61 | 59 | ||
140 | === modified file 'include/unity/scopes/internal/zmq_middleware/ZmqConfig.h' | |||
141 | --- include/unity/scopes/internal/zmq_middleware/ZmqConfig.h 2015-06-29 06:02:37 +0000 | |||
142 | +++ include/unity/scopes/internal/zmq_middleware/ZmqConfig.h 2015-07-01 11:05:00 +0000 | |||
143 | @@ -38,7 +38,6 @@ | |||
144 | 38 | std::string endpoint_dir() const; | 38 | std::string endpoint_dir() const; |
145 | 39 | int twoway_timeout() const; | 39 | int twoway_timeout() const; |
146 | 40 | int locate_timeout() const; | 40 | int locate_timeout() const; |
147 | 41 | int debug_locate_timeout() const; | ||
148 | 42 | int registry_timeout() const; | 41 | int registry_timeout() const; |
149 | 43 | int child_scopes_timeout() const; | 42 | int child_scopes_timeout() const; |
150 | 44 | std::string registry_endpoint_dir() const; | 43 | std::string registry_endpoint_dir() const; |
151 | @@ -48,7 +47,6 @@ | |||
152 | 48 | std::string endpoint_dir_; | 47 | std::string endpoint_dir_; |
153 | 49 | int twoway_timeout_; | 48 | int twoway_timeout_; |
154 | 50 | int locate_timeout_; | 49 | int locate_timeout_; |
155 | 51 | int debug_locate_timeout_; | ||
156 | 52 | int registry_timeout_; | 50 | int registry_timeout_; |
157 | 53 | int child_scopes_timeout_; | 51 | int child_scopes_timeout_; |
158 | 54 | std::string registry_endpoint_dir_; | 52 | std::string registry_endpoint_dir_; |
159 | 55 | 53 | ||
160 | === modified file 'include/unity/scopes/internal/zmq_middleware/ZmqMiddleware.h' | |||
161 | --- include/unity/scopes/internal/zmq_middleware/ZmqMiddleware.h 2015-06-29 06:08:25 +0000 | |||
162 | +++ include/unity/scopes/internal/zmq_middleware/ZmqMiddleware.h 2015-07-01 11:05:00 +0000 | |||
163 | @@ -93,7 +93,6 @@ | |||
164 | 93 | ThreadPool* oneway_pool(); | 93 | ThreadPool* oneway_pool(); |
165 | 94 | ThreadPool* twoway_pool(); | 94 | ThreadPool* twoway_pool(); |
166 | 95 | int64_t locate_timeout() const noexcept; | 95 | int64_t locate_timeout() const noexcept; |
167 | 96 | int64_t debug_locate_timeout() const noexcept; | ||
168 | 97 | int64_t registry_timeout() const noexcept; | 96 | int64_t registry_timeout() const noexcept; |
169 | 98 | int64_t child_scopes_timeout() const noexcept; | 97 | int64_t child_scopes_timeout() const noexcept; |
170 | 99 | 98 | ||
171 | @@ -139,7 +138,6 @@ | |||
172 | 139 | 138 | ||
173 | 140 | int64_t twoway_timeout_; // Default timeout for twoway invocations | 139 | int64_t twoway_timeout_; // Default timeout for twoway invocations |
174 | 141 | int64_t locate_timeout_; // Timeout for registry locate() | 140 | int64_t locate_timeout_; // Timeout for registry locate() |
175 | 142 | int64_t debug_locate_timeout_; // Timeout for registry locate() in debug mode | ||
176 | 143 | int64_t registry_timeout_; // Timeout for registry operations other than locate() | 141 | int64_t registry_timeout_; // Timeout for registry operations other than locate() |
177 | 144 | int64_t child_scopes_timeout_; // Timeout for child_scopes() and set_child_scopes() methods | 142 | int64_t child_scopes_timeout_; // Timeout for child_scopes() and set_child_scopes() methods |
178 | 145 | 143 | ||
179 | 146 | 144 | ||
180 | === modified file 'scoperegistry/scoperegistry.cpp' | |||
181 | --- scoperegistry/scoperegistry.cpp 2015-06-29 12:51:07 +0000 | |||
182 | +++ scoperegistry/scoperegistry.cpp 2015-07-01 11:05:00 +0000 | |||
183 | @@ -293,8 +293,7 @@ | |||
184 | 293 | string const& scoperunner_path, | 293 | string const& scoperunner_path, |
185 | 294 | string const& config_file, | 294 | string const& config_file, |
186 | 295 | bool click, | 295 | bool click, |
189 | 296 | int timeout_ms, | 296 | int timeout_ms) |
188 | 297 | int debug_timeout_ms) | ||
190 | 298 | { | 297 | { |
191 | 299 | unique_ptr<ScopeMetadataImpl> mi(new ScopeMetadataImpl(mw.get())); | 298 | unique_ptr<ScopeMetadataImpl> mi(new ScopeMetadataImpl(mw.get())); |
192 | 300 | string scope_config(scope.second); | 299 | string scope_config(scope.second); |
193 | @@ -424,10 +423,10 @@ | |||
194 | 424 | scope_dir.filename().native(); | 423 | scope_dir.filename().native(); |
195 | 425 | } | 424 | } |
196 | 426 | 425 | ||
198 | 427 | // Check if this scope has requested debug mode, if so, set the process timeout to debug_process_timeout | 426 | // Check if this scope has requested debug mode, if so, set the process timeout to 30s |
199 | 428 | if (sc.debug_mode()) | 427 | if (sc.debug_mode()) |
200 | 429 | { | 428 | { |
202 | 430 | exec_data.timeout_ms = debug_timeout_ms; | 429 | exec_data.timeout_ms = 30000; |
203 | 431 | } | 430 | } |
204 | 432 | else | 431 | else |
205 | 433 | { | 432 | { |
206 | @@ -480,14 +479,13 @@ | |||
207 | 480 | string const& scoperunner_path, | 479 | string const& scoperunner_path, |
208 | 481 | string const& config_file, | 480 | string const& config_file, |
209 | 482 | bool click, | 481 | bool click, |
212 | 483 | int timeout_ms, | 482 | int timeout_ms) |
211 | 484 | int debug_timeout_ms) | ||
213 | 485 | { | 483 | { |
214 | 486 | for (auto&& pair : all_scopes) | 484 | for (auto&& pair : all_scopes) |
215 | 487 | { | 485 | { |
216 | 488 | try | 486 | try |
217 | 489 | { | 487 | { |
219 | 490 | add_local_scope(registry, pair, mw, scoperunner_path, config_file, click, timeout_ms, debug_timeout_ms); | 488 | add_local_scope(registry, pair, mw, scoperunner_path, config_file, click, timeout_ms); |
220 | 491 | } | 489 | } |
221 | 492 | catch (unity::Exception const& e) | 490 | catch (unity::Exception const& e) |
222 | 493 | { | 491 | { |
223 | @@ -557,7 +555,6 @@ | |||
224 | 557 | string click_installdir; | 555 | string click_installdir; |
225 | 558 | string scoperunner_path; | 556 | string scoperunner_path; |
226 | 559 | int process_timeout; | 557 | int process_timeout; |
227 | 560 | int debug_process_timeout; | ||
228 | 561 | { | 558 | { |
229 | 562 | RegistryConfig c(identity, runtime->registry_configfile()); | 559 | RegistryConfig c(identity, runtime->registry_configfile()); |
230 | 563 | mw_kind = c.mw_kind(); | 560 | mw_kind = c.mw_kind(); |
231 | @@ -566,7 +563,6 @@ | |||
232 | 566 | click_installdir = c.click_installdir(); | 563 | click_installdir = c.click_installdir(); |
233 | 567 | scoperunner_path = c.scoperunner_path(); | 564 | scoperunner_path = c.scoperunner_path(); |
234 | 568 | process_timeout = c.process_timeout(); | 565 | process_timeout = c.process_timeout(); |
235 | 569 | debug_process_timeout = c.debug_process_timeout(); | ||
236 | 570 | } // Release memory for config parser | 566 | } // Release memory for config parser |
237 | 571 | 567 | ||
238 | 572 | // Inform the signal thread that it should shutdown the runtime | 568 | // Inform the signal thread that it should shutdown the runtime |
239 | @@ -607,8 +603,8 @@ | |||
240 | 607 | local_scopes[scope_id] = argv[i]; // operator[] overwrites pre-existing entries | 603 | local_scopes[scope_id] = argv[i]; // operator[] overwrites pre-existing entries |
241 | 608 | } | 604 | } |
242 | 609 | 605 | ||
245 | 610 | add_local_scopes(registry, local_scopes, middleware, scoperunner_path, config_file, false, process_timeout, debug_process_timeout); | 606 | add_local_scopes(registry, local_scopes, middleware, scoperunner_path, config_file, false, process_timeout); |
246 | 611 | add_local_scopes(registry, click_scopes, middleware, scoperunner_path, config_file, true, process_timeout, debug_process_timeout); | 607 | add_local_scopes(registry, click_scopes, middleware, scoperunner_path, config_file, true, process_timeout); |
247 | 612 | if (ss_reg_id.empty()) | 608 | if (ss_reg_id.empty()) |
248 | 613 | { | 609 | { |
249 | 614 | error("no remote registry configured, only local scopes will be available"); | 610 | error("no remote registry configured, only local scopes will be available"); |
250 | @@ -619,12 +615,12 @@ | |||
251 | 619 | } | 615 | } |
252 | 620 | 616 | ||
253 | 621 | // Configure watches for scope install directories | 617 | // Configure watches for scope install directories |
255 | 622 | auto local_watch_lambda = [registry, &middleware, &scoperunner_path, &config_file, process_timeout, debug_process_timeout] | 618 | auto local_watch_lambda = [registry, &middleware, &scoperunner_path, &config_file, process_timeout] |
256 | 623 | (pair<string, string> const& scope) | 619 | (pair<string, string> const& scope) |
257 | 624 | { | 620 | { |
258 | 625 | try | 621 | try |
259 | 626 | { | 622 | { |
261 | 627 | add_local_scope(registry, scope, middleware, scoperunner_path, config_file, false, process_timeout, debug_process_timeout); | 623 | add_local_scope(registry, scope, middleware, scoperunner_path, config_file, false, process_timeout); |
262 | 628 | } | 624 | } |
263 | 629 | catch (unity::Exception const& e) | 625 | catch (unity::Exception const& e) |
264 | 630 | { | 626 | { |
265 | @@ -635,12 +631,12 @@ | |||
266 | 635 | local_scopes_watcher.add_install_dir(scope_installdir); | 631 | local_scopes_watcher.add_install_dir(scope_installdir); |
267 | 636 | local_scopes_watcher.add_install_dir(oem_installdir); | 632 | local_scopes_watcher.add_install_dir(oem_installdir); |
268 | 637 | 633 | ||
270 | 638 | auto click_watch_lambda = [registry, &middleware, &scoperunner_path, &config_file, process_timeout, debug_process_timeout] | 634 | auto click_watch_lambda = [registry, &middleware, &scoperunner_path, &config_file, process_timeout] |
271 | 639 | (pair<string, string> const& scope) | 635 | (pair<string, string> const& scope) |
272 | 640 | { | 636 | { |
273 | 641 | try | 637 | try |
274 | 642 | { | 638 | { |
276 | 643 | add_local_scope(registry, scope, middleware, scoperunner_path, config_file, true, process_timeout, debug_process_timeout); | 639 | add_local_scope(registry, scope, middleware, scoperunner_path, config_file, true, process_timeout); |
277 | 644 | } | 640 | } |
278 | 645 | catch (unity::Exception const& e) | 641 | catch (unity::Exception const& e) |
279 | 646 | { | 642 | { |
280 | 647 | 643 | ||
281 | === modified file 'src/scopes/internal/RegistryConfig.cpp' | |||
282 | --- src/scopes/internal/RegistryConfig.cpp 2015-06-29 15:07:42 +0000 | |||
283 | +++ src/scopes/internal/RegistryConfig.cpp 2015-07-01 11:05:00 +0000 | |||
284 | @@ -45,7 +45,6 @@ | |||
285 | 45 | const string click_installdir_key = "Click.InstallDir"; | 45 | const string click_installdir_key = "Click.InstallDir"; |
286 | 46 | const string scoperunner_path_key = "Scoperunner.Path"; | 46 | const string scoperunner_path_key = "Scoperunner.Path"; |
287 | 47 | const string process_timeout_key = "Process.Timeout"; | 47 | const string process_timeout_key = "Process.Timeout"; |
288 | 48 | const string debug_process_timeout_key = "Debug.Process.Timeout"; | ||
289 | 49 | } | 48 | } |
290 | 50 | 49 | ||
291 | 51 | RegistryConfig::RegistryConfig(string const& identity, string const& configfile) : | 50 | RegistryConfig::RegistryConfig(string const& identity, string const& configfile) : |
292 | @@ -80,11 +79,6 @@ | |||
293 | 80 | { | 79 | { |
294 | 81 | throw_ex("Illegal value (" + to_string(process_timeout_) + ") for " + process_timeout_key + ": value must be 10-15000 ms"); | 80 | throw_ex("Illegal value (" + to_string(process_timeout_) + ") for " + process_timeout_key + ": value must be 10-15000 ms"); |
295 | 82 | } | 81 | } |
296 | 83 | debug_process_timeout_ = get_optional_int(registry_config_group, debug_process_timeout_key, DFLT_DEBUG_PROCESS_TIMEOUT); | ||
297 | 84 | if (debug_process_timeout_ < 10 || debug_process_timeout_ > 120000) | ||
298 | 85 | { | ||
299 | 86 | throw_ex("Illegal value (" + to_string(debug_process_timeout_) + ") for " + debug_process_timeout_key + ": value must be 10-120000 ms"); | ||
300 | 87 | } | ||
301 | 88 | 82 | ||
302 | 89 | KnownEntries const known_entries = { | 83 | KnownEntries const known_entries = { |
303 | 90 | { registry_config_group, | 84 | { registry_config_group, |
304 | @@ -95,8 +89,7 @@ | |||
305 | 95 | oem_installdir_key, | 89 | oem_installdir_key, |
306 | 96 | click_installdir_key, | 90 | click_installdir_key, |
307 | 97 | scoperunner_path_key, | 91 | scoperunner_path_key, |
310 | 98 | process_timeout_key, | 92 | process_timeout_key |
309 | 99 | debug_process_timeout_key | ||
311 | 100 | } | 93 | } |
312 | 101 | } | 94 | } |
313 | 102 | }; | 95 | }; |
314 | @@ -147,11 +140,6 @@ | |||
315 | 147 | return process_timeout_; | 140 | return process_timeout_; |
316 | 148 | } | 141 | } |
317 | 149 | 142 | ||
318 | 150 | int RegistryConfig::debug_process_timeout() const | ||
319 | 151 | { | ||
320 | 152 | return debug_process_timeout_; | ||
321 | 153 | } | ||
322 | 154 | |||
323 | 155 | } // namespace internal | 143 | } // namespace internal |
324 | 156 | 144 | ||
325 | 157 | } // namespace scopes | 145 | } // namespace scopes |
326 | 158 | 146 | ||
327 | === modified file 'src/scopes/internal/zmq_middleware/ZmqConfig.cpp' | |||
328 | --- src/scopes/internal/zmq_middleware/ZmqConfig.cpp 2015-06-29 15:09:24 +0000 | |||
329 | +++ src/scopes/internal/zmq_middleware/ZmqConfig.cpp 2015-07-01 11:05:00 +0000 | |||
330 | @@ -41,7 +41,6 @@ | |||
331 | 41 | const string endpoint_dir_key = "EndpointDir"; | 41 | const string endpoint_dir_key = "EndpointDir"; |
332 | 42 | const string twoway_timeout_key = "Default.Twoway.Timeout"; | 42 | const string twoway_timeout_key = "Default.Twoway.Timeout"; |
333 | 43 | const string locate_timeout_key = "Locate.Timeout"; | 43 | const string locate_timeout_key = "Locate.Timeout"; |
334 | 44 | const string debug_locate_timeout_key = "Debug.Locate.Timeout"; | ||
335 | 45 | const string registry_timeout_key = "Registry.Timeout"; | 44 | const string registry_timeout_key = "Registry.Timeout"; |
336 | 46 | const string child_scopes_timeout_key = "ChildScopes.Timeout"; | 45 | const string child_scopes_timeout_key = "ChildScopes.Timeout"; |
337 | 47 | const string registry_endpoint_dir_key = "Registry.EndpointDir"; | 46 | const string registry_endpoint_dir_key = "Registry.EndpointDir"; |
338 | @@ -92,12 +91,6 @@ | |||
339 | 92 | throw_ex("Illegal value (" + to_string(locate_timeout_) + ") for " + locate_timeout_key + ": value must be 10-15000"); | 91 | throw_ex("Illegal value (" + to_string(locate_timeout_) + ") for " + locate_timeout_key + ": value must be 10-15000"); |
340 | 93 | } | 92 | } |
341 | 94 | 93 | ||
342 | 95 | debug_locate_timeout_ = get_optional_int(zmq_config_group, debug_locate_timeout_key, DFLT_ZMQ_DEBUG_LOCATE_TIMEOUT); | ||
343 | 96 | if (debug_locate_timeout_ < 10 || debug_locate_timeout_ > 120000) | ||
344 | 97 | { | ||
345 | 98 | throw_ex("Illegal value (" + to_string(debug_locate_timeout_) + ") for " + debug_locate_timeout_key + ": value must be 10-120000"); | ||
346 | 99 | } | ||
347 | 100 | |||
348 | 101 | child_scopes_timeout_ = get_optional_int(zmq_config_group, child_scopes_timeout_key, DFLT_ZMQ_CHILDSCOPES_TIMEOUT); | 94 | child_scopes_timeout_ = get_optional_int(zmq_config_group, child_scopes_timeout_key, DFLT_ZMQ_CHILDSCOPES_TIMEOUT); |
349 | 102 | if (child_scopes_timeout_ < 10 || child_scopes_timeout_ > 15000) | 95 | if (child_scopes_timeout_ < 10 || child_scopes_timeout_ > 15000) |
350 | 103 | { | 96 | { |
351 | @@ -113,7 +106,6 @@ | |||
352 | 113 | endpoint_dir_key, | 106 | endpoint_dir_key, |
353 | 114 | twoway_timeout_key, | 107 | twoway_timeout_key, |
354 | 115 | locate_timeout_key, | 108 | locate_timeout_key, |
355 | 116 | debug_locate_timeout_key, | ||
356 | 117 | registry_timeout_key, | 109 | registry_timeout_key, |
357 | 118 | child_scopes_timeout_key, | 110 | child_scopes_timeout_key, |
358 | 119 | registry_endpoint_dir_key, | 111 | registry_endpoint_dir_key, |
359 | @@ -143,11 +135,6 @@ | |||
360 | 143 | return locate_timeout_; | 135 | return locate_timeout_; |
361 | 144 | } | 136 | } |
362 | 145 | 137 | ||
363 | 146 | int ZmqConfig::debug_locate_timeout() const | ||
364 | 147 | { | ||
365 | 148 | return debug_locate_timeout_; | ||
366 | 149 | } | ||
367 | 150 | |||
368 | 151 | int ZmqConfig::registry_timeout() const | 138 | int ZmqConfig::registry_timeout() const |
369 | 152 | { | 139 | { |
370 | 153 | return registry_timeout_; | 140 | return registry_timeout_; |
371 | 154 | 141 | ||
372 | === modified file 'src/scopes/internal/zmq_middleware/ZmqMiddleware.cpp' | |||
373 | --- src/scopes/internal/zmq_middleware/ZmqMiddleware.cpp 2015-06-29 06:11:47 +0000 | |||
374 | +++ src/scopes/internal/zmq_middleware/ZmqMiddleware.cpp 2015-07-01 11:05:00 +0000 | |||
375 | @@ -106,7 +106,6 @@ | |||
376 | 106 | 106 | ||
377 | 107 | twoway_timeout_ = config.twoway_timeout(); | 107 | twoway_timeout_ = config.twoway_timeout(); |
378 | 108 | locate_timeout_ = config.locate_timeout(); | 108 | locate_timeout_ = config.locate_timeout(); |
379 | 109 | debug_locate_timeout_ = config.debug_locate_timeout(); | ||
380 | 110 | registry_timeout_ = config.registry_timeout(); | 109 | registry_timeout_ = config.registry_timeout(); |
381 | 111 | child_scopes_timeout_ = config.child_scopes_timeout(); | 110 | child_scopes_timeout_ = config.child_scopes_timeout(); |
382 | 112 | public_endpoint_dir_ = config.endpoint_dir(); | 111 | public_endpoint_dir_ = config.endpoint_dir(); |
383 | @@ -811,11 +810,6 @@ | |||
384 | 811 | return locate_timeout_; | 810 | return locate_timeout_; |
385 | 812 | } | 811 | } |
386 | 813 | 812 | ||
387 | 814 | int64_t ZmqMiddleware::debug_locate_timeout() const noexcept | ||
388 | 815 | { | ||
389 | 816 | return debug_locate_timeout_; | ||
390 | 817 | } | ||
391 | 818 | |||
392 | 819 | int64_t ZmqMiddleware::registry_timeout() const noexcept | 813 | int64_t ZmqMiddleware::registry_timeout() const noexcept |
393 | 820 | { | 814 | { |
394 | 821 | return registry_timeout_; | 815 | return registry_timeout_; |
395 | 822 | 816 | ||
396 | === modified file 'src/scopes/internal/zmq_middleware/ZmqScope.cpp' | |||
397 | --- src/scopes/internal/zmq_middleware/ZmqScope.cpp 2015-06-29 06:13:53 +0000 | |||
398 | +++ src/scopes/internal/zmq_middleware/ZmqScope.cpp 2015-07-01 11:05:00 +0000 | |||
399 | @@ -325,8 +325,7 @@ | |||
400 | 325 | capnp::MallocMessageBuilder request_builder; | 325 | capnp::MallocMessageBuilder request_builder; |
401 | 326 | make_request_(request_builder, "debug_mode"); | 326 | make_request_(request_builder, "debug_mode"); |
402 | 327 | 327 | ||
405 | 328 | int64_t timeout = mw_base()->debug_locate_timeout(); | 328 | auto future = mw_base()->twoway_pool()->submit([&] { return this->invoke_twoway_(request_builder, -1, 30000); }); |
404 | 329 | auto future = mw_base()->twoway_pool()->submit([&] { return this->invoke_twoway_(request_builder, -1, timeout); }); | ||
406 | 330 | auto out_params = future.get(); | 329 | auto out_params = future.get(); |
407 | 331 | auto response = out_params.reader->getRoot<capnproto::Response>(); | 330 | auto response = out_params.reader->getRoot<capnproto::Response>(); |
408 | 332 | throw_if_runtime_exception(response); | 331 | throw_if_runtime_exception(response); |
409 | @@ -346,11 +345,10 @@ | |||
410 | 346 | ZmqObjectProxy::TwowayOutParams ZmqScope::invoke_scope_(capnp::MessageBuilder& in_params, int64_t timeout) | 345 | ZmqObjectProxy::TwowayOutParams ZmqScope::invoke_scope_(capnp::MessageBuilder& in_params, int64_t timeout) |
411 | 347 | { | 346 | { |
412 | 348 | // Check if this scope has requested debug mode, if so, disable two-way timeout and set | 347 | // Check if this scope has requested debug mode, if so, disable two-way timeout and set |
414 | 349 | // locate timeout to debug_locate_timeout. | 348 | // locate timeout to 30s. |
415 | 350 | if (debug_mode()) | 349 | if (debug_mode()) |
416 | 351 | { | 350 | { |
419 | 352 | int64_t timeout = mw_base()->debug_locate_timeout(); | 351 | return this->invoke_twoway_(in_params, -1, 30000); |
418 | 353 | return this->invoke_twoway_(in_params, -1, timeout); | ||
420 | 354 | } | 352 | } |
421 | 355 | return this->invoke_twoway_(in_params, timeout); | 353 | return this->invoke_twoway_(in_params, timeout); |
422 | 356 | } | 354 | } |
PASSED: Continuous integration, rev:607 jenkins. qa.ubuntu. com/job/ unity-scopes- api-devel- ci/1484/ jenkins. qa.ubuntu. com/job/ unity-scopes- api-devel- wily-amd64- ci/25 jenkins. qa.ubuntu. com/job/ unity-scopes- api-devel- wily-armhf- ci/25 jenkins. qa.ubuntu. com/job/ unity-scopes- api-devel- wily-armhf- ci/25/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity-scopes- api-devel- wily-i386- ci/25
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity- scopes- api-devel- ci/1484/ rebuild
http://