Code review comment for lp:~marcustomlinson/unity-scopes-api/reg_file_system_monitor

Revision history for this message
Michi Henning (michihenning) wrote :

> Strictly speaking, as long as the new method is appended to the vtable (which
> it is), it is ABI compatible, cause users of the lib always get the instance
> from the lib itself.

We can't rely on that because the standard doesn't even know about the existence of a vtbl. For all we know, the compiler sorts the vtbl alphabetically by method name… It might happen to work for gcc, if gcc happens to preserve the order in which methods are declared in the vtbl, and the new method is appended to all the others. But that's not something we should rely on.

« Back to merge proposal