Code review comment for lp:~marcustomlinson/unity-scopes-api/lp-1410125

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

>
> > Maybe a new version of JsonCpp? My version is "0.6.0~rc2-3.1ubuntu1".
>
> Same here, and that's what's also on Jenkins. Weird.
>
> Maybe the best fix would be to not test the full exception string, seeing that
> the text of the exception comes from the underlying library. One option would
> be to just expect a ResourceException for the failing test.

That exception is ours, not from the underlying library. If you can get the test to fail like it does on my machine, you too will be confused as to why it passed before :/

I recently did a update + dist-upgrade. It really feels like a dependancy has changed, and the only one I can think of is libjsoncpp.

« Back to merge proposal