Code review comment for lp:~marcustomlinson/unity-scopes-api/loop-prevention

Revision history for this message
Michi Henning (michihenning) wrote :

Minor glitches:

+ [ Michi Henning ]
+ * Added utility subdir to header tests.
+ * Bunch of miscellaneous fixes:
+
+ [ James Henstridge ]

Looks like some text has gone missing here. It should be:

* Bunch of miscellaneous fixes:

- Added warning for non-virtual destructors.
- Warnings will disappear once Marcus's child_scopes branch is merged.
- Tidied up the way compiler flags are set in CMakeLists.txt for clarity.
- Added missing dependencies to demos, so we can't run with an out-of-date registry or scoperunner.
- Fixed a number of warnings when building the developer doc.
- Minor doc fixes.
- Minor stylistic code fixes.

My fault, typo in CONFIGFILES:

The value must be a semicolon-separate list of channel names.

Should be "semicolon-separated". When you fix the changelog could you throw that in too for me please?

Other than that, looks good, tests pass for me here, and looking through the changes doesn't show anything unusual.

- Added missing tmp_dir_initialized_ initializer to ScopeBaseImpl.
- Removed redundant lock in QueryCtrlImpl constructor.

review: Needs Fixing

« Back to merge proposal