Code review comment for lp:~marcustomlinson/unity-scopes-api/fix_relative_custom_exec_args

Paweł Stołowski (stolowski) wrote :

Do you mind adding some tests for convert_exec_rel_to_abs (and split_args - would be good to have a check for arguments which contain escaped spaces, e.g. Foo\ Bar.) in the Utils test (test/gtest/scopes/internal/Utils/Utils_test.cpp)? That should allow for a much better test than with a test scope.
Other than that looks good and clean!

review: Needs Fixing

« Back to merge proposal