Code review comment for lp:~marcustomlinson/unity-scopes-api/fix_debug_mode_locate_timeout

Revision history for this message
Michi Henning (michihenning) wrote :

Looks reasonable. Not totally fond of the hard-wired constant there.

I'm not going to hold up this MR because of it. But should we make that a config item? If there is more than one place where that number is used, we probably should... If so, could you open a separate bug please?

review: Approve

« Back to merge proposal