Code review comment for lp:~marcustomlinson/unity-scope-click/lp-1591422

Revision history for this message
dobey (dobey) wrote :

The basics of this look sound, but would be nice if the statements were structured consistent with the rest of the code, like so:

try {
    promise.set_value();
} catch (const std::future_error&) {
    // Ignore promise_already_satisfied
}

review: Needs Fixing

« Back to merge proposal