Code review comment for lp:~marcustomlinson/unity-api/lp-1552082

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Thanks Marcus. These changes look good when considered in isolation, but I'm afaird they have big impact in SettingsDB implementation in the scope. By having file locking implemented on the IniParser level, we're now locking twice (SettingsDB locks the file too); moreover there is some logic around in SettingsDB to give defaults if locking fails etc. If we want to go that route, then I suspect SettingsDB will need changes... Should we consider manual locking (by the called) instead? Let's discuss that in the standup.

review: Needs Fixing

« Back to merge proposal