Code review comment for lp:~marcustomlinson/unity-api/fix-ini-iniparser-test

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

> Just do be clear: does the parser emit an equivalent message that is still as
> informative? Or does it do something that lacks the essential information that
> was there previously?

The messages are still the same, word for word. What they felt worth changing is the single quotes (e.g. group 'x') to fancy left / right double quotes (e.g. value “x”).

I don't think it's a bad idea for us to just forward on the glib error messages, but I do think it's not worth us verifying them in our tests (as things like this happen :D).

« Back to merge proposal