Merge lp:~marcus-lundgren/noise/add-playlist-badge-listener-refactored into lp:~elementary-apps/noise/trunk

Proposed by Marcus Lundgren
Status: Merged
Merged at revision: 1292
Proposed branch: lp:~marcus-lundgren/noise/add-playlist-badge-listener-refactored
Merge into: lp:~elementary-apps/noise/trunk
Diff against target: 38 lines (+8/-6)
1 file modified
src/LibraryWindow.vala (+8/-6)
To merge this branch: bzr merge lp:~marcus-lundgren/noise/add-playlist-badge-listener-refactored
Reviewer Review Type Date Requested Status
Corentin Noël Approve
Review via email: mp+146298@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/LibraryWindow.vala'
--- src/LibraryWindow.vala 2013-02-03 01:03:51 +0000
+++ src/LibraryWindow.vala 2013-02-03 11:05:25 +0000
@@ -698,6 +698,12 @@
698698
699 }699 }
700700
701 public void update_badge_on_playlist_update (Playlist p, SourceListEntry entry) {
702 match_playlist_entry.set (p, entry);
703 p.media_added.connect((s) => { update_playlist_badge (p); });
704 p.media_removed.connect((s) => { update_playlist_badge (p); });
705 }
706
701 private void update_playlist_badge (Playlist playlist) {707 private void update_playlist_badge (Playlist playlist) {
702 var entry = match_playlist_entry.get (playlist);708 var entry = match_playlist_entry.get (playlist);
703 int media_count = playlist.medias.size;709 int media_count = playlist.medias.size;
@@ -726,9 +732,7 @@
726 view_number = view_container.add_view (queue_view);732 view_number = view_container.add_view (queue_view);
727 entry = source_list_view.add_item (view_number, App.player.queue_playlist.name,733 entry = source_list_view.add_item (view_number, App.player.queue_playlist.name,
728 ViewWrapper.Hint.READ_ONLY_PLAYLIST, Icons.MUSIC.gicon);734 ViewWrapper.Hint.READ_ONLY_PLAYLIST, Icons.MUSIC.gicon);
729 match_playlist_entry.set (p, entry);735 update_badge_on_playlist_update (p, entry);
730 p.media_added.connect(() => { update_playlist_badge (p); });
731 p.media_removed.connect(() => { update_playlist_badge (p); });
732 set_treeviewsetup_from_playlist (App.player.queue_playlist, library_manager.queue_setup);736 set_treeviewsetup_from_playlist (App.player.queue_playlist, library_manager.queue_setup);
733 } else if (p.name == _("History")) {737 } else if (p.name == _("History")) {
734 var history_view = new ReadOnlyPlaylistViewWrapper (App.player.history_playlist.rowid);738 var history_view = new ReadOnlyPlaylistViewWrapper (App.player.history_playlist.rowid);
@@ -743,9 +747,7 @@
743 view_number = view_container.add_view (view);747 view_number = view_container.add_view (view);
744 entry = source_list_view.add_item (view_number, p.name, ViewWrapper.Hint.READ_ONLY_PLAYLIST, Icons.PLAYLIST.gicon);748 entry = source_list_view.add_item (view_number, p.name, ViewWrapper.Hint.READ_ONLY_PLAYLIST, Icons.PLAYLIST.gicon);
745 if (p.show_badge == true) {749 if (p.show_badge == true) {
746 match_playlist_entry.set (p, entry);750 update_badge_on_playlist_update (p, entry);
747 p.media_added.connect((s) => { update_playlist_badge (p); });
748 p.media_removed.connect((s) => { update_playlist_badge (p); });
749 }751 }
750 }752 }
751 }753 }

Subscribers

People subscribed via source and target branches