Code review comment for lp:~marcoceppi/charms/trusty/nova-compute/trunk

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Thank you for working on this. Some early input for you:

While this does pass CI, we won't be able to merge it into next as-is, because this MP is flipping stable bits on the next branch, pulling in some other uncommitted changes, and has a conflict.

I think it would be best to re-base from nova-compute/next and re-propose. It may also be worth adding contexts unit_test coverage for the new config options.

« Back to merge proposal