Merge lp:~marcobiscaro2112/unity/fixes-748299 into lp:unity

Proposed by Marco Biscaro
Status: Merged
Merged at revision: 1109
Proposed branch: lp:~marcobiscaro2112/unity/fixes-748299
Merge into: lp:unity
Diff against target: 32 lines (+0/-12)
2 files modified
src/DeviceLauncherIcon.cpp (+0/-11)
src/DeviceLauncherIcon.h (+0/-1)
To merge this branch: bzr merge lp:~marcobiscaro2112/unity/fixes-748299
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+57064@code.launchpad.net

Description of the change

Since commit 1032, the method ActivateLauncherIcon is called from LauncherIcon.cpp (so, there is no need to call it again on DeviceLauncherIcon.cpp).

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Approved! code looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/DeviceLauncherIcon.cpp'
--- src/DeviceLauncherIcon.cpp 2011-03-29 15:24:14 +0000
+++ src/DeviceLauncherIcon.cpp 2011-04-09 23:55:46 +0000
@@ -104,17 +104,6 @@
104 return nux::Color (0xFF333333);104 return nux::Color (0xFF333333);
105}105}
106106
107void
108DeviceLauncherIcon::OnMouseClick (int button)
109{
110 SimpleLauncherIcon::OnMouseClick (button);
111
112 if (button == 1)
113 {
114 ActivateLauncherIcon ();
115 }
116}
117
118std::list<DbusmenuMenuitem *>107std::list<DbusmenuMenuitem *>
119DeviceLauncherIcon::GetMenus ()108DeviceLauncherIcon::GetMenus ()
120{109{
121110
=== modified file 'src/DeviceLauncherIcon.h'
--- src/DeviceLauncherIcon.h 2011-03-29 14:36:45 +0000
+++ src/DeviceLauncherIcon.h 2011-04-09 23:55:46 +0000
@@ -37,7 +37,6 @@
37 void UpdateVisibility ();37 void UpdateVisibility ();
3838
39protected:39protected:
40 void OnMouseClick (int button);
41 std::list<DbusmenuMenuitem *> GetMenus ();40 std::list<DbusmenuMenuitem *> GetMenus ();
42 void UpdateDeviceIcon ();41 void UpdateDeviceIcon ();
4342