Code review comment for lp:~marcobiscaro2112/unity/fixes-742985

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Marco, I'm afraid this is invalid for now.

Indeed, shortcut is a gint, so it can be > 32 (like for a, f and t…) but the fix I was discussing is still in my branch (it's at the other hand). And for that, we need to check that the shortcut != 0 as 0 is the initial value :)

Hope that the explanations helps! Thanks however for your strong merge and participation commitment for unity. There is still a lot of bitesize around (if you need any pointer, to not hesitate to join irc!) :)

review: Disapprove

« Back to merge proposal