Code review comment for lp:~marco-gallotta/ibid/uva

Revision history for this message
marcog (marco-gallotta) wrote :

> Do we want this behaviour?
>
> Query: joe is on acm team foo
> ./ibid/plugins/codecontest.py:461: SADeprecationWarning: Use session.add()
> event.session.save_or_update(member)
> Response: Added joe to team foo
> Query: joe is on acm team foo
> Response: Added joe to team foo
> Query: acm team foo
> Response: foo has members joe and joe, and is known as bar and baz on UVa
> Query: delete joe from acm team foo
> Response: Sorry, I don't know that person
> Query: joe is on acm team qux
> Response: Added joe to team qux

r902. It makes sense to have multiple Robert's on the same team, but I've fixed deletion.

> My unconfigured UVa also does this:

Planning to rework this based on Max/Keegan's comments anyway.

« Back to merge proposal