Code review comment for lp:~marco-gallotta/ibid/contest

Revision history for this message
marcog (marco-gallotta) wrote :

> > Tested on Ibido. For consistency with results, maybe make "for <user>"
> > optional in section/division queries, too, though it won't often be
> > used.
>
> You mean you want it then to list for all users?

Not doing, as per discussion.

> > Perhaps the admin should be able to add anybody without their password
> > -- useful if the bot is a private one for a coaches channel.
> >
> > If I ask for results for a competition I didn't participate in, I get
> > no response. I see no need to have a multiline response if I only
> > competed in one division: "taejo (rabkin1 on USACO) scored 86 in the
> > GOLD division" or "Gold: taejo (rabkin1 on USACO) scored 86" are both
> > better, IMO.
>
> Ok, will add these to my TODO list.

Done.

So everything so far has been addressed. Anything more?

« Back to merge proposal