Code review comment for lp:~marco-gallotta/ibid/contest

> It would be nice if "usaco results for rabkin1" worked using the USACO
> username, if the name is not a linked one. Even nicer, if real names worked
> too.

Done

> Perhaps it would be a good idea to forbid linking accounts in public, to
> discourage people from telling others their password.

Done

> When I tried to link my account on mibid, I waited a while and then got "That
> didn't go down very well. Burp."; So I haven't managed to test that
> successfully (either because of a bug in the plugin, or mibid's setup - a
> proxy issue?).

That was a connection issue on my PC. I have put in something to try catch this, but for now it's untested.

> A few responses are missing full stops. Meta-comment: should the bot
> automatically add full stops to responses that don't end with terminating
> punctuation?

I did a very quick skim of a few plugins and it seems most responses don't end with a full stop. So leaving that as is for now.

> Tested on Ibido. For consistency with results, maybe make "for <user>"
> optional in section/division queries, too, though it won't often be
> used.

You mean you want it then to list for all users?

> Perhaps the admin should be able to add anybody without their password
> -- useful if the bot is a private one for a coaches channel.
>
> If I ask for results for a competition I didn't participate in, I get
> no response. I see no need to have a multiline response if I only
> competed in one division: "taejo (rabkin1 on USACO) scored 86 in the
> GOLD division" or "Gold: taejo (rabkin1 on USACO) scored 86" are both
> better, IMO.

Ok, will add these to my TODO list.