Code review comment for lp:~mapreri/inkscape/support-scour-0.26

On Mon, Jan 23, 2017 at 07:04:34PM -0000, Eduard Braun wrote:
> Would it be viable to land this only as a patch for Debian?

Yes, it's surely viable (we have quite a good support for carrying
out-of-tree patches in debian packages)
Though I'd probably drop it once I'll stop dealing with that old
release, which will probably be in few months anyway, since I clearly
prefer to have as fewer modifications from upstream as possible.

> Are any other distros affected that would warrant having this in the official repo?

I don't really know.
I only deal with Debian and Ubuntu. I can tell you that Ubuntu trusty
(14.04) also has scour 0.26. I don't provide backports for that, but
the official PPAs in
https://launchpad.net/~inkscape.dev/+archive/ubuntu/stable/+packages and
https://launchpad.net/~inkscape.dev/+archive/ubuntu/trunk/+packages do,
and clearly that feature is broken too there.

I'll let the inkscape people (and you) decide whether such support is
important enough.

> If you'd prefer to have it in the Inkscape repo the question is also
> whether merging in trunk is the way to go (I guess 0.92.x would make
> more sense? Will Inkscape 0.93 ever be available for Debian Jessie
> while it's supported?)

It's not only "while it's supported". Clearly I would not provide 0.93
in jessie-backports-sloppy by myself; but given that doing so would not
be hard at all (thank you for not tightening the dependencies!), if a
user was ever to ask for it I'd be inclined grant the wish.

> In either case I noticed one problem with the patch:
> You only need to check if you can "import scour" once (it's the same for 0.26 as well as newer versions).
> You should then in a second check decide from where to import "scourString".

right.
I don't think that's an actual problem though (worse case it'd lead to
duplicated a duplicated import, which python just ignores/deal
gracefully with).